Menu

#1 helpful improvements

open
nobody
None
5
2012-12-06
2007-06-12
marekfr
No

i found that a little annoying that pushing a button causes no action, especially not knowing why.
for you it is simple - you know your program, for new user it might be a trouble to do operation he intended

as a result i added some messagebox'es to inform user what's wrong in configuration

changes mainly apply to renaming from id3 tag

changed FireUI.cs file attached
//--modifications
in
private void id3ToFilenameButton_Click(object sender, System.EventArgs e)

added to inform if no filename format was selected
if (format == "")
MessageBox.Show("Filename format not selected\nPlease select or add one and try again","Error",MessageBoxButtons.OK,MessageBoxIcon.Asterisk);

in
public void Rename()

added
bool renamedFile = false;
RenameTag tag2 = null;

after loop
foreach (ListViewItem item in renameListView.CheckedItems)

added to inform if there was no action queued
if(!renamedFile)
MessageBox.Show("Nothing to do. Please select action to perform", "Information", MessageBoxButtons.OK, MessageBoxIcon.Asterisk);

i extended a little exeption handling, because if you rename many files it is terribly hard to find which file caused problem
tag2 = tag;

MessageBox.Show(this, ex.Message + " Problem with file: " + tag2.Output, "Error");

and finally basic information that reminds to add files from tree or to check already added
in
private void renameButton_Click(object sender, System.EventArgs e)

...else
MessageBox.Show("Nothing to do. Add or check files to rename.", "Information", MessageBoxButtons.OK, MessageBoxIcon.Asterisk);

Discussion

  • marekfr

    marekfr - 2007-06-12

    fixed FireUI

     
  • Chris Callendar

    Chris Callendar - 2007-08-16

    Logged In: YES
    user_id=1362086
    Originator: NO

    Very good point, and thanks for your input. I do tend to forget that other people might use my tool!

     

Log in to post a comment.

Auth0 Logo