|
From: Vlad K. <no...@gi...> - 2026-06-11 12:26:34
|
Branch: refs/heads/master Home: https://github.com/FirebirdSQL/firebird Commit: 70aa27ed70990be6ea86d47390f200154a477c49 https://github.com/FirebirdSQL/firebird/commit/70aa27ed70990be6ea86d47390f200154a477c49 Author: Sergey Khalyutn <kha...@no...> Date: 2026-06-02 (Tue, 02 Jun 2026) Changed paths: M src/common/ThreadStart.h Log Message: ----------- Fix: The compiler does not consider "#define INVALID_HANDLE_VALUE ((HANDLE)(LONG_PTR)-1)" as a constant - compilation error: constexpr variable 'INVALID_HANDLE' must be initialized by a constant expression ``` [build] 77 | constexpr static Handle INVALID_HANDLE = INVALID_HANDLE_VALUE; [build] /code/src/remote\../remote\../common/ThreadStart.h:77:26: error: constexpr variable 'INVALID_HANDLE' must be initialized by a constant expression [build] 77 | constexpr static Handle INVALID_HANDLE = INVALID_HANDLE_VALUE; [build] | ^ ~~~~~~~~~~~~~~~~~~~~ [build] /code/src/remote\../remote\../common/ThreadStart.h:77:43: note: cast that performs the conversions of a reinterpret_cast is not allowed in a constant expression [build] 77 | constexpr static Handle INVALID_HANDLE = INVALID_HANDLE_VALUE; [build] | ^ [build] C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\handleapi.h:27:31: note: expanded from macro 'INVALID_HANDLE_VALUE' [build] 27 | #define INVALID_HANDLE_VALUE ((HANDLE)(LONG_PTR)-1) [build] | ^ ``` Commit: ff8137942e879c69f61476d581704b0cf29a59ca https://github.com/FirebirdSQL/firebird/commit/ff8137942e879c69f61476d581704b0cf29a59ca Author: Sergey Khalyutn <124...@us...> Date: 2026-06-04 (Thu, 04 Jun 2026) Changed paths: M src/common/ThreadStart.h Log Message: ----------- Add comment about "constexpr" not applicable in case Commit: 88945730acee80e05d96c354e361e5a212fa2ee0 https://github.com/FirebirdSQL/firebird/commit/88945730acee80e05d96c354e361e5a212fa2ee0 Author: Vlad Khorsun <hv...@us...> Date: 2026-06-11 (Thu, 11 Jun 2026) Changed paths: M src/common/ThreadStart.h Log Message: ----------- Merge pull request #9049 from notesoft/prepare-for-CMake-Clang-ThreadStart-h Fix: Under Clang compilation constexpr variable 'INVALID_HANDLE' must be initialized by a constant expression Compare: https://github.com/FirebirdSQL/firebird/compare/94c649eed1c6...88945730acee To unsubscribe from these emails, change your notification settings at https://github.com/FirebirdSQL/firebird/settings/notifications |