|
From: <mro...@us...> - 2012-10-28 18:47:36
|
Revision: 57263
http://firebird.svn.sourceforge.net/firebird/?rev=57263&view=rev
Author: mrotteveel
Date: 2012-10-28 18:47:30 +0000 (Sun, 28 Oct 2012)
Log Message:
-----------
Comments for potential issues to investigate
Modified Paths:
--------------
client-java/trunk/.project
client-java/trunk/src/main/org/firebirdsql/jca/FBManagedConnection.java
client-java/trunk/src/main/org/firebirdsql/jdbc/FBConnection.java
Modified: client-java/trunk/.project
===================================================================
--- client-java/trunk/.project 2012-10-26 13:19:11 UTC (rev 57262)
+++ client-java/trunk/.project 2012-10-28 18:47:30 UTC (rev 57263)
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<projectDescription>
- <name>client-java.22.head</name>
+ <name>client-java</name>
<comment></comment>
<projects>
</projects>
Modified: client-java/trunk/src/main/org/firebirdsql/jca/FBManagedConnection.java
===================================================================
--- client-java/trunk/src/main/org/firebirdsql/jca/FBManagedConnection.java 2012-10-26 13:19:11 UTC (rev 57262)
+++ client-java/trunk/src/main/org/firebirdsql/jca/FBManagedConnection.java 2012-10-28 18:47:30 UTC (rev 57263)
@@ -715,7 +715,7 @@
try {
// find XID
-
+ // TODO: Is there a reason why this pieace of code can't use the JDBC Statement class?
AbstractIscTrHandle trHandle2 = (AbstractIscTrHandle)gds.createIscTrHandle();
gds.iscStartTransaction(trHandle2, gdsHelper.getCurrentDbHandle(), tpb.getTransactionParameterBuffer());
Modified: client-java/trunk/src/main/org/firebirdsql/jdbc/FBConnection.java
===================================================================
--- client-java/trunk/src/main/org/firebirdsql/jdbc/FBConnection.java 2012-10-26 13:19:11 UTC (rev 57262)
+++ client-java/trunk/src/main/org/firebirdsql/jdbc/FBConnection.java 2012-10-28 18:47:30 UTC (rev 57263)
@@ -446,6 +446,7 @@
if (this.autoCommit == autoCommit)
return;
+ // FIXME : Looks like this is wrong, see also setSavePoint
if (autoCommit && mc.inDistributedTransaction()) {
throw new FBSQLException("Connection enlisted in distributed transaction", FBSQLException.SQL_STATE_INVALID_TX_STATE);
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|