Re: [Firebird-devel] Build failure of 1.5.4rc1 (gcc 3.4)

[Vlad H. <hv...@us...>]

> >     Yes, MAX_TRA_NUMBER must be MAX_SLONG
> > 
> >     Can you try to use MAX_SLONG in MAX_TRA_NUMBER definition
> >
> > #define MAX_TRA_NUMBER   (MAX_SLONG)
> 
> This makes create_db to work as expected. Hurray! Many thanks, Vlad!

    Very well ;)
 
> Is this change appropriate for all architectures?

    I would said - yes. It is defined in FB2 as SLONG already : 

static const SLONG MAX_TRA_NUMBER = MAX_SLONG;
 
> >     You can log all numbers to be sure
> > 
> > if (header->hdr_next_transaction >= MAX_TRA_NUMBER - 1) 
> >  {
> >   CCH_RELEASE(tdbb, window);
> > 
> > +  gds__log("%ld >= %ld", header->hdr_next_transaction, MAX_TRA_NUMBER - 1);
> 
> beetle  Wed Jan 24 10:42:57 2007
>         0 >= ffffffff7ffffffe
> 
> O, endless fun! :)

    :)

Regads,
Vlad