RE: [Firebird-devel] FB2: which file for type definitions?

[Dmitry Y. <di...@us...>]

Erik,

> currently we have definitions for SIG_FPTR in
>
> 	src/jrd/isc_ipc.cpp
> 	src/jrd/isc_sync.cpp
> 	src/jrd/isc_cray.cpp
>
> with the comment "Keep the following SIG_FPTR definitions in sync..."
>
> I'd like to cleanup the code, but don't know if fb_types.h would be
> the right file to put the definitions in. Any thoughts?

Sorry for not looking at this earlier. I think your cleanup is wrong,
because you include common.h in fb_types.h, but common.h in turn already
includes fb_types.h, but with a macro protection. As a result, the nested
#include is ignored and CLIB_ROUTINE macro gets undefined. I believe you
should place your SIG_FPTR definitions in common.h, either in appropriate
platform section, or somewhere in the bottom of the file. I've chosen the
latter and fixed this in my local tree, now the codebase compiles on win32
again. Take a look at this once more, please, and commit the corrected code.
Thanks.


Dmitry