[Firebird-devel] Latest Setup Script Maybe Bugs??

[Michael R. <ri...@ce...>]

Hi All,

I'm not sure what's the kosher way to accomplish these fixes, but there's a 
couple of things I noticed when playing with the latest setup script:

1:  In the [Run] Section, there are several running systems that have the 
parameter something like so:

		"install ""{app}"" -auto";

When using this I was getting all sorts of weird reults.... taking out the 
outer quotes to:

		install ""{app}"" -auto

seemed to work.

2. The InstallDir() function has code:
		{code:InstallDir|{pf}\Firebird}

And in InstallDir:
	if (sRootDir <> '') then
		Result := ChangeDirConst(sRootDir);

But when I was running my own custom installed based off of the code, I was 
getting blank values back and the "default value" wasn't kicking in.  Can 
somebody more familiar with the code verify if it should be as it is or 
something more like:

	if (sRootDir = '') then
		sRootDir := Default;
	
	Result := ChangeDirConst(sRootDir);

Which seemed to work for me.  [But I may be doing two screwy things that 
just happen to add up to a working install too. :) ]

Thanks a bunch for fielding these questions!
					-Mike