RE: [Firebird-devel] Misc advice

[Ann W. H. <aha...@ib...>]

At 01:31 AM 7/29/2001 -0400, Claudio Valderrama C. wrote:


> > I also added skip and current_role to the blp list so isql
> > doesn't crash when it tries to pretty print blr containing those verbs.
>
>To be sincere, I see you updated jrd\blp.h and have no idea who uses it,

blp.h is the header file for the blr pretty-printer which is (I think)
a built-in blob filter.

>One question: in parse.y you used "value" for FIRST and LIMIT. Do we support
>any value? If I'm not fooling myself, when you use value you might be
>accepting anything, including fields, expressions and NULL.

We should probably check that the value is not null (though that may
have been done by one of the compile routines).  Otherwise, yes, it
should handle fields & expressions.  That's what the routine "computable"
does - is check that the value can be evaluated in the context in which
it will be used.  Should work fine.

>See the
>SUBSTRING thing; I was more restrictive, using pos_short_integer and
>nonneg_short_integer that are defined in the same parse.y file.

That's conservative, though it certainly could be expanded following
the path John used.

>

Regards,

Ann
www.ibphoenix.com
We have answers.