Menu

#5012 fix fltk13-aqua_1.3.3-3 on Xcode 9

Added_to_Fink
closed-accepted
None
5
2017-10-10
2017-09-23
No

Currently the build of fltk13-aqua_1.3.3-3 on Xcode 9 fails with the compiler error...

Fl_Tree_Item.cxx:552:38: error: ordered comparison between pointer and zero ('Fl_Tree_Item *' and 'int')
    if ( from_parent->deparent(from) < 0 )      // deparent self from current parent
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
1 error generated.

This can be worked around with the following Info file change modelled on the upstream inkscape patches reecently added to fink.

Index: fltk13-aqua.info
===================================================================
RCS file: /cvsroot/fink/dists/10.9-libcxx/stable/main/finkinfo/libs/fltk13-aqua.info,v
retrieving revision 1.2
diff -u -r1.2 fltk13-aqua.info
--- fltk13-aqua.info    18 Sep 2015 23:29:19 -0000  1.2
+++ fltk13-aqua.info    23 Sep 2017 01:10:03 -0000
@@ -83,6 +83,7 @@
   perl -pi -e 's/ 755 / 644 / if /\/lib.*\.{a,dylib}/' src/Makefile
   perl -ni -e 'print unless /mandir\)\/cat/' documentation/Makefile
   perl -pi -e 's|share/doc/fltk|share/doc/%n/html|g' configure
+  perl -pi -e 's|from_parent\-\>deparent\(from\) \< 0|\!\(from_parent\-\>deparent\(from\)\)|g' src/Fl_Tree_Item.cxx
 <<
 #
 GCC: 4.0

Tested on 10.13 with 'fink -m'

Discussion

  • Jack Howarth

    Jack Howarth - 2017-09-23

    Info file for fix ltk13-aqua_1.3.3-3 on Xcode 9

     
  • Jack Howarth

    Jack Howarth - 2017-09-23

    Note that this mirrors the inkscape upstream fix of...

    --- inkscape-0.48.5.orig/src/io/inkjar.cpp      2014-02-27 22:16:22.000000000 -0500
    +++ inkscape-0.48.5/src/io/inkjar.cpp   2017-09-21 00:09:49.000000000 -0400
    @@ -107,7 +107,7 @@
    
     bool JarFile::open()
     {
    -    if ((fd = fopen(_filename, O_RDONLY)) < 0) {
    +    if (!(fd = fopen(_filename, "r"))) {
            fprintf(stderr, "open failed.\n");
            return false;
         }
    
     
  • Alexander Hansen

    • summary: fix ltk13-aqua_1.3.3-3 on Xcode 9 --> fix fltk13-aqua_1.3.3-3 on Xcode 9
     
  • Alexander Hansen

    • status: open --> closed-accepted
    • Group: Undergoing_Validation --> Added_to_Fink
     

Log in to post a comment.