Menu

#4965 Update pkgconfig for High Sierra

Other
closed-rejected
None
5
2017-12-16
2017-08-13
No

The following Info file changes and revised patch fixes pkg-config for the new format string strictness in High Sierra.

Index: pkgconfig.info
===================================================================
RCS file: /cvsroot/fink/dists/10.9-libcxx/stable/main/finkinfo/devel/pkgconfig.info,v
retrieving revision 1.1
diff -u -r1.1 pkgconfig.info
--- pkgconfig.info  10 Sep 2015 20:44:04 -0000  1.1
+++ pkgconfig.info  13 Aug 2017 17:00:52 -0000
@@ -1,6 +1,6 @@
 Package: pkgconfig
 Version: 0.28
-Revision: 2
+Revision: 3
 Source: http://pkgconfig.freedesktop.org/releases/pkg-config-%v.tar.gz
 Source-MD5: aa3c86e67551adc3ac865160e34a2a0d
 BuildDepends: <<
@@ -13,7 +13,7 @@
    glib2-shlibs (>= 2.22.0-1)
 <<
 PatchFile: %n.patch
-PatchFile-MD5: 99f9c6946351c0eec11af92f09175c91
+PatchFile-MD5: b5a0268ea1d170747c57f1af821dae08
 SetCFLAGS: -Os
 ConfigureParams: --mandir=%p/share/man --with-pc-path="$pc_path" --enable-dependency-tracking --disable-shared --without-internal-glib PKG_CONFIG=%p/bin/pykg-config PKG_CONFIG_PATH="%p/lib/glib-2.0/pkgconfig-strict:$PKG_CONFIG_PATH"
 CompileScript: <<
@@ -74,6 +74,10 @@
    non-intuitive diagnostics. Fixed in 1.3.0-2, so BDep:>=1.3.0-2
    as easiest way to get clean user experience (even though 1.2.0
    would suffice as well).
+
+   With format string strictness, High Sierra also enforces that
+   %n isn't used in dynamic format strings, but we should just
+   disable its use on darwin in general.
 <<
 DescPort: <<

Tested with 'fink -m' on 10.13.

Discussion

  • Jack Howarth

    Jack Howarth - 2017-08-13

    Info file for pkgconfig-0.28-3

     
  • Jack Howarth

    Jack Howarth - 2017-08-13

    Patch file for pkgconfig-0.28-3

     
  • Daniel Macks

    Daniel Macks - 2017-10-08

    Is this actually used? pkg-config ships with an embedded glib2 source for optional use, but I think we instead opt to use the external lib.

     
  • Daniel Macks

    Daniel Macks - 2017-12-16
    • status: open --> closed-rejected
    • Group: Undergoing_Validation --> Other
     

Log in to post a comment.