Menu

#8 inpropper indentation in module procedure (v3.1.3)

1.0
closed
None
2020-01-13
2020-01-03
No

Hi! First, thank you for your very helpful code.

I noticed whenever there is a “module procedure” declaration line with one procedure name, followed by another module procedure declaration with multiple names in a single line, the indentations will be wrong.

An example input:

module test1
implicit none

interface choose_procedure
module procedure pro1
module procedure pro3, pro4
end interface choose_procedure

end module test1

Example, output:

module test1
  implicit none

  interface choose_procedure
    module procedure pro1
      module procedure pro3, pro4
    end interface choose_procedure

  end module test1

I have tested this with version 3.1.1 and 3.1.4~pre2. I've also attached the debug info from the findent version 3.1.4~pre2

Here’s my command line:
./findent -i2 < test1_input.F90 > test1_output.F90

1 Attachments

Related

Tickets: #8

Discussion

  • Meisam Tabriz

    Meisam Tabriz - 2020-01-03

    Apparently, the attachment has not been uploaded properly! Here’s the file.

     
    • Willem Vermin

      Willem Vermin - 2020-01-03

      Hi,

      thanks for reporting the issue. I will let you know when it is solved,
      if possible ;-)

      Regards,

      Willem Vermin

      On 1/3/20 2:38 PM, Meisam Tabriz wrote:

      Apparently, the attachment has not been uploaded properly! Here’s the file.

      Attachments:

      • test1.dbg (sourceforge.net) (16.6 kB; application/octet-stream)

      ** [tickets:#8] inpropper indentation in module procedure (v3.1.3)**

      Status: open
      Milestone: 1.0
      Created: Fri Jan 03, 2020 01:35 PM UTC by Meisam Tabriz
      Last Updated: Fri Jan 03, 2020 01:35 PM UTC
      Owner: Willem Vermin
      Attachments:

      • test1.dbg (sourceforge.net) (0 Bytes; application/octet-stream)

      Hi! First, thank you for your very helpful code.

      I noticed whenever there is a “module procedure” declaration line with one procedure name, followed by another module procedure declaration with multiple names in a single line, the indentations will be wrong.

      An example input:
      ~~~
      module test1
      implicit none

      interface choose_procedure
      module procedure pro1
      module procedure pro3, pro4
      end interface choose_procedure

      end module test1
      ~~~

      Example, output:
      ~~~
      module test1
      implicit none

      interface choose_procedure
      module procedure pro1
      module procedure pro3, pro4
      end interface choose_procedure

      end module test1

      ~~~
      I have tested this with version 3.1.1 and 3.1.4~pre2. I've also attached the debug info from the findent version 3.1.4~pre2

      Here’s my command line:
      ./findent -i2 < test1_input.F90 > test1_output.F90


      Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/findent/tickets/8/

      To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

       

      Related

      Tickets: #8

    • Willem Vermin

      Willem Vermin - 2020-01-03

      You can checkout the devel version (3.1.4~pre3), the problem seems to be
      solved. I did not take in account that a 'module procedure' statement
      can contain more than one procedures.

      In the mean time I will prepare a new distribution.

      Willem

       
      • Meisam Tabriz

        Meisam Tabriz - 2020-01-03

        With a quick check, this problem seems to be solved. Many thanks for your quick response and fix!

         
  • Willem Vermin

    Willem Vermin - 2020-01-04

    The fixed version is now available as 3.1.4 in 'files'.
    Btw: added recognition of NON_RECURSIVE
    Never used, I guess, but it is in the standard.

     
  • Willem Vermin

    Willem Vermin - 2020-01-13
    • status: open --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB