fieldml-automated1 Mailing List for FieldML
Status: Beta
Brought to you by:
richardchr
Menu
▾
▴
fieldml-automated1 — One of the automated notifications lists
You can subscribe to this list here.
| 2009 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(1) |
Nov
(12) |
Dec
(1) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2010 |
Jan
(1) |
Feb
(7) |
Mar
(13) |
Apr
|
May
|
Jun
(1) |
Jul
(1) |
Aug
|
Sep
|
Oct
|
Nov
(1) |
Dec
|
| 2011 |
Jan
(1) |
Feb
|
Mar
|
Apr
|
May
(2) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: <fi...@go...> - 2011-05-09 03:26:21
|
Comment by r.brit...@auckland.ac.nz: Line-by-line comments: File: /20110506 - Data objects with shared sources and HDF5 support/triquadratic heart.xml (re861f553942ae2352ae1cd745dcfc52e8ec01b52) =============================================================================== Line 8: <Import location="library.xml" region="library"> ------------------------------------------------------------------------------- Change "region" attribute to "remoteRegion". Change location attribute to xlink:href (CL himself suggested at meeting today). Line 9: <ImportType localName="real.type" remoteName="library.real.1d"/> ------------------------------------------------------------------------------- Since the remote region is library, remoteName should just be "read.1d", same for following lines. CL will correct this so that library evaluator names aren't prefixed with "library." For more information: http://code.google.com/p/fieldml/source/detail?r=e861f553942ae2352ae1cd745dcfc52e8ec01b52&repo=mockups |
|
From: <fi...@go...> - 2011-05-02 03:02:57
|
Comment by r.chris...@auckland.ac.nz: Line-by-line comments: File: /input/triquadratic heart test.xml (rf1f61899458e841acc327387bd7f492fdf2df99d) =============================================================================== Line 2: <Fieldml version="0.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="Fieldml.xsd"> ------------------------------------------------------------------------------- Version number needs updating. Straight to 0.4? Line 74: <Xi name="xi"> ------------------------------------------------------------------------------- Change <Xi> tag name to <Chart>. Line 181: <ReferenceEvaluator name="heart.coordinates" evaluator="heart.coordinates.template"> ------------------------------------------------------------------------------- This is missing a valueType. For more information: http://code.google.com/p/fieldml/source/detail?r=f1f61899458e841acc327387bd7f492fdf2df99d&repo=testbed-scala |
|
From: <fi...@go...> - 2011-01-20 02:57:41
|
Comment by r.chris...@auckland.ac.nz: Line-by-line comments: File: /FieldML 0.3 - Evaluator pipelines/triquadratic heart.xml (rd6f64c4cd6b7b0a2eb7cc57942e2840c2659bf43) =============================================================================== Line 135: <Domain name="heart.geometry"> ------------------------------------------------------------------------------- This probably shouldn't be called heart.geometry; it is just a generic coordinates domain for the region & could be used for embedding multiple coordinate fields defined over different domains. For more information: http://code.google.com/p/fieldml/source/detail?r=d6f64c4cd6b7b0a2eb7cc57942e2840c2659bf43&repo=mockups |
|
From: <fi...@go...> - 2010-11-14 18:59:37
|
Comment by r.brit...@auckland.ac.nz: Line-by-line comments: File: /FieldML 0.3 - Evaluator pipelines/triquadratic heart with reuse.xml (r953c69f29853c60d46cb017051fa25108295999e) =============================================================================== Line 135: <fileData file="heart.node.pressure" type="lines" offset="0" /> ------------------------------------------------------------------------------- Please include data files with mock-ups (even if numerical values are just dummy values): heart.node.coordinates heart.node.pressure heart.node.velocity For more information: http://code.google.com/p/fieldml/source/detail?r=953c69f29853c60d46cb017051fa25108295999e&repo=mockups |
|
From: <fie...@go...> - 2010-07-13 05:19:02
|
r.brit...@auckland.ac.nz commented on revision r3b744c803152f8bd203159d3cd803aa734607d7b in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=3b744c803152f8bd203159d3cd803aa734607d7b Line-by-line comments: File: /trunk/C/data/HEX-M2-V2-P1_FE.xml (r82da0009268bde32225a8a25856853e4f0344fbe) =============================================================================== Line 19: <shapes> ------------------------------------------------------------------------------- Why is the default shape attribute not used here? Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=3b744c803152f8bd203159d3cd803aa734607d7b -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-06-07 23:03:20
|
r.brit...@auckland.ac.nz commented on revision r2442ad5d6031215502f9e2b71259446363f1862f in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=2442ad5d6031215502f9e2b71259446363f1862f Line-by-line comments: File: /trunk/C/src/Fieldml_0.2.xsd (r82da0009268bde32225a8a25856853e4f0344fbe) =============================================================================== Line 105: <xs:complexType name="FileDataType"> ------------------------------------------------------------------------------- Rather than assuming we are working with a local file system, it would perhaps be preferable to use URI's here, and adopt the existing W3C standards for how these can refer to local files, network resources, and perhaps even introduce new types of locations, e.g. referring to data located on a separate computational node via some ID mapping system. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=2442ad5d6031215502f9e2b71259446363f1862f -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-03-25 02:03:07
|
r.brit...@auckland.ac.nz commented on revision r14d8bde0d2f7397d3048e7df9292aac6e4fa127d in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=14d8bde0d2f7397d3048e7df9292aac6e4fa127d Line-by-line comments: File: /trunk/src/fieldml/region/Library.java (r14d8bde0d2f7397d3048e7df9292aac6e4fa127d) =============================================================================== Line 85: EnsembleDomain cubicHermiteDerivativesDomain = new EnsembleDomain( "library.interpolation.hermite.derivatives", 4 ); ------------------------------------------------------------------------------- BiCubicHermite would have 4 "derivatives": u, du/dξ1, du/dξ2 and d2u/dξ1 dξ2. Is that what the number 4 refers to here? If so, why is it specific to the 2D case, but with a name that sounds more general? Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=14d8bde0d2f7397d3048e7df9292aac6e4fa127d -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-03-11 00:39:32
|
caton.little commented on revision r563b97cf72c1eab1de6daa724d70289c4f76b2b4 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=563b97cf72c1eab1de6daa724d70289c4f76b2b4 General Comment: Named 'pipeline' branch, 'context' branch is the current default. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=563b97cf72c1eab1de6daa724d70289c4f76b2b4 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-03-10 22:04:59
|
caton.little commented on revision r563b97cf72c1eab1de6daa724d70289c4f76b2b4 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=563b97cf72c1eab1de6daa724d70289c4f76b2b4 General Comment: There are indeed meant to be two branches... I'm trying to figure out how to rename one of them, as they both seem to be called 'default'. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=563b97cf72c1eab1de6daa724d70289c4f76b2b4 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-03-10 21:24:04
|
r.brit...@auckland.ac.nz commented on revision r563b97cf72c1eab1de6daa724d70289c4f76b2b4 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=563b97cf72c1eab1de6daa724d70289c4f76b2b4 Score: Negative General Comment: This commit created a second Mercurial Head. Some explanation is needed as to why this was not merged, and which one is the intended true head. Or are there meant to be 2 branches? If so, use a proper Mercurial branch. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=563b97cf72c1eab1de6daa724d70289c4f76b2b4 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-03-09 04:21:02
|
r.brit...@auckland.ac.nz commented on revision r3599f7443bad40c52f2524243cf3e9a9be9d9dac in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=3599f7443bad40c52f2524243cf3e9a9be9d9dac Line-by-line comments: File: /trunk/src/fieldml/function/TensorBasis.java (r3599f7443bad40c52f2524243cf3e9a9be9d9dac) =============================================================================== Line 50: } ------------------------------------------------------------------------------- Suggestion: throw an exception if the part is not recognised. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=3599f7443bad40c52f2524243cf3e9a9be9d9dac -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-03-09 03:53:12
|
r.brit...@auckland.ac.nz commented on revision r39addccf2767fd281b3709ddd0af9d24a570331a in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=39addccf2767fd281b3709ddd0af9d24a570331a Line-by-line comments: File: /trunk/src/fieldml/annotations/SerializationAsString.java (r099ca82d095523df9098716e11ef45a40f7ebd09) =============================================================================== Line 1: package fieldml.annotations; ------------------------------------------------------------------------------- Annotations belong under fieldmlx package. File: /trunk/src/fieldml/mesh/MergedMesh.java (rce4cfaac120fd83156fa6fee76a7bd259f8a45d1) =============================================================================== Line 1: package fieldml.mesh; ------------------------------------------------------------------------------- Seems like everything currently under fieldml.mesh package can be deleted? Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=39addccf2767fd281b3709ddd0af9d24a570331a -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-03-09 03:24:41
|
r.brit...@auckland.ac.nz commented on revision r39addccf2767fd281b3709ddd0af9d24a570331a in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=39addccf2767fd281b3709ddd0af9d24a570331a Line-by-line comments: File: /trunk/data/FieldmlTest.xml (r67811858f274b4a0423b0286ff8d92f77de96eaf) =============================================================================== Line 46: <fields>"test_mesh.coordinates.template1" "test_mesh.coordinates.template2" "test_mesh.coordinates.xy" </fields> ------------------------------------------------------------------------------- Using white-space to separate ID's is not good XML design. Use XML tags (e.g. tags allow standard tools to be used for XML transforms, stronger XML validation etc.). Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=39addccf2767fd281b3709ddd0af9d24a570331a -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-03-08 22:00:28
|
r.brit...@auckland.ac.nz commented on revision r5f19b6551afdeba21f05cb26837eb03cecd0db8f in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=5f19b6551afdeba21f05cb26837eb03cecd0db8f Line-by-line comments: File: /trunk/src/fieldml/BicubicHermiteTest.java (r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5) =============================================================================== Line 165: "test_mesh.bicubic_hermite.element_parameter", mesh1DDomain ); ------------------------------------------------------------------------------- This does not seem to be serialised yet. (i.e. the string "test_mesh.bicubic_hermite.element_parameter" does not appear in BicubicHermiteTest.xml. (whereas test_mesh.bicubic_hermite.element_parameters does). Caton already pointed out that this is just because it was not added to the region. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=5f19b6551afdeba21f05cb26837eb03cecd0db8f -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-03-08 21:32:41
|
r.brit...@auckland.ac.nz commented on revision r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 Line-by-line comments: File: /trunk/src/fieldml/BicubicHermiteTest.java (r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5) =============================================================================== Line 77: EnsembleParameters quadNodeList = new EnsembleParameters( "test_mesh.quad_nodes", globalNodesListDomain, meshDomain.getElementDomain() ); ------------------------------------------------------------------------------- meshDomain.getElementDomain() hides a subtlety. In the serialisation, this will just be a direct reference to the Element domain, but in the Java code, it hints at an association with the meshDomain as well. Either explicitly make the association with the mesh so that it appears in the serialisation as well, or directly refer to the element domain, without using the meshDomain. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-03-08 21:13:59
|
r.brit...@auckland.ac.nz commented on revision r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 Line-by-line comments: File: /trunk/src/fieldml/BicubicHermiteTest.java (r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5) =============================================================================== Line 73: EnsembleDomain globalNodesDomain = new EnsembleDomain( testRegion, "test_mesh.nodes", 16 ); ------------------------------------------------------------------------------- Shouldn't this be 6 nodes? Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-03-08 21:09:48
|
r.brit...@auckland.ac.nz commented on revision r14d8bde0d2f7397d3048e7df9292aac6e4fa127d in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=14d8bde0d2f7397d3048e7df9292aac6e4fa127d Line-by-line comments: File: /trunk/src/fieldml/region/SubRegion.java (r14d8bde0d2f7397d3048e7df9292aac6e4fa127d) =============================================================================== Line 3: public class SubRegion ------------------------------------------------------------------------------- Revision comment does not mention the refactoring of Region into Region and SubRegion Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=14d8bde0d2f7397d3048e7df9292aac6e4fa127d -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-03-08 20:59:04
|
r.brit...@auckland.ac.nz commented on revision r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 Line-by-line comments: File: /trunk/data/FieldmlTest.xml (r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5) =============================================================================== Line 15: <EnsembleDomain baseDomain="test_mesh.domain.elements" name="test_mesh.domain.elements"> ------------------------------------------------------------------------------- Please explain the meaning of using the same domain as the base domain and as the domain being declared." File: /trunk/src/fieldml/region/WorldRegion.java (r7970cbd97420a00323fec528369fce4738d460c3) =============================================================================== Line 3: public class WorldRegion ------------------------------------------------------------------------------- WorldRegion does not need to be its own subclass. Rather, just instantiate a region from a factory method of the Region class. This is similar to the comment made about 2 weeks ago for Library: Library also does not need to be a sub-class of Region. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-03-04 05:17:27
|
r.brit...@auckland.ac.nz commented on revision r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 Line-by-line comments: File: /trunk/data/BicubicHermiteTest.xml (r472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5) =============================================================================== Line 48: <parameterDomains>"test_mesh.nodes" </parameterDomains> ------------------------------------------------------------------------------- Serialisation doesn't look right. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=472a5516ae7e8d48bf5adad1283b6f9cdd5ecfb5 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-02-25 03:06:09
|
r.brit...@auckland.ac.nz commented on revision rc0f8a6721c7beb143c7173175fe0c862ea1f307b in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=c0f8a6721c7beb143c7173175fe0c862ea1f307b Line-by-line comments: File: /trunk/data/BicubicHermiteTest.xml (rc0f8a6721c7beb143c7173175fe0c862ea1f307b) =============================================================================== Line 88: <FunctionEvaluator function="fieldml.function.BicubicHermite@1cde100" functionDomain="test_mesh.domain" name="test_mesh.bicubic_hermite" valueDomain="library.weighting.list" /> ------------------------------------------------------------------------------- Serialisation mechanism still needs completion. File: /trunk/data/FieldmlTest.xml (r14d8bde0d2f7397d3048e7df9292aac6e4fa127d) =============================================================================== Line 42: <FunctionEvaluator function="fieldml.function.BilinearLagrange@c2a132" functionDomain="test_mesh.domain" name="test_mesh.bilinear_lagrange" valueDomain="library.weighting.list" /> ------------------------------------------------------------------------------- Again, serialisation still needs completion, and a few other places. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=c0f8a6721c7beb143c7173175fe0c862ea1f307b -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-02-24 20:38:02
|
r.brit...@auckland.ac.nz commented on revision rc0f8a6721c7beb143c7173175fe0c862ea1f307b in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=c0f8a6721c7beb143c7173175fe0c862ea1f307b Line-by-line comments: File: /trunk/src/fieldml/region/Library.java (r14d8bde0d2f7397d3048e7df9292aac6e4fa127d) =============================================================================== Line 15: extends Region ------------------------------------------------------------------------------- Library should not be a sub-class of Region. It should just instantiate a region and add the library domains to it. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=c0f8a6721c7beb143c7173175fe0c862ea1f307b -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-02-12 02:21:54
|
richardchristie commented on revision r896ca1f74c732461f1682e36c743e877b8afb416 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=896ca1f74c732461f1682e36c743e877b8afb416 Line-by-line comments: File: /trunk/src/fieldml/region/Region.java (r896ca1f74c732461f1682e36c743e877b8afb416) =============================================================================== Line 35: private static final Region library; ------------------------------------------------------------------------------- Should move creation of library region and its contents to separate utility module so Region.java can focus on actual region API (appendChild regions etc.) [Also need to finalise how each region is connected to library; are there multiple libraries? Is there one library region with sub regions (e.g. with URL names) for sub-libraries?] Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=896ca1f74c732461f1682e36c743e877b8afb416 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-02-08 03:50:17
|
richardchristie commented on revision r896ca1f74c732461f1682e36c743e877b8afb416 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=896ca1f74c732461f1682e36c743e877b8afb416 Line-by-line comments: File: /trunk/src/fieldml/evaluator/FunctionEvaluator.java (r896ca1f74c732461f1682e36c743e877b8afb416) =============================================================================== Line 24: //TODO For now, this class only supports evaluation on a mesh. ------------------------------------------------------------------------------- Should be able to evaluate a function on any incoming values of the right dimension. This is also where deriving domain and field from a common base class makes things easier: a function can act on xi values as easily as it acts on coordinate field values, or any other field. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=896ca1f74c732461f1682e36c743e877b8afb416 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-02-04 23:43:19
|
r.brit...@auckland.ac.nz commented on revision r896ca1f74c732461f1682e36c743e877b8afb416 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=896ca1f74c732461f1682e36c743e877b8afb416 Line-by-line comments: File: /trunk/src/fieldml/FieldmlTest.java (r896ca1f74c732461f1682e36c743e877b8afb416) =============================================================================== Line 239: meshCoordinatesT2.setEvaluator( 4, elementBiquadraticLagrange ); ------------------------------------------------------------------------------- Caton's and Richard's idea: being able to use one field as the default value for another field would make it much cleaner to create a perturbation like this. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=896ca1f74c732461f1682e36c743e877b8afb416 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-02-04 04:36:44
|
r.brit...@auckland.ac.nz commented on revision r896ca1f74c732461f1682e36c743e877b8afb416 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=896ca1f74c732461f1682e36c743e877b8afb416 Line-by-line comments: File: /trunk/src/fieldml/value/EnsembleDomainValue.java (rf68ed524c6d86c9df379b19a6b45387360902a4b) =============================================================================== Line 8: public final int values[]; ------------------------------------------------------------------------------- Why is this an array? And why is it public? Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=896ca1f74c732461f1682e36c743e877b8afb416 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |