fieldml-automated1 Mailing List for FieldML (Page 2)
Status: Beta
Brought to you by:
richardchr
Menu
▾
▴
fieldml-automated1 — One of the automated notifications lists
You can subscribe to this list here.
| 2009 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(1) |
Nov
(12) |
Dec
(1) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2010 |
Jan
(1) |
Feb
(7) |
Mar
(13) |
Apr
|
May
|
Jun
(1) |
Jul
(1) |
Aug
|
Sep
|
Oct
|
Nov
(1) |
Dec
|
| 2011 |
Jan
(1) |
Feb
|
Mar
|
Apr
|
May
(2) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: <fie...@go...> - 2010-02-04 04:19:34
|
r.brit...@auckland.ac.nz commented on revision rf68ed524c6d86c9df379b19a6b45387360902a4b in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=f68ed524c6d86c9df379b19a6b45387360902a4b Line-by-line comments: File: /trunk/data/HangingNodeTest.xml (rf68ed524c6d86c9df379b19a6b45387360902a4b) =============================================================================== Line 163: <BilinearLagrange name="test_mesh.mesh.bilinear_lagrange" valueDomain="library.bilinear_lagrange.parameters"> ------------------------------------------------------------------------------- Can't have a tag named "BilinearLagrange", that is probably meant to be named "Evaluator" or something like that? Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=f68ed524c6d86c9df379b19a6b45387360902a4b -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2010-01-21 21:28:15
|
richardchristie commented on revision r833383b6edad8c657b0d0c001a7f07b8ec8b9b65 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=833383b6edad8c657b0d0c001a7f07b8ec8b9b65 Line-by-line comments: File: /trunk/src/fieldml/FieldmlTest.java (r833383b6edad8c657b0d0c001a7f07b8ec8b9b65) =============================================================================== Line 1: package fieldml; ------------------------------------------------------------------------------- Move examples to separate folder. Also move utility source code to cleanly separate from FieldML objects. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=833383b6edad8c657b0d0c001a7f07b8ec8b9b65 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2009-12-17 21:48:36
|
caton.little commented on revision r833383b6edad8c657b0d0c001a7f07b8ec8b9b65 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=833383b6edad8c657b0d0c001a7f07b8ec8b9b65 Line-by-line comments: File: /trunk/src/fieldml/QuadraticBSplineExample.java (r833383b6edad8c657b0d0c001a7f07b8ec8b9b65) =============================================================================== Line 211: PiecewiseTemplate meshCoordinates = new PiecewiseTemplate( "test_mesh.coordinates", meshDomain ); ------------------------------------------------------------------------------- This should be called meshCoordinatesTemplate Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=833383b6edad8c657b0d0c001a7f07b8ec8b9b65 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2009-11-23 22:36:04
|
chris.br...@dpag.ox.ac.uk commented on revision r4687d6aa61b742927a64e4977b87e44b81b98514 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=4687d6aa61b742927a64e4977b87e44b81b98514 Line-by-line comments: File: /trunk/src/fieldml/BicubicHermiteTriquadTest.java (r4687d6aa61b742927a64e4977b87e44b81b98514) =============================================================================== Line 125: ContinuousDomain meshXYZDomain = library.getContinuousDomain( "library.co-ordinates.rc.xyz" ); ------------------------------------------------------------------------------- Two comments: (1) rc.xyz could be the reference for the individual components. When we get a reference to rc.xyz we automatically have the reference to the individual domains. (2) Maybe through an array i.e., vector like, meshXYZDomain[1]??? Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=4687d6aa61b742927a64e4977b87e44b81b98514 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2009-11-23 21:32:10
|
chris.br...@dpag.ox.ac.uk commented on revision r4687d6aa61b742927a64e4977b87e44b81b98514 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=4687d6aa61b742927a64e4977b87e44b81b98514 Line-by-line comments: File: /trunk/src/fieldml/BicubicHermiteTriquadTest.java (r4687d6aa61b742927a64e4977b87e44b81b98514) =============================================================================== Line 100: testRegion.addDomain( globalNodesDomain ); ------------------------------------------------------------------------------- Rather than add a domain to a region afterwards could we have region as a parameter to the constructor??? Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=4687d6aa61b742927a64e4977b87e44b81b98514 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2009-11-20 12:28:34
|
r.brit...@auckland.ac.nz commented on revision r4687d6aa61b742927a64e4977b87e44b81b98514 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=4687d6aa61b742927a64e4977b87e44b81b98514 Line-by-line comments: File: /trunk/src/fieldml/BicubicHermiteTriquadTest.java (r4687d6aa61b742927a64e4977b87e44b81b98514) =============================================================================== Line 174: meshdZ.setValue( -1.0, 3, 2 ); ------------------------------------------------------------------------------- I think that this extra direction at this node creates two extra degrees of freedom. There should only be a total of 28 (= 7 nodes X 4 dofs per node) in total. Poul's idea is that the direction 3 parameters are not specified explicitly, but are specified as being calculated (linear map) from existing dofs. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=4687d6aa61b742927a64e4977b87e44b81b98514 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2009-11-19 19:33:37
|
r.brit...@auckland.ac.nz commented on revision rb8d54ebf0a19b8c494022fb8fd0a9511cf248a93 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=b8d54ebf0a19b8c494022fb8fd0a9511cf248a93 Line-by-line comments: File: /trunk/data/BicubicHermiteTest.xml (r0468aa218b219403ca376f7fcdacb4f3d5fe4a09) =============================================================================== Line 203: <ContinuousParameters defaultValue="[1.0, 1.0, 1.0, 1.0]" name="test_mesh.cubic_hermite_scaling" valueDomain="library.bicubic_hermite.scaling"> ------------------------------------------------------------------------------- Rather than an attribute for the default value, it would be better to use something consistent with the way each of the "entries" are done, i.e. <Default> <ContinuousDomainValue> <values>1.0 1.0 1.0 1.0 </values> </ContinuousDomainValue> </Default> Line 415: <BicubicHermiteQuadEvaluator dofs="test_mesh.bicubic_parameters.z" dofScaling="test_mesh.cubic_hermite_scaling" dofIndexes="test_mesh.quad_nodes" name="hermite_quad" /> ------------------------------------------------------------------------------- We don't want tags as specific as this. Rather, something like: <Evaluator definition="library.BicubicHermiteQuadEvaluator" dofs= ... /> Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=b8d54ebf0a19b8c494022fb8fd0a9511cf248a93 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2009-11-19 01:55:09
|
r.brit...@auckland.ac.nz commented on revision r0cc1faa2daebbb4c1f6eccc8eb87aa3a6908ab76 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=0cc1faa2daebbb4c1f6eccc8eb87aa3a6908ab76 Line-by-line comments: File: /trunk/src/fieldml/value/DomainValue.java (r43301baffdcdfb5c40e234b3023db91219296c2f) =============================================================================== Line 6: public abstract class DomainValue<D extends Domain> ------------------------------------------------------------------------------- Withdrawing that comment. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=0cc1faa2daebbb4c1f6eccc8eb87aa3a6908ab76 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2009-11-19 01:19:14
|
r.brit...@auckland.ac.nz commented on revision r0cc1faa2daebbb4c1f6eccc8eb87aa3a6908ab76 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=0cc1faa2daebbb4c1f6eccc8eb87aa3a6908ab76 Line-by-line comments: File: /trunk/src/fieldml/value/DomainValue.java (r43301baffdcdfb5c40e234b3023db91219296c2f) =============================================================================== Line 6: public abstract class DomainValue<D extends Domain> ------------------------------------------------------------------------------- Doesn't seem much point using a generic here. Just make the type of the domain attribute be "Domain". Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=0cc1faa2daebbb4c1f6eccc8eb87aa3a6908ab76 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2009-11-18 03:09:53
|
r.brit...@auckland.ac.nz commented on revision r43301baffdcdfb5c40e234b3023db91219296c2f in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=43301baffdcdfb5c40e234b3023db91219296c2f Line-by-line comments: File: /trunk/src/fieldml/evaluator/HermiteQuadEvaluator.java (r43301baffdcdfb5c40e234b3023db91219296c2f) =============================================================================== Line 13: public class HermiteQuadEvaluator ------------------------------------------------------------------------------- Do we want to rename this to "BicubicHermiteQuadEvaluator"? Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=43301baffdcdfb5c40e234b3023db91219296c2f -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2009-11-13 03:12:57
|
caton.little commented on revision r92851c766feec70dd7718032e3c5a8b55d7f5829 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=92851c766feec70dd7718032e3c5a8b55d7f5829 General Comment: It seems that Eclipse's Rename refactoring doesn't play nicely with Mercurial (or rather, VecTrace's Mercurial plugin doesn't call 'hg rename' after a rename operation). If you click 'diff' for an added file, it seems to figure out when its contents are significantly similar to a deleted file, though. Line-by-line comments: File: /trunk/src/fieldml/FieldmlTest.java (r92851c766feec70dd7718032e3c5a8b55d7f5829) =============================================================================== Line 93: private static void test() ------------------------------------------------------------------------------- Shift this out to JUnit Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=92851c766feec70dd7718032e3c5a8b55d7f5829 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2009-11-12 22:53:32
|
caton.little commented on revision re5b76cb6125289d55fc7c92729dd1cf758b056ec in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=e5b76cb6125289d55fc7c92729dd1cf758b056ec Line-by-line comments: File: /trunk/data/FieldmlTest.xml (re5b76cb6125289d55fc7c92729dd1cf758b056ec) =============================================================================== Line 40: <EnsembleDomain name="library.local_nodes.quad.biquadratic"> ------------------------------------------------------------------------------- This actually has nothing to do with biquadratic interpolation, it's just a 3x3 node layout for a quad. Line 44: ------------------------------------------------------------------------------- Add a local node -> xi location map. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=e5b76cb6125289d55fc7c92729dd1cf758b056ec -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2009-11-12 22:11:12
|
caton.little commented on revision re5b76cb6125289d55fc7c92729dd1cf758b056ec in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=e5b76cb6125289d55fc7c92729dd1cf758b056ec Line-by-line comments: File: /trunk/data/FieldmlTest.xml (re5b76cb6125289d55fc7c92729dd1cf758b056ec) =============================================================================== Line 17: <ContinuousDomain dimensions="2" name="test_mesh.co-ordinates.xy" /> ------------------------------------------------------------------------------- This could/should be just the product of the x and y domains. Line 36: <values>1 2 3 </values> ------------------------------------------------------------------------------- Missing element 4. Line 49: <entry key="3" value="library.shape.triangle.00_10_01" /> ------------------------------------------------------------------------------- Missing element 4. Line 328: <SimpleMapEntry key="1" value="biquadratic_quad" /> ------------------------------------------------------------------------------- Interpolation for elements 4 and 1 are transposed. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=e5b76cb6125289d55fc7c92729dd1cf758b056ec -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2009-11-12 08:31:58
|
r.brit...@auckland.ac.nz commented on revision r92851c766feec70dd7718032e3c5a8b55d7f5829 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=92851c766feec70dd7718032e3c5a8b55d7f5829 General Comment: In order to make diffs workable, please use Hg rename, rather than delete/add. Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=92851c766feec70dd7718032e3c5a8b55d7f5829 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <fie...@go...> - 2009-11-12 08:27:51
|
r.brit...@auckland.ac.nz commented on revision rd932e7726c7c1e606e8e07947f110166877189f4 in project fieldml-java2. Details are at http://code.google.com/p/fieldml-java2/source/detail?r=d932e7726c7c1e606e8e07947f110166877189f4 General Comment: Please rename "BiquadQuadEvaluator" to BiquadraticQuadEvaluator". Respond to these comments at http://code.google.com/p/fieldml-java2/source/detail?r=d932e7726c7c1e606e8e07947f110166877189f4 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
|
From: <cod...@go...> - 2009-10-02 03:27:37
|
r.brit...@auckland.ac.nz commented on revision r76 in project fieldml-java. Details are at http://code.google.com/p/fieldml-java/source/detail?r=76 Line-by-line comments: File: /trunk/data/MixedGeometry.xml (r76) =============================================================================== Line 289: <global_dof_list id="global.mesh.y"> ------------------------------------------------------------------------------- Test comment: please ignore this comment. Respond to these comments at http://code.google.com/p/fieldml-java/source/detail?r=76 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings |
