Re: [FFADO-devel] But found with Save Ffado 2.2.3

[azvinz <az...@ya...>]

Hello Devs,

Ich just wanted to add a bug report on the ffado subversion trac but 
however I can't sign in and log in..

So here, I was looking in the source code of rme.py

http://subversion.ffado.org/browser/trunk/libffado/support/mixer-qt4/ffado/mixer/rme.py

and I think I found the bug: in the saveSettings(), for each matrix the 
*inputmatrix* will be called:

477         def saveSettings(self, indent):
478             saveString = []
479             idt = indent + "  "
480             saveString.append('%s<inputmatrix>\n' % indent)
481             saveString.extend(self.*inputmatrix*.saveSettings(idt))
482             # Do not forget to mention the adopted rule for matrix 
columns mixer
483             #  This might be useful for future import function
484             saveString.append("%s  <col_rule>\n" % indent)
485             saveString.append("%s    Columns_are_inputs\n" % indent)
486             saveString.append("%s  </col_rule>\n" % indent)
487             saveString.append('%s</inputmatrix>\n' % indent)
488
489             saveString.append('%s<playbackmatrix>\n' % indent)
490             saveString.extend(self.*inputmatrix*.saveSettings(idt))
491             # Do not forget to mention the adopted rule for matrix 
columns mixer
492             #  This might be useful for future import function
493             saveString.append("%s  <col_rule>\n" % indent)
494             saveString.append("%s    Columns_are_inputs\n" % indent)
495             saveString.append("%s  </col_rule>\n" % indent)
496             saveString.append('%s</playbackmatrix>\n' % indent)
497
498             saveString.append('%s<outputmatrix>\n' % indent)
499             saveString.extend(self.*inputmatrix*.saveSettings(idt))
500             # Do not forget to mention the adopted rule for matrix 
columns mixer
501             #  This might be useful for future import function
502             saveString.append("%s  <col_rule>\n" % indent)
503             saveString.append("%s    Columns_are_inputs\n" % indent)
504             saveString.append("%s  </col_rule>\n" % indent)
505             saveString.append('%s</outputmatrix>\n' % indent)
506             return saveString


All the best,

Vince


On 10/12/2017 04:12 PM, azvinz via FFADO-devel wrote:
> Hello Devs,
>
> I figured out a Bug in FFADO 2.2.3 on Ubuntu (Interface is Fireface 800):
>
> While Saving a preset via Menu:File/Save, the values of the Input 
> Mixer will be written into all matrixes in the xml file (inputmatrix, 
> playbackmatrix, outputmatrix), instead of writing it in inputmatrix only.
>
> Changes in the playback matrix or output matrix will not be saved (or 
> overwrited by inputmatrix?)
>
> Hope this can help, thank you for this amazing piece of software!
>
> All the best,
>
> Vince
>
>
>
>
> ------------------------------------------------------------------------------ 
>
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> FFADO-devel mailing list
> FFA...@li...
> https://lists.sourceforge.net/lists/listinfo/ffado-devel