From: Pieter P. <pi...@jo...> - 2007-08-26 12:24:58
|
Francois.ernoult wrote: > Hi all, > > There are three reasons why ENABLE_BEBOB is not working: > > 1) bridgeco-downloader and bebob-sync should not be built by scons. true. > > 2) Some '#ifdef ENABLE_BEBOB' are missing in test-debugmodule, test-dll, > test-unittests-util and test-unittests-osc. I'll do a patch for that. All of these shouldn't have a dependency on BeBoB since they are tests for the generic infrastructure. Probably somewhere there's a stale reference to something bebob related. > > 3) A merge side effect: 'src/bebob/bebob_functionblock.h' is included into > 'src/libavc/audiosubmit/avc_audiosubmit.cpp' and > 'src/libavc/audiosubmit/avc_audiosubmit.h'. > In this included file, two functions are declared: serialize(...) and > deserialize(...), but they are unavailable when ENANBLE_BEBOB=no. > The question is: do we put declarations between '#ifdef ENABLE_BEBOB' and > #endif, or do we compile the code of those two functions even when if > ENABLE_BEBOB=no? > In short, are serialize(...) and deserialize(...) needed by > 'src/libavc/audiosubmit/avc_audiosubmit.cpp'? The code dealing with function blocks is not yet finished. Normally it should be split into a generic 1394TA compliant part and a BeBoB specific part. However currently this is not ready yet since it involves a rather elaborate rewrite. I'm working on this but I can't say when it's going to be finished. Greets, Pieter |