feedreader-development — Feedreader development list

[Feedreader-development] Menu in Feedreader?

[Toomas T. <to...@i-...>]

What community thinks. Is there a need for menu in Feedreader? There are 
already a lot of possible buttons, that do not need to be in toolbar:

About
Properties
News Overview (this is Marcus'es secret weapon ;)), press F7 in last 
release.
More to come...

If all these are on toolbar, then toolbar looks quite unclean.


Greetings
Toomas

RE: [Feedreader-development] Two problems with Feedreader.

[Kristjan J. <kri...@sl...>]

> 1. If feed has no dc:date field, then datetime is generated by=20
> feedreader and it will be current datetime. Problem is, that=20
> if there is=20
> 10 new headlines for example, then they all get the same=20
> datetime value=20
> and if they are displayed in listview, then sort order is=20
> quite weird.=20

They display on a reverse order, you mean? Or totally mixed up?

Kristjan

[Feedreader-development] Two problems with Feedreader.

[Toomas T. <to...@i-...>]

There are two bugs in Feedreader, that need to be addressed.

1. If feed has no dc:date field, then datetime is generated by 
feedreader and it will be current datetime. Problem is, that if there is 
10 new headlines for example, then they all get the same datetime value 
and if they are displayed in listview, then sort order is quite weird. 
It would be nice to have the last headline on the top and so on... I 
currently do no have any ideas, how to fix this. Maybe we should add 
milliseconds to datetime field internally by feedreader? After all this 
date field is interpreted as string in feedreader.

2. There is a problem with ExpandEscapes function what is used by 
html2normal function, for example. If we give html to  html2normal :

---------------Example from www.scripting.com/rss.xml---------------
<a 
href="http://rss.com.com/2100-1025-998465.html?type=pt&part=rss&tag=feed&subj=news">News.Com</a>: 
"The Webby Awards, the Internet community's biggest annual event, has 
become a non-event this year."

------------------------------------------------------------------------

Then function returns incorrect html string (sorry, i cant show it 
here). And then we give this incorrect string to html2text function, 
then this function will not return and procedure will halt...

At the moment i have removed html2normal function from some problematic 
places in function parsehttpstream

It's best, then you subscribe to scrintingnews rss...


Greetings
Toomas

[Feedreader-development] Data structures

[Toomas T. <to...@i-...>]

Hi!

In one email Marcus wrotes:

5. we should change the internal data-handling to use objects and 
collections instead of records and arrays, that makes a lot of things 
easier and
reduces unnecessary copying of data and removes some memory-leaks that 
are present in the code


What can we do with this problem? Is it ig job to change data structures 
to something more normal than records and arrays? At the moment, i 
think, is quite uneconomical to load xml data to array first and then 
from array to treeview data records.



Greetings
Toomas

Re: [Feedreader-development] New release?

[Marcus H. <hm...@us...>]

Hi!

I've used your fixes for a long time and, congratulations
they work.

I've a small additional change.
Some feeds are composed of multiple source feeds into a single
feed. These feeds also provide the origin of the headline.
I've added support for this in the form of a small header that
is displayed for every headline.
I'll check this in and make a build. 

If I hear no further comments I'll make a new release at 16:00 GMT+1.

Greetings
  Marcus

----- Original Message ----- 
From: "Toomas Toots" <to...@i-...>
To: "Feedreader Development" <fee...@li...>
Sent: Thursday, April 24, 2003 12:52 PM
Subject: [Feedreader-development] New release?


> Hi!
> 
> I have made some (a lot of?) changes to feedreader. You can get it from 
> CVS. Is it time to release new build? Please test it and comment it.
> 
> I do not know, how to release new builds in sourceforge. Can Marcus, the 
> Buildmaster, do it? ;)
> 
> 
> Greetings
> Toomas
> 
> 
> 
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Feedreader-development mailing list
> Fee...@li...
> https://lists.sourceforge.net/lists/listinfo/feedreader-development

[Feedreader-development] New release?

[Toomas T. <to...@i-...>]

Hi!

I have made some (a lot of?) changes to feedreader. You can get it from 
CVS. Is it time to release new build? Please test it and comment it.

I do not know, how to release new builds in sourceforge. Can Marcus, the 
Buildmaster, do it? ;)


Greetings
Toomas

[Feedreader-development] FR got slashdotted (kinda :)

[Kristjan J. <kri...@sl...>]

Slashdotted in context of RSS and RSS readers, but still a noteworthy =
link:
http://books.slashdot.org/books/03/04/16/1438224.shtml?tid=3D192&tid=3D15=
6

Kristjan

[Feedreader-development] Review of FR user interface 4

[Kristjan J. <kri...@sl...>]

-- Add new feed --

[Cancel] and [Next] button using non-standard placement and naming =
conventions:

- on first page:

       [ Cancel ][ Next ]

- on second page

	[ Previous ][ Finish ]


All standard wizard dialogs (InstallShields etc) use

[ < Back ][ Next > ]	[ Cancel ]

and

[ < Back ][ Finish ]	[ Cancel ]



-- Right pane --

- In rightclick menu there's "Delete current feed". A messagebox =
afterwards asks  "Do you want to delete active feed?"   Is "current" =3D =
"active"? I suggest to use "current" word only.

- when updating feedlist, "New feeds" window is nice, but I cant do =
anything on this window, clicking does not help. May just make make new =
feeds in feedlist _bold_? Or use a "new" icon?



-- About dialog --

- About dialog is too big for such a small application (most of the time =
I keep FR main window small, so About box is larger than Feedreader =
itself :)

- Adding tabs is a neat idea, but I'd get rid of the title graphic =
(until we got a cool image to put there - a la Photoshop logo :)

- Should we stress a GPL licence when we have a special tab for this?

 My concept sketch for About dialog:
 http://www.feedreader.com/node.php?id=3D262



-- Taskbar popup --

- It displays items in reverse ordrer. The correct order should be the =
same as in the item's window (newest in top)



-- Exit dialog --

- "...is closing up" is using too large font. I suggest to use standard =
system font size.



Cheers,

Kristjan

[Feedreader-development] Still problem with two things...

[Toomas T. <to...@i-...>]

If Feedreader is started minimized, then it will not show any newmessage 
windows until you open form first time.

Problem is in procedure:

procedure TFeedThread.OnNewHeadlinesAvailable;
...
For i := 0 To gMyFeedsTreeNode.Count-1 Do Begin
    TmpNode := gMyFeedsTreeNode.Item[i];
    Info := feedinfo( TmpNode.Data );
    If Info = Nil Then Continue;
    If Info.feedid = WorkerThread.CurFeedID Then Begin
      Node := TmpNode;  <-------it will never reach this place, if 
application is started minimized and form is not showed.
      Break;
    End;
  End;
  If Node = Nil Then  <--------------------
    Exit;
...

Every time Node will be nil and procedure will be terminated. If I open 
mainform, then node will not be nil any more and all newmessage windows 
will be showed.

Diference beetween minimized start and normal start:
//////////////////////////////
 if gProperties.StartHidden Or (LowerCase(ParamStr(1)) = 'min') or 
(LowerCase(ParamStr(2)) = 'min') then Begin
      Application.ShowMainForm := False;
      Self.windowstate := wsminimized;
      fShowWindowInTaskbar := False;
    End
     Else fShowWindowInTaskbar := True;
 
If fShowWindowInTaskbar Then Begin
    ShowWindow( Application.Handle, SW_SHOWNORMAL );
    Application.ShowMainForm := True;
  End;


//////////////////////////////////////
Second problem is about animated tray icon. It acts kind of funny. Try 
to test it with "enable animated trayicon" setting allowed. It will go 
red even if there is no new messages if some items are unread.

////////////////////////////////////////////////////////////////////////////////////////////
Some problems here....
Procedure TMainWindow.AnimateTrayIcon( Enable: Boolean );
Begin
  If Enable Then Begin
    If gProperties.EnableTaskbarAnimations Then Begin
      If Not CoolTrayIcon1.CycleIcons Then Begin
        CoolTrayIcon1.IconList := TrayIconAnimatedImageList;
        CoolTrayIcon1.CycleIcons := True;
      End;
    End
     Else Enable := False;
  End;


  If Not Enable Then Begin
    CoolTrayIcon1.CycleIcons := False;
    CoolTrayIcon1.IconList := TrayIconStaticImageList;
    If gfUnseenNewsAvailable Then
      CoolTrayIcon1.IconIndex := 1
     Else
      CoolTrayIcon1.IconIndex := 0;
  End;
End;



I'm trying to fix them but if anybody sees problem right now, replay 
please...

[Feedreader-development] Review of FR user interface 3

[Kristjan J. <kri...@sl...>]

Some final remarks:

--- Seach headlines ---

- Search dialog should be moved from the left pane to the top-right =
pane. This gives an user better visual tie between the search form and =
the results.
- "Cancel" button is uneccesary
- It also allows to add "Advanced search options" pane in later phase of =
delopment.

An example:
http://www.feedreader.com/node.php?id=3D261
(My mockup could be a little bit cramped space-wise. Also, search field =
might be a bit longer)

I also updated the "Subscribe" mock-up to be consistent with search =
dialog:
http://www.feedreader.com/node.php?id=3D260


Kristjan

[Feedreader-development] Review of FR user interface 2

[Kristjan J. <kri...@sl...>]

> Btw, no second page of wizard ("Please enter the name of the=20
> feed") the [XML] icon is mysteriously gone already :)

Should be read "Btw, on second page of wizard..."=20


> - Ideally these fields should be on the second step of=20
> wizard, but I understand this is not possible to implement -=20
> FR must connect and validate feed (using loging/password info=20
> if neccessary) before moving from step 1 to step 2, right?

I'd still like to see username/password on step 2:

- On step 1 FR tries to connect as usual
- when returning a HTTP 403 (or 401?), it creates a extra a step 1A, =
asking
for username/password - "This feed requires valid username and =
password"...
- When these provided, FR continues to usual step 2


> I suggest to introduce a narrow information bar above the=20
> headline pane, with a text like "You can subscribe this feed=20
> by clicking here: [subscribe]". The bar should appear just=20
> like "Search" pane, sliding from the top. =20

I made a quick mockup:
http://www.feedreader.com/node.php?id=3D260

Anybody has better ideas?


> In next step we can start discussing better=20
> structure/arrangement of the properties.

Here's my initial suggestion.

I kept all the options the same, just moved them around to
be more logical and consistent.=20

On the left is the tree hierarchy, on the right are properties.=20
I comment each section separately.

_____________________________________

Startup	[] Run program on startup
		[] Start minimized to tray
		[] Check msgs on startup

- What are "msgs"? Are we using such a term=20
elsewhere? Are we "checking" or "updating"?=20
Should be replaced with "Update feeds on startup"
_____________________________________

Appearance	[] Show time
		[] Show date
		[] Show headlines with topics
		[] Show all article tags
		[] Show newsfeed images if available

		[] Show tree lines=20
		[] Show Feed-Hints
	=09
		Font:
		[Select font]

		[] Open links in new browser window

- This is the longest properties page,
preferrably should be grouped into smaller sets.
I separated different functional groups with an empty line.
- Show time and date *where*?=20
Are these columns in feed item's pane?
- "Feed-Hints" -> "Feed hints"=20
- What are "tree lines" and "Feed-Hints" anyway?
_____________________________________

Notification	[] Show pop-up-window in taskbar
box			Visibility duration (sec) [   |v]
			[] Use notification box fade in and out
			[] Enable taskbar animations

- Is it "notification box" or "pop-up-window"? I prefer
the former. Unify.
- I am not sure about the "taskbar animations" option belonging here.=20
Whereelse?

_____________________________________

Connection	[] Use proxy server
		Address  : _____  Port : ___
		Username : _____ =20
		[Get settings from the Internet Explorer]
		[x] Get proxy settings from IE on startup

- Button should be read:
"Get proxy settings from the Internet Explorer"
- I need some kind of feedback message when my=20
IE proxy settings are *not* set. Currently I click=20
on the button and nothing happens. I is leaving me
clueless.=20
_____________________________________

Webserver 	[] Enable local Userland-Sever
		[] Enable local AmphetaDesk-webserver
		[] Enable internal WebServer=20
		Port : ___

- A explaing message what the webserver is good for
would be a godsend.
- Note different naming conventions for words "local/internal"=20
and "WebServer". Must be unified.
_____________________________________

???			Feed defaults
			Refresh: _____
			Archive:_____=20

			[] Play sounds
			[] Show XMLParser errors
			[] Enable javascript

- This section can also be called: "Leftovers" or=20
"I Dont Have an Idea Where to Put Those" :)
- What sounds? When? On incoming messages? Explain!
- "XMLParser" -> "XML parser"
- "javascript" -> "Javascript"
_____________________________________





One more general note: there is no consistent=20
spacing conventions on dialogs. Sometimes FR uses

 Refresh : [    |v]

and sometimes

 Refresh: [    |v]

(note the missing space)


Kristjan

[Feedreader-development] Review of FR user interface

[Kristjan J. <kri...@sl...>]

MAIN WINDOW=20

--- "New..." button ---

1) Maybe it's just me, but I feel most applications have "New" button =
left side of the toolbar. To be consistent I'd suggest to swap the "New" =
and "Update" buttons. Up for discussion.

2) "New..." button dropdown menu is compete mess.=20

- What on earth is "External" and "Local" feeds? Ok, I know, I chatted =
with Toomas and "Local" feeds seems to be a work-in-progress to create =
outcoming (exportable) feeds. Can I use such a functionality? No, at =
least not at a first glance - the internal feed stays empty, I'm not =
explained how to create new items there.

Solution: Remove the "Local" menu opion until the actual functionality =
is there. Just keep two options "New feed" and "New folder".

- Why the "New..." menu is auto-hiding? =
http://www.feedreader.com/node.php?id=3D259 (like Word and other =
Microsoft applications, where not-so-often-used menu options are hidden =
from users). C'mon - there's only 3 options, auto-hiding them is really =
annoying.

- Will "Add new feedlist" be back in the menu?=20


--- Seach headlines ---

Dialog color scheme is weird. Shouldn't the text entry field be white =
(not gray) to be consistent with the rest of the application?


--- Feedlist (the leftmost pane) ---

1) The rightbutton menu usage should be reconsidered:

- Why there's no rightbutton menu on "My feeds"?=20
- Why folder-creating is available under the toolbar, not in the =
feedlist itself (like standard Windows explorer tree)?
- Why I can't add or delete feedlists?

2) The name "Estonians channels" are misleading. Are we using the term =
"channel" elsewhere? No? Be consistent, use the term "feed" thoroughly.=20
Solution: rename it to "Estonian feeds"=20

3) Favourites.
Ok, I see these are my IE favourites, but what the hell they are doing =
here, in Feedreader?=20


-- Feed items (the upper-right pane) ---

"Date" and "Headline" column headers are clickable, but clicking on them =
does nothing. I'd expect clicking will change the ordering and sorting =
of items (like Outlook).
Solutions:
- allow ordering and sorting
- alternatively, just remove clickability


--- Statusbar ---

Why there's two progressbars, one continious, one stepped? Can't we =
settle with one?


DIALOGS

--- Add new feed ---

1) There's currently two titles on the dialog:
"New feed wizard" +
"[XML] Adding new feed"

IHMO such a duplication is unneccessary. We do not have to emphasize =
that we are using "wizard" here.=20
Solution:
- Just use a string "Add new feed" in titlebar, remove the second =
"Adding new feed" line.=20
- Also remove XML icon, it's usage here is incorrect. We need a proper =
icon/graphic here.=20
Btw, no second page of wizard ("Please enter the name of the feed") the =
[XML] icon is mysteriously gone already :)


2) "Username" and "Password" are too intrusive in first step of the =
wizard. They seem to FORCE user to fill these fields - there's no =
information are these fields optional or not (In fact, the whole dialog =
looks like a standard login box, more or less).

Solutions:
- Write short explanation what these fields are and stress that they are =
OPTIONAL.=20
- One should also consider to make the dialog expand/collapse in the =
bottom (like the Windows login box) - something like "v Advanced =
options". When expanded, power user can specify login/password, when =
collapsed, novice user just won't see the fields.=20
- Ideally these fields should be on the second step of wizard, but I =
understand this is not possible to implement - FR must connect and =
validate feed (using loging/password info if neccessary) before moving =
from step 1 to step 2, right?


3) Change "Next" to "Next >" and "Previous" to "< Previous"

See also http://ranchero.com/images/nnw/subscribe1.jpg
and http://www.feedreader.com/node.php?id=3D253


--- Subscribe from "Available feeds" ---

The "Subscribe" button what appears on toolbar is almost unnoticable for =
user.=20

I suggest to introduce a narrow information bar above the headline pane, =
with a text like "You can subscribe this feed by clicking here: =
[subscribe]". The bar should appear just like "Search" pane, sliding =
from the top. =20


--- Feed properties ---

- Once again, I am against the [XML] image. Yep, I know the dialog badly =
lacks color, but the [XML] is meant to be the link, and should have a =
tooltip when hovering above the icon. Using it here as a static =
illustation is misguiding.
Solution: create a new fancy icon :)

- Again, IHMO "Username" and "Password" should not be emphasized - they =
should be moved to the bottom, separated with a horizontal line (with a =
be a short explaination?)

- BTW, you can put these fields on a same line:
Username: [          ] Password: [          ]

- "Directly show headline link" Whatthehellizit? I'm clueless.

- "Archive" and "Refresh feed" show "Default" as a standard option. Why =
not display the *actual default value* instead?=20
If one really wants to stress that we are dealing with defaults (why?), =
he could write "50 headlines - default" or similar.
When I am new to FR, I might not even touched the global properties and =
never changed defaults, so I never know what the actual value is.

- Left side of the "Refresh feed" field must be aligned with other =
fields, right now it is shorter than others.



--- (Global) Properties ---

There's currently two methods of sturcturing - tabs and checkbox-list. =
Why not settle for classic tree+properties pane, like IE, Mozilla and =
numerious other applications?
See NewzCrawler preferences windows: =
http://www.feedreader.com/module.php?mod=3Dimage&uid=3D2  (of course it =
is bloated, using too much structuring, but you will get the idea)
Such way options can still be nested/structured, but properties dialog =
itself is far more logical and familiar to user.=20

Current checkbox-list does not provide enough flexibility. What if I =
want to add a different kind of field to "General > Misc > Play sounds", =
say a button "Select a sound sample"?

I'd start with following:

- replace current checbox-list component with standard tree+properties =
component
- create properties pages for "Startup" and "Miscallenous" (not "Misc"! =
-=20
  do not use abbreviations)
- merge the "Appearance" checbox-list and "Appearance" tab into a single =
"Appearance" properties page.
- move "Connection", and "Webserver" properties under the general tree, =
get rid of tabs.

In next step we can start discussing better structure/arrangement of the =
properties.



-- About Feedreader --

- "Version" and "Build" number fields look like a text-entry fields. =
Can't they be outputted as a plain text, not as a form control?

- Check for new version work ok, but leaves the user clueless. Right, =
new version is avaliable...now what? The dialog should give me some =
clues how to proceed, at least provide a link to www.feedreader.com page =
(even better, a downloads page)



More to come :)

Regards,

Kristjan

Re: [Feedreader-development] Some problems, then testing CVS version

[Marcus H. <hm...@us...>]

I haven't yet noticed any problems with starting the app minimized.
But I've found and fixed a problem with the periodic refresh.
If you at least once refresh a feed manually the automatic update
of all feeds is stopped forever.

I'll upload the fixes today, after some additional testing.

Greetings
  Marcus

----- Original Message -----
From: "Toomas Toots" <to...@i-...>
To: "Feedreader Development" <fee...@li...>
Sent: Monday, March 31, 2003 12:37 PM
Subject: [Feedreader-development] Some problems, then testing CVS version


> I have found two problems, then using CVS version of Feedreader.
>
> 1. If Feedreader starts minimized to tray, then it will not show any
> "new item notification", until i open it from tray. And if i'm not
> opening it from tray, Feedreader can run whole day and not perform any
> updates.
>
> 2. Feedreader somehow forgets to update subscribed feeds. It does not
> happen very often, but for example once in a day. I think it's because
> of some incorrect feed but it should not stop updating because of
> incorrect feeds.
>
>
> I will dig into code myself and try to fix these bugs but if someone
> (Marcus? ;)) knows about these bugs, he can gove me some hints or fix
this.
>
>
> Greetings
> Toomas
>

[Feedreader-development] Some problems, then testing CVS version

[Toomas T. <to...@i-...>]

I have found two problems, then using CVS version of Feedreader.

1. If Feedreader starts minimized to tray, then it will not show any 
"new item notification", until i open it from tray. And if i'm not 
opening it from tray, Feedreader can run whole day and not perform any 
updates.

2. Feedreader somehow forgets to update subscribed feeds. It does not 
happen very often, but for example once in a day. I think it's because 
of some incorrect feed but it should not stop updating because of 
incorrect feeds.


I will dig into code myself and try to fix these bugs but if someone 
(Marcus? ;)) knows about these bugs, he can gove me some hints or fix this.


Greetings
Toomas

[Feedreader-development] WM_QUERYENDSESSION not saving toolbar settings

[Miha R. <pb...@mi...>]

Comment on build 599:

Toolbar settings are not saved when app receives WM_QUERYENDSESSION message.
Line

  actionmanager1.SaveToFile( gProperties.DataDirectory +
'\Toolbarsettings.bin');

should be moved from TMainWindow.FormClose to
TMainWindow.PrepareAppTermination procedure.

Also, TMainWindow.FormClose contains some other assignment statements that
probably should be moved to TMainWindow.PrepareAppTermination procedure.

--
Miha Remec

Re: [Feedreader-development] New Release?

[Kyle C. <ky...@ky...>]

From: "Toomas Toots" <to...@i-...>


> And what about bugs that Kyle wrote about:
>
> 1) Feedreader sometimes write invalid XML to one of its data files
>
> 2) when reading the file back in, it fail to parse, then fail silently
with
> no error message, yet lose the "read / not read" status of every item in
> every feed.  (Code which fails silently in there is an error, is an
> extremely bad idea, by the way.)


I will hopefully find time soon to send an example of a feed that triggers
this problem.  However, the very existance of code that will fail silently,
is a large problem.  That code needs to fixed, regardless of what specific
example makes it happen.

Kyle

[Feedreader-development] Sourceforge RSS support

[Toomas T. <to...@i-...>]

I guess, it's quite new thing. Take a look at

http://sourceforge.net/export/rss2_project.php?group_id=70179

Maybe we should add some of these feeds (at least "project file 
releases") to Feedreader "My feeds" section, then user installs it. So 
users can get notified about new releases of Feedreader.


Greetings
Toomas

Re: [Feedreader-development] New Release?

[Marcus H. <hm...@us...>]

Currently I can't reproduce the problems Kyle described.
I'd like to fix it but I've no idea where it could happen.
As I said I don't have the problem.
  Toomas ::


  I have compiled and tested CVS version. Before new release i'd like to =
commit some features i wrote about in previous email. I guess I can do =
it today.=20

  I think that there is some little problem with automatic updating =
engine. I notice that if i let FR to run for example one day it can stop =
updating feeds automatically. Only program restart helps. Even if I push =
update button, it does not trigger update.

  And what about bugs that Kyle wrote about:


1) Feedreader sometimes write invalid XML to one of its data files

2) when reading the file back in, it fail to parse, then fail silently =
with
no error message, yet lose the "read / not read" status of every item in
every feed.  (Code which fails silently in there is an error, is an
extremely bad idea, by the way.)

  Greetings
  Toomas


  Marcus Hettlage ::

    What about a new release?
    I think it's time for it. I've fixed some
    bugs and we've got new features that
    users requested.
    Has someone tested the current source-version,
    except myself?

    Greetings
      Marcus

Re: [Feedreader-development] New Release?

[Marcus H. <hm...@us...>]

Ok, both comments are reflected in the code.

> Comments about build 594:
>
> 1) There's still a bug related to http proxy settings in
> AddOptionsDialog_FRM.pas, line 393:
>
>   If gProperties.ProxyEnabled Then
>     if gProperties.ProxyPassword = '' then
>       if gProperties.ProxyUsername <> '' Then
>         gProperties.ProxyPassword := InputBox( TranslateString('Enter
proxy
> server password'), TranslateString('for user') + ' ' +
> gProperties.ProxyUsername, '');
>
>   gProperties.ProxyEnabled := enableproxy.checked;
>   gProperties.ProxyHost := proxyhost.text;
>   gProperties.ProxyPort := proxyport.text;
>   gProperties.ProxyUsername := proxyusername.text;
>
> As you can see, password dialog window will open even when enableproxy
> checkbox will not be checked because gProperties.ProxyEnabled are checked
> first. You should put those four assignment statement before checking for
> password prompt.
>
> 2) I prefer that minimizing window would not occur on close event
> (MainForm_FRM.pas, TMainWindow.FormCloseQuery). IMO, it is necessary to
> minimize main window before program closing program.
>
> Here's a patch that will not minimize window if program is closing.
>
> Index: MainForm_FRM.pas
> ===================================================================
> RCS file: /cvsroot/feedreader/feedreader/MainForm_FRM.pas,v
> retrieving revision 1.17
> diff -r1.17 MainForm_FRM.pas
> 841c841
> <   if not fProgrammaticApplicationClose then
> ---
> >   if not fProgrammaticApplicationClose then begin
> 843c843,844
> <   application.minimize;
> ---
> >     application.minimize;
> >   end;
>
> or, if you prefer whole code:
>
> procedure TMainWindow.FormCloseQuery(Sender: TObject; var CanClose:
> Boolean);
> begin
>   if not fProgrammaticApplicationClose then begin
>     canclose := false;
>     application.minimize;
>   end;
> end;
>
>
> --
> Miha Remec
>
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by:Crypto Challenge is now open!
> Get cracking and register here for some mind boggling fun and
> the chance of winning an Apple iPod:
> http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en
> _______________________________________________
> Feedreader-development mailing list
> Fee...@li...
> https://lists.sourceforge.net/lists/listinfo/feedreader-development

Re: [Feedreader-development] New Release?

[Toomas T. <to...@i-...>]

I have compiled and tested CVS version. Before new release i'd like to 
commit some features i wrote about in previous email. I guess I can do 
it today.

I think that there is some little problem with automatic updating 
engine. I notice that if i let FR to run for example one day it can stop 
updating feeds automatically. Only program restart helps. Even if I push 
update button, it does not trigger update.

And what about bugs that Kyle wrote about:

1) Feedreader sometimes write invalid XML to one of its data files

2) when reading the file back in, it fail to parse, then fail silently with
no error message, yet lose the "read / not read" status of every item in
every feed.  (Code which fails silently in there is an error, is an
extremely bad idea, by the way.)


Greetings
Toomas


Marcus Hettlage ::

> What about a new release?
> I think it's time for it. I've fixed some
> bugs and we've got new features that
> users requested.
> Has someone tested the current source-version,
> except myself?
>  
> Greetings
>   Marcus

RE: [Feedreader-development] New Release?

[Miha R. <pb...@mi...>]

Comments about build 594:

1) There's still a bug related to http proxy settings in
AddOptionsDialog_FRM.pas, line 393:

  If gProperties.ProxyEnabled Then
    if gProperties.ProxyPassword = '' then
      if gProperties.ProxyUsername <> '' Then
        gProperties.ProxyPassword := InputBox( TranslateString('Enter proxy
server password'), TranslateString('for user') + ' ' +
gProperties.ProxyUsername, '');

  gProperties.ProxyEnabled := enableproxy.checked;
  gProperties.ProxyHost := proxyhost.text;
  gProperties.ProxyPort := proxyport.text;
  gProperties.ProxyUsername := proxyusername.text;

As you can see, password dialog window will open even when enableproxy
checkbox will not be checked because gProperties.ProxyEnabled are checked
first. You should put those four assignment statement before checking for
password prompt.

2) I prefer that minimizing window would not occur on close event
(MainForm_FRM.pas, TMainWindow.FormCloseQuery). IMO, it is necessary to
minimize main window before program closing program.

Here's a patch that will not minimize window if program is closing.

Index: MainForm_FRM.pas
===================================================================
RCS file: /cvsroot/feedreader/feedreader/MainForm_FRM.pas,v
retrieving revision 1.17
diff -r1.17 MainForm_FRM.pas
841c841
<   if not fProgrammaticApplicationClose then
---
>   if not fProgrammaticApplicationClose then begin
843c843,844
<   application.minimize;
---
>     application.minimize;
>   end;

or, if you prefer whole code:

procedure TMainWindow.FormCloseQuery(Sender: TObject; var CanClose:
Boolean);
begin
  if not fProgrammaticApplicationClose then begin
    canclose := false;
    application.minimize;
  end;
end;


--
Miha Remec

[Feedreader-development] New Release?

[Marcus H. <hm...@us...>]

What about a new release?
I think it's time for it. I've fixed some
bugs and we've got new features that
users requested.
Has someone tested the current source-version,
except myself?

Greetings
  Marcus

Re: [Feedreader-development] Some things i'd like to implement

[Kyle C. <ky...@ky...>]

From: "Toomas Toots" <to...@i-...>

> 5. What does community think about last email about integration with
> shell? I could make deskband dll what stays on taskbar (user canselect
> it from "taskbar properties" > "Toolbars" > "Feedreader deskband" for


This is a nice idea, but I very much recommend that all known substantial
bugs should be fixed before substantial new features are added.

One example of a bug is this show-stopper that I reported:

1) Feedreader sometimes write invalid XML to one of its data files

2) when reading the file back in, it fail to parse, then fail silently with
no error message, yet lose the "read / not read" status of every item in
every feed.  (Code which fails silently in there is an error, is an
extremely bad idea, by the way.)

I've tried actually using FeedReader several times, and had to give up after
a few days because of this, every time.  This might be a problem with a
feed, but a requirement of a system like this is that no feed data problem
should every cause the system to lose data.  It must not rely on the feeds
being properly formatted, because that is not the reality of the RSS world.

Has this been fixed in the latest alpha version?  If so I'll give it try and
verify it.

[ Kyle Cordes * ky...@ky... * http://kylecordes.com ]
[ Consulting, Training, and Software development tips and   ]
[ techniques: Java, Delphi, ASTA, BDE Alternatives Guide,   ]
[ JB Open Tools, EJB, Web applications, methodologies, etc. ]

[Feedreader-development] Some things i'd like to implement

[Toomas T. <to...@i-...>]

Hi!

Marcus has done wonders with the source. I'm not absolutely catched up 
because of lack of time but i'd like to implement some changes/new features:

1. Change treeview X icon (icon what apears if feed is not available) to 
something better (globe with little red x in the corner)
2. Unread count. At the moment it is displayd like this

          If TreeView1.ShowLines Then
            cxOffset := 7
           Else
            cxOffset := 6;

At least in windows XP offset must be

          If TreeView1.ShowLines Then
            cxOffset := 9
           Else
            cxOffset := 8;

because it will not that clean if unread count is to close to feed title.

3. What community thinks about adding new item to subscribed feed 
rightclick menu : "View feed source". XML source will be displayed in 
minibrowser.

4. If user clicks on one subscribed feed and tooltips+hints are not 
enabled, feed information should display in minibrowser (at the moment 
minibrowser is empty till you click on some headline).

5. What does community think about last email about integration with 
shell? I could make deskband dll what stays on taskbar (user canselect 
it from "taskbar properties" > "Toolbars" > "Feedreader deskband" for 
example ) and displays popupmenu with subscribed feeds and subitems of 
feeds will be headlines. And there will be button to trigger update. I'm 
not quite finished with my ideas, will think about it more.

All these things i'd like to implement myself if there is no problem :)


Greetings
Toomas

I will do all these things myself....

[Feedreader-development] [Fwd: Love it! :)]

[Toomas T. <to...@i-...>]

Some ideas for future...