#706 games-emulation/fceux-2.2.2 : external qa issue

[Toralf Förster]

Hello,

a Gentoo Linux Quality Assurance issue was reported at my tinderbox [1] while building your software.

Such reported issues are often correct.
Otherwise it would be interesting why the issue is a false positive in your eyes.

[1] http://www.zwiebeltoralf.de/tinderbox/index.html

=============================================================================

WARN: postinst
Remember, in order to play games, you have to
be in the 'games' group.
Just run 'gpasswd -a <USER> games', then have <USER> re-login.
QA: other
QA Notice: Package triggers severe warnings which indicate that it
may exhibit random runtime failures.
src/netplay.cpp:324:30: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
src/ppu.cpp:1368:31: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
src/ppu.cpp:1425:31: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
src/utils/memory.h:25:81: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
src/boards/../utils/memory.h:25:81: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
src/boards/onebus.cpp:284:29: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
src/boards/onebus.cpp:285:26: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
Please do not file a Gentoo bug and instead report the above QA
issues directly to the upstream developers of this software.
Homepage: http://fceux.com/

[zeromus]

The issues are correct. the code breaks strict-aliasing rules. Since some compilers will enable strict aliasing optimizations at -O2 and above, this they could generate buggy code. The results of this are dire: a video game behaves unpredictable.

We should solve this by adding -fno-strict-aliasing to the commandline.

[Lukas Sabota]

Added -fno-strict-aliasing as a default ccflag in r3138.