Menu

#705 SDL: fullscreen aspect ratio correction

SDL
open
1
2016-10-10
2015-07-01
Eugene
No

Hi, since there is no aspect ratio checkbox on SDL version, i've set custom 5:4 or 4:3 scalers for more TV-like aspect.
But it works only in window-mode, and aspect broken in fullscreen.
Here is screenshots attached.

2 Attachments

Discussion

  • Eugene

    Eugene - 2015-09-20

    Sorry, Lukas.
    It's hard to add?

     
  • Lukas Sabota

    Lukas Sabota - 2015-09-20

    Hi,

    It's not the the fact that its too hard to add but I haven't had time to really look into it - fullscreen mode in the sdl port is very poor in my opinion. To work around this I generally run in windowed mode (with a borderless window) with scaling set to fill the screen. I want to revisit fullscreen mode entirely when fceux is ported to sdl2

    I would like in to this but it's just a matter of time

     

    Last edit: Lukas Sabota 2015-09-20
  • Eugene

    Eugene - 2015-09-24
     

    Last edit: Eugene 2015-12-27
  • Eugene

    Eugene - 2015-12-27

    since there is no aspect ratio checkbox on SDL version, i've set custom scalers for more TV-like aspect.

    Hi, Lukas. Here is a patch (made by Feos) that adds TV-aspect proportion to SDL (OpenGL mode).
    It works pretty well, but some logic is hardcoded.
    Can you rewrite this patch "right way" and add "TV-aspect" checkbox into patch logic?

     

    Last edit: Eugene 2015-12-27
    • Lukas Sabota

      Lukas Sabota - 2015-12-29

      This breaks autoscale for me. I have a patch ready to make tvaspect value configurable, but the initial patch breaks autoscale

      Can't post to tracker, bug tracker is broken on mobile

      On December 27, 2015 6:34:05 AM EST, Eugene emu-russia@users.sf.net wrote:

      Hi, Lukas. Here is a patch (made by Feos) that add TV-aspect proportion
      to SDL (OpenGL mode).
      It works pretty well, but we need you help for GUI.
      Can you add "TV-aspect" checkbox and tie this into patch logic?


      [bugs:#705] SDL: fullscreen aspect ratio correction

      Status: open
      Group: SDL
      Labels: aspect ratio
      Created: Wed Jul 01, 2015 06:10 PM UTC by Eugene
      Last Updated: Thu Sep 24, 2015 06:02 PM UTC
      Owner: Lukas Sabota
      Attachments:

      -
      fullscreen.png
      (41.1 kB; image/png)
      -
      window.png
      (442.1 kB; image/png)

      Hi, since there is no aspect ratio checkbox on SDL version, i've set
      custom 5:4 or 4:3 scalers for more TV-like aspect.
      But it works only in window-mode, and aspect broken in fullscreen.
      Here is screenshots attached.


      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/fceultra/bugs/705/

      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/

      --
      Sent from my Android device with K-9 Mail. Please excuse my brevity.

       
  • buhtz

    buhtz - 2016-10-09

    What is the current status here?

     
  • Lukas Sabota

    Lukas Sabota - 2016-10-10

    Eugene's patch breaks autoscale in SDL so it has not been applied - I'd like to rework it at some point but I have no idea when I'll have the free time to look into it

     
  • buhtz

    buhtz - 2016-10-10

    Thanks for explanation.

     

Log in to post a comment.