Menu
▾
▴
#51 Cstat gumps fix in SI, implemented in BG. Tombstone fix.
* Sign_gump.cc: fixed bug where tombstones displayed the wooden sign font
* NewCombatGumps.shp: adds frames for party members 7-9 in with only the
avatar having a magic section and new frames that include a magic section
for members 2-9.
* CombatStats_gump.cc, Gump_manager.cc, misc_buttons.cc, cheat.*,
cheat_screen.cc, keyactions.*, keys.cc, bggame.cc, sigame.cc, Actor_gump.*,
Paperdoll_gump.cc: Fixed bug from having more than 6 party members in SI.
Also added gump Cstat gump support in BG. New cheat menu command and key
bindable command ("NEW_CSTATS_GUMP") added to toggle it. Removed restriction
on "COMBAT_STATS" keybinding and made sure that it would only open one Cstat
gump at a time.
Well, to sum it up, basically there were things still left to be done to save you guys time in implementing it. I send the files to the files to the patch section in since you had problems downloading from that site (even though you act like you have access to the files).
I didn't test it on the current cvs and with the two files updated for it. I was trying to get advice on how to use a shape or vga file from a flx so that I could get information that would make it possible to finish it and help with possible future patches I might work on. "If" statements can use some cleaning up, but I was initially going to wait until I got links to the file inside the flx working.
Logged In: YES
user_id=1789700
Originator: YES
File Added: CombatStats_gump.zip
Logged In: YES
user_id=1789700
Originator: YES
Cleaned up 'if' statements and only show magic stats if (magic != 0) to remove clutter.
File Added: Exult.7z
Exult patch source
Logged In: YES
user_id=1789700
Originator: YES
I just noticed that the combat button in BG when not using paperdolls has been overlapping the halo button for years and I accidentally included two different cvs versions of Paperdoll_gump.cc in the 7z. The one in the Exult folder is the correct one.
File Added: Actor_gump.zip
Updated file
Logged In: YES
user_id=1203053
Originator: NO
One thing I noticed also was that the dove/sword button does not have a transparent background in BG, hence the paperdoll gump is partially obscured; this one has a simple fix, though (I will hold off the fix for now because I will improve and extend it to import the combat stats button and other combat-stat-gump-related shapes).
I have been taking a look at the code, and I am thinking of having a more dynamical approach: instead of having one complete gump for each number of NPCs, have a base gump for only the avatar in party and a pair of character strips (magic/no magic). Exult could then compose the complete gump from these elements.
Logged In: NO
I wasn't sure about loading the SI combat button when moving it worked, but then I realized after reading your post that it happens with the SI Paperdoll in BG. I would say, keep the move for the BG style one and have it also import the button from SI if it is installed. SI style gumps only work if you have SI installed anyway, so you importing the button for it doesn't require an additional check.
I was thinking about something like that with the cstats gump, but I thought having gaps in between might look a bit weird. It's your call of course.
different version with tons of changes and SI paperdoll support
I fixed the crash with SI style paperdolls I reported earlier.
gamemap.cc,jawbone_gump.cc, jawbone.cc: added support for jawbone (shape 1500 in BG, 555 in Dev), dehardcoded Serpent tooth
bggame.cc added support for magic scroll, jawbone, tooth, tree gump, cstat gumps for BG
keyactions.*, cheat.*, actors.cc,
support paperdoll without SI installed (currently paperdol shape 123 is hardcoded as the background gump),
actors.cc, swamp boot support for dev (shape 588),
fixed spell book not displaying text for first circle
added support for second cstats gumps type that shows magic stats for all party members and cstat botton working for them, menu and key cheat for magic cstat gump,
current bugs:
ES has paperdol.txt outputted as SI instead of BG (probably not really be a bug, but it needs changed so that both types of gumpscan be used).
paperdol.txt info is used for item placement even with BG Style paperdolls (might be because it thinks it is SI?.
Gloves don't fit in dev games with bg style paperdolls (probably due to previous).
(So far, everything else I've added seems to be working fine.)
File Added: September_18.zip
> paperdol.txt info is used for item placement even with BG Style paperdolls
That actually happened (in a way) even before there was a paperdol.txt.
>Gloves don't fit in dev games with bg style paperdolls
It may well be because Actor::get_preferred_slots does not have a case for dev games.
These (and the other one) should be independently submitted as bug reports.
Also, the de-hard-codings should also be a separate item in the patch tracker.
Magic gumps diff
I've included the diffs without the other changes. Sorry, I think I sounded rude earlier in IRC. I'll add another patch tracker item for the other changes later. No need include graphics since this uses xml.
BG can only use cstats key to open the gump since no cstats button is implemented. I think I'll add it in the dehardcode patch and just use the xml to enable it if cstats_button != 0xfff. Then switch combat mode button with cstats button and take away the halo.
I replaced -1 with 0xfff for my unused xml items since it had problems (made gumps labeled as such = 0 and objects could be recognized as flats). Hopefully this isn't converted by the engine and causing problems.
File Added: Magic_gump_Diff.zip
I got rid of the cheat menu and made it so that the magic gump would show up if it was setup. The cstat button will show up on the paperdol if the cstat_button and cstat/1 are setup. I included actual diff files this time (saved wrong). This should be everything.
File Added: Magic_gump_Diff_fixed.zip