[eXist-commits] [eXist-db/exist] a5390b: [bugfix] Fix #6618: tolerate ambiguous URI segment...

[Lars W. <no...@gi...>]

  Branch: refs/heads/develop
  Home:   https://github.com/eXist-db/exist
  Commit: a5390b1ed03d4d2216be8bbaf7ad7691b523c270
      https://github.com/eXist-db/exist/commit/a5390b1ed03d4d2216be8bbaf7ad7691b523c270
  Author: Juri Leino <gi...@li...>
  Date:   2026-08-18 (Tue, 18 Aug 2026)

  Changed paths:
    M exist-core/src/main/java/org/exist/http/urlrewrite/XQueryURLRewrite.java
    M exist-core/src/test/java/org/exist/http/urlrewrite/XQueryURLRewriteTest.java

  Log Message:
  -----------
  [bugfix] Fix #6618: tolerate ambiguous URI segments in getServletPath()

Under Jetty 12's EE10 servlet module, getServletPath() throws
IllegalArgumentException (surfaced as a 400) for request URIs with an
ambiguous path segment, even though getRequestURI() on the same
request stays safe. XQueryURLRewrite is always mapped with url-pattern
"/*", so per the servlet spec getServletPath() is defined to return ""
here regardless of the URI -- fall back to that known value instead of
failing the whole request.

Closes https://github.com/eXist-db/exist/issues/6618

Co-Authored-By: Claude Sonnet 5 <no...@an...>
Claude-Session: https://claude.ai/code/session_01FXDbP2prLkesWq1JYjgHzb


  Commit: 0df3f1dde545c91aa5c2a606000b2bd71fd674b4
      https://github.com/eXist-db/exist/commit/0df3f1dde545c91aa5c2a606000b2bd71fd674b4
  Author: Juri Leino <gi...@li...>
  Date:   2026-08-18 (Tue, 18 Aug 2026)

  Changed paths:
    M exist-core/src/test/java/org/exist/http/urlrewrite/XQueryURLRewriteTest.java

  Log Message:
  -----------
  [test] Rename test methods to satisfy JUnit naming convention

Codacy flagged 'getServletPathSafely_returnsServletPath' and
'getServletPathSafely_toleratesAmbiguousUriException' for not matching
the JUnit 4 method-name pattern [a-z][a-zA-Z0-9]* (no underscores).
Rename to camelCase.

Co-Authored-By: Claude Sonnet 5 <no...@an...>
Claude-Session: https://claude.ai/code/session_01FXDbP2prLkesWq1JYjgHzb


  Commit: cc597c3fe4a66b7eb75ab73eb4d7f6ecd116e67f
      https://github.com/eXist-db/exist/commit/cc597c3fe4a66b7eb75ab73eb4d7f6ecd116e67f
  Author: Lars Windauer <la...@ex...>
  Date:   2026-08-18 (Tue, 18 Aug 2026)

  Changed paths:
    M exist-core/src/main/java/org/exist/http/urlrewrite/XQueryURLRewrite.java
    M exist-core/src/test/java/org/exist/http/urlrewrite/XQueryURLRewriteTest.java

  Log Message:
  -----------
  Merge pull request #6622 from line-o/fix/6618-ambiguous-uri-servletpath

[bugfix] Tolerate ambiguous URI segments in getServletPath()


Compare: https://github.com/eXist-db/exist/compare/ba48b8de36bc...cc597c3fe4a6

To unsubscribe from these emails, change your notification settings at https://github.com/eXist-db/exist/settings/notifications