[eXist-commits] [eXist-db/exist] f5673f: [bugfix] http-client: parse a non-well-formed HTML...

[Dannes W. <no...@gi...>]

  Branch: refs/heads/develop
  Home:   https://github.com/eXist-db/exist
  Commit: f5673f7a4da2b46ab8119f318de3832bdfece79d
      https://github.com/eXist-db/exist/commit/f5673f7a4da2b46ab8119f318de3832bdfece79d
  Author: Joe Wicentowski <jo...@gm...>
  Date:   2026-07-16 (Thu, 16 Jul 2026)

  Changed paths:
    M extensions/modules/http-client/src/main/java/org/exist/xquery/modules/httpclient/ResponseHandler.java
    M extensions/modules/http-client/src/test/java/org/exist/xquery/modules/httpclient/SendRequestFunctionTest.java
    M extensions/modules/http-client/src/test/resources/conf.xml

  Log Message:
  -----------
  [bugfix] http-client: parse a non-well-formed HTML response to a document

A text/html response was XML-parsed and, on failure, returned as a raw string, so
non-well-formed HTML (the common case) was no longer a navigable document.
ResponseHandler now falls back to eXist's configured HTML-to-XML parser
(NekoHTML, via HtmlToXmlParser -- the same parser util:parse-html uses) to turn
tag-soup HTML into a document node. Well-formed XHTML still parses directly as
XML; if no HTML parser is configured or it cannot parse the input, the body
degrades to a string as before, so the change is strictly additive.

The test conf.xml gains the html-to-xml parser block (matching the default eXist
configuration), and SendRequestFunctionTest gains
malformedHtmlResponseIsParsedToDocument.

Part of https://github.com/eXist-db/exist/issues/6512

Co-Authored-By: Claude Opus 4.8 (1M context) <no...@an...>


  Commit: 690b0f6461bb8a4e3468713bb73def551757ba07
      https://github.com/eXist-db/exist/commit/690b0f6461bb8a4e3468713bb73def551757ba07
  Author: Joe Wicentowski <jo...@gm...>
  Date:   2026-07-16 (Thu, 16 Jul 2026)

  Changed paths:
    M extensions/modules/http-client/pom.xml

  Log Message:
  -----------
  [bugfix] http-client: declare the j8fu dependency used by ResponseHandler

The HTML-response change uses HtmlToXmlParser, whose result is a
com.evolvedbinary.j8fu.Either, so ResponseHandler now references j8fu directly.
It was only available transitively via exist-core, which fails the
maven-dependency-plugin analyze-only check ("used, undeclared dependency").
Declare j8fu at compile scope (version managed by exist-parent), matching how
the file/mail/exi modules already declare it.

Co-Authored-By: Claude Opus 4.8 (1M context) <no...@an...>


  Commit: 978e8aea8a8532d6d9442d70d886f20a7a9c1ea1
      https://github.com/eXist-db/exist/commit/978e8aea8a8532d6d9442d70d886f20a7a9c1ea1
  Author: Joe Wicentowski <jo...@gm...>
  Date:   2026-07-16 (Thu, 16 Jul 2026)

  Changed paths:
    M extensions/modules/http-client/src/test/java/org/exist/xquery/modules/httpclient/SendRequestFunctionTest.java

  Log Message:
  -----------
  [test] Address review: convert query string to text block

Per @reinhapa's review of PR #6514: convert the malformedHtmlResponse test's
XQuery string from "\n"-concatenation to a text block with formatted(baseUrl()).

Co-Authored-By: Claude Opus 4.8 (1M context) <no...@an...>


  Commit: ca09d12f4513a5816da83c517f39d62a6483a012
      https://github.com/eXist-db/exist/commit/ca09d12f4513a5816da83c517f39d62a6483a012
  Author: Dannes Wessels <di...@us...>
  Date:   2026-07-18 (Sat, 18 Jul 2026)

  Changed paths:
    M extensions/modules/http-client/pom.xml
    M extensions/modules/http-client/src/main/java/org/exist/xquery/modules/httpclient/ResponseHandler.java
    M extensions/modules/http-client/src/test/java/org/exist/xquery/modules/httpclient/SendRequestFunctionTest.java
    M extensions/modules/http-client/src/test/resources/conf.xml

  Log Message:
  -----------
  Merge pull request #6514 from joewiz/bugfix/http-client-html-response

[bugfix] http-client: parse a non-well-formed HTML response to a document


Compare: https://github.com/eXist-db/exist/compare/c4decaeacf5f...ca09d12f4513

To unsubscribe from these emails, change your notification settings at https://github.com/eXist-db/exist/settings/notifications