[Exist-open] is umask applied correctly?

[Chris T. <chr...@gm...>]

Hello,

I have been looking at trunk rev 17443 and have found what seems an oddity with the way that UMASK is being applied.

I have a build with Permission.DEFAULT_UMASK = 007 rather than 022 so that users and group members would have full Collection and Resource permissions and others would have no permissions.

The Resource permissions that result are 0657 rather than 0660 which I expected.

I think that in places such as PermissionFactory.getDefaultResourcePermission and PermissionFactory.getDefaultCollectionPermission the code should be like:

                   perms & ~ umask

rather than

                   perms - umask

The latter works sometimes but fails in other cases, for example when

                   0666 - 0007 == 0657

but

                   0666 & ~ 0007 == 0660

always works in accordance with my understanding of umask.

Chris