From: Adam R. <ad...@ex...> - 2011-11-10 23:01:26
|
Hi Ralf, I checked your logic and its sound, so Im committed. The way logging is done in that function is hideous, but your fix improves the situation :-) Its in as 15520. Thanks for the prod, sometimes we need a reminder. Thanks Adam. On 10 November 2011 20:46, Ralf Jung <ral...@gm...> wrote: > Hi list, > > some months ago, I reported a crash against exist, which was triggered by > creating a sort index over less than 20 elements: > http://sourceforge.net/tracker/?func=detail&aid=3346850&group_id=17691&atid=117691 > The report also has a patch attached to fix it. However, I got no comment on > whether the patch is correct, or any reason why it was silently > dropped/rejected. I'd appreciate if someone could have a look. > > In the end, it does not matter much for me whether the patch is upstream or > not, I will just continue to use it. But I thought I should try to give > something back - which is quite hard, as it seems. > (And no, this is not a pledge for commit access, it would not help - I'd still > need for someone familiar with the code base to have a look at it) > > Kind regards, > Ralf > > ------------------------------------------------------------------------------ > RSA(R) Conference 2012 > Save $700 by Nov 18 > Register now > http://p.sf.net/sfu/rsa-sfdev2dev1 > _______________________________________________ > Exist-open mailing list > Exi...@li... > https://lists.sourceforge.net/lists/listinfo/exist-open > -- Adam Retter eXist Developer { United Kingdom } ad...@ex... irc://irc.freenode.net/existdb |