Re: [Etherboot-developers] DHCP option Bootfile name and extension path

[Vasil V. <vas...@sy...>]

On Tue, 2 Sep 2003, Ken Yap wrote:

> >I have the following patch for making a solution I needed. It also fixes a
> >small bug. I can commit this to CVS if there are no objections.
>
> I have one question, what happens when option overload (52) is present?
> I suppose that the definition of KERNEL_BUF then fails badly.

Option overload (52) is not currently supported by Etherboot. It can be
trivially supported and I have implemented it. KERNEL_BUF is not a problem
even then within Etherboot. It becomes a problem when the bootp structure is
passed to loaded image, which then may modify it and return to Etherboot to
retry and possibly load a different image. A few images, e.g. the nbi menus,
expect the KERNEL_BUF where it is at the moment, and implementing BOOTP/DHCP
option overload (52) will mean breaking them.

If option overload (52) is required, then just copy the options to the end of
the buffer would be a solution compatible with the current API. So, I've
corrected the implementation and the result is the patch attached for
etherboot 5.0.11 (as of now CVS HEAD of etherboot 5.0).

Any comments?

Vasil