[Etherboot-developers] eb 5.0.10 console_putc clobbers %cl

[Hans-Peter J. <hp...@ur...>]

Hi Ken,

since 5.0.11 is in preparation, I thought, it would be good to at least 
mention a very minor catch.

While examining etherboots tagged image loader, I discovered, that 
console_putc clobbers %cl. Is this intended?

--- ../etherboot-5.0.10/src/pcbios.S	2002-04-20 16:15:31.000000000 +0200
+++ src/pcbios.S	2003-07-30 23:19:46.000000000 +0200
@@ -70,6 +70,7 @@
 	pushl	%ebp
 	movl	%esp,%ebp
 	pushl	%ebx
+	pushl	%ecx
 	pushl	%esi
 	pushl	%edi
 	movb	8(%ebp),%cl
@@ -86,6 +87,7 @@
 #endif
 	popl	%edi
 	popl	%esi
+	popl	%ecx
 	popl	%ebx
 	popl	%ebp
 	ret

If I'm going to prepare some low level debugging stuff for etherboot 
similar as in the patch to grub, is there any chance to get this into 
5.1? (Of course, covered by a #define like LOW_LEVEL_DEBUG)

hexdump(char *msg, char *mem, unsigned int len): what the name implies
regdump(): show the content of i386 cpu registers

They where designed for minimum food print and dependancies, while being 
convenient in usage.

They where very helpful for me, and I bet, other developers would profit 
from them, too. What do you think?

BTW: does anybody has an idea, how to get the %eip register in ix86?

Cheers,
Pete