Re: [Etherboot-developers] [PATCH] First version of the b44 driver

[Stefan H. <ste...@gm...>]

mcb30's suggestion is nice, let's get rid of that delay loop and break
instead.  I do not expect a noticable performance impact.

b44_free_rings:
The network stack owns the TX io buffers and we shouldn't be freeing
them.  Setting the tx_iobuf[] pointers to NULL is good though.

Pedantic:
1. Please whitespace the code uniformly to use tabs.
2. I believe the functions you refactored/added put the open curly on
a new line instead of on the same line like most of the code.

Thanks so much for pushing this for inclusion.  I know I am hassling
you to fix some of my own mistakes, so let me know, I could fix it up
myself.

:)
Stefan