Re: [Etherboot-developers] [PATCH] virtio-net: Fix kick/wait logic

[Stefan H. <ste...@gm...>]

Sorry for the delay Laurent.  I spoke with Marty about this patch on
the weekend and it will be applied.

Michael: If you are okay with this patch in gPXE, please give the
go-ahead.  Will apply to Etherboot tonight.

Stefan

On Thu, Oct 16, 2008 at 1:03 PM, Laurent Vivier <Lau...@bu...> wrote:
> Le jeudi 09 octobre 2008 à 11:08 +0200, Laurent Vivier a écrit :
>> Le mercredi 08 octobre 2008 à 17:02 -0300, Eduardo Habkost a écrit :
>> > The virtnet_transmit() logic for waiting the packet to be transmitted is
>> > reversed: we can't wait the packet to be transmitted if we didn't kick()
>> > the ring yet. The vring_more_used() while loop logic is reversed also,
>> > that explains why the code works today.
>> >
>> > The current code risks trying to free a buffer from the used ring
>> > when none was available, that will happen most times because KVM
>> > doesn't handle the packet immediately on kick(). Luckily it was working
>> > because it was unlikely to have a buffer still queued for transmit when
>> > virtnet_transmit() was called.
>> >
>> > Also, adds a BUG_ON() to vring_get_buf(), to catch cases where we try
>> > to free a buffer from the used ring when there was none available.
>>
>> Nice work. Thank you.
>>
>> Tested and reviewed. It is ok for me.
>>
>> Marty, could you apply it, please ?
>
> ping ?
> --
> ------------------ Lau...@bu...  ------------------
> "Tout ce qui est impossible reste à accomplir"    Jules Verne
> "Things are only impossible until they're not" Jean-Luc Picard
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Etherboot-developers mailing list
> Eth...@li...
> https://lists.sourceforge.net/lists/listinfo/etherboot-developers
>