[Etherboot-developers] Re: .zrom and .rom images broken in current CVS?

[Michael B. <mb...@fe...>]

On Fri, 30 Apr 2004, Marty Connor wrote:
> > I have patched genrules.pl to create an entry for ROMTYPE_<family>;  
> > this ROM image now builds correctly.
> Actually, I think we still have a problem.
> Here is the last bit of output I get from "make bin/mx98715.zrom"
> <snip>
> Somehow it is running makerom.pl twice, and inserting the wrong PCI IDs 
> in the image both times:

Fixed.  It was a bug in the Makefile that calculated $(ROMCARD); it 
assumed that $* would always be the "card" bit of "bin/card.type", i.e. 
that all make targets are of the form "bin/%.type".  This isn't always 
correct, so now I calculate $(ROMCARD) by taking $@ and stripping off the 
"bin/" and the file extension (and then taking the first entry if it's a 
multiple-driver list).

> In the case of "make bin/$FAMILY.?rom" (e.g. "make bin/tulip.zrom") I
> don't think it should be building at all, unless there is a member of
> that family that happens to have the same name as the family (e.g.  
> rtl8139:rtl8139) or if it is an ISA-only family.
> 
> If there are no PCI IDs for a given target-name, then, if it is not an
> ISA ROM, the request is in error.
> 
> Does this make sense?

Yes, but it would complicate the build process.  Since the different PCI 
ROMs within a family differ only by their PCI header, the current process 
is to build a family ROM (e.g. bin/tulip.rom) then copy this to the 
specified target (e.g. bin/mx98715.rom) and just rewrite the PCI header 
values.

Michael