[Etherboot-users] Re: tftp: client does not accept options

[Christian R. <ki...@as...>]

On Mon, Sep 02, 2002 at 04:58:06PM -0700, H. Peter Anvin wrote:
> Christian Reis wrote:
> > Hey there,
> > 
> > Is there an easy way to find out what options are making my server cry
> > in its logs?
> > 
> > Sep  2 11:30:50 anthem in.tftpd[428]: tftp: client does not accept options 
> > Sep  2 11:31:41 anthem in.tftpd[468]: tftp: client does not accept options 
> > Sep  2 11:32:04 anthem in.tftpd[508]: tftp: client does not accept options 
> > Sep  2 11:35:42 anthem in.tftpd[602]: tftp: client does not accept options 
> > Sep  2 11:45:46 anthem in.tftpd[867]: tftp: client does not accept options 
> > 
> > I guess I can track down what box it is, but is there a way of finding
> > out through tftpd which options the client doesn't like?
> > 
> 
> Probably not -- I think "client does not accept" is an all or nothing. 
> Note that this is normal for PXE clients -- all known PXE stacks does a 
> "dummy transfer" to query the size of the target file, and terminate the 
> connection with an OPNAK error so it doesn't have to sit through the 
> whole transfer.

Maybe it should be LOG_INFO then (though it's ugly, still)?

--- tftpd/tftpd.c-orig  Mon Sep  2 21:37:55 2002
+++ tftpd/tftpd.c       Mon Sep  2 21:38:56 2002
@@ -1078,7 +1078,7 @@
       ap->th_block = ntohs((u_short)ap->th_block);
       
       if (ap->th_opcode == ERROR) {
-       syslog(LOG_ERR, "tftp: client does not accept "
+       syslog(LOG_INFO, "tftp: client does not accept "
               "options\n");
        goto abort;
       }

(Would avoid scaring me with stuff in syslog that isn't really an error,
but I realize it may be more delicate than that.)

Another alternative would be to only call syslog if it's not a PXE
transfer, though I'm not sure that's possibly, since there seems to be
no indication of it in the code. And it would also make it impossible to
discover actual PXE option errors.

Another option yet is to do nothing, which is sometimes the best
alternative.

Take care,
--
Christian Reis, Senior Engineer, Async Open Source, Brazil.
http://async.com.br/~kiko/ | [+55 16] 261 2331 | NMFL