Menu

#19 auction.c hardcoded http without ssl

Unstable (example)
closed-fixed
nobody
None
2
2019-03-21
2019-01-31
No

Hello,
The auction.c file still points to many hardcoded links in http instead of https. This patch should solve that.

1 Attachments

Discussion

  • Michael S.

    Michael S. - 2019-03-16

    That's correct, but none of them passes any private data though the GET request.
    Did you verify your patch along the whole bidding process ?

     
  • Renaud Allard

    Renaud Allard - 2019-03-16

    Yes, it did work for me. Even if it doesn't contain private data, everything should still be in https to prevent snooping.

     
  • Michael S.

    Michael S. - 2019-03-16

    Done ! I will commit the patch within the next days.

    Thank you very much for your submission,

     
  • Michael S.

    Michael S. - 2019-03-17

    This would only be a very first step to get better privacy.

    Meanwhile most of the ebay forms are using the "POST" method instead of "GET".

    e.g.

    https://offer.ebay.com/ws/eBayISAPI.dll?MakeBid&fromPage=pageid&item=itemid&fb=2

    all other items (maxbid, quant, ...) are transmitted in the data section.

    Just changing from "http" to "https" will not prevent others from reading the data, because they are transmitted via the url-parameters.

     
  • Michael S.

    Michael S. - 2019-03-19

    I've changed the function preBid() and bid() from GET to POST. Several other changes had been done on the code. I will commit the new file auction.c within the next days.

     
  • Michael S.

    Michael S. - 2019-03-21
    • status: open --> closed-fixed
     
  • Michael S.

    Michael S. - 2019-03-21

    See committed [16ae50]

     

    Related

    Commit: [16ae50]


Log in to post a comment.

MongoDB Logo MongoDB