Menu

#716 Title not found

v1.0 (example)
closed-fixed
nobody
None
5
2017-05-29
2017-02-21
No
Automated esniper bug report.
esniper version 2.32.0
libcurl/7.51.0 SecureTransport zlib/1.2.8
Error encountered in function parseBidHistory in history.c line 147
auction = 132094418864, price = 72.00, remain = 0
latency = 0, result = -1, error = 0
buf = 0x7f906402e000, size = 48479, read = 0x7f906402e000
time = 1487688563, offset = 0
pagename = "eBay Item Bid History", pageid = "(null)", srcid = "(null)"
specified options or config values:
  1 x username(u) = ***
  1 x (P) = ***
unknown pagename
then upload and attach esniper.34333.2.bug.html and click submit.

Auction 132094418864: Title not found

1 Attachments

Discussion

  • Michael S.

    Michael S. - 2017-02-22
     
  • Bodo

    Bodo - 2017-03-13
    • status: open --> closed-fixed
     
  • Bodo

    Bodo - 2017-03-13

    fixed in version 2.33.0

     
  • dima

    dima - 2017-05-27

    Hi. I'm still seeing this issue in 2.33.0. Are you sure this was fixed?

     
  • Michael S.

    Michael S. - 2017-05-27

    Yes, the bugs was fixed in 2.33.0. Please attach esniper.xxxxx.x.bug.html to see if you are using the correct version or if your problem is something new.

     
  • dima

    dima - 2017-05-27

    Thank you for replying. Log is here:

    http://pub.secretsauce.net/esniper.TitleNotFound.bug.tar.gz

    This is from a fresh build from CVS as of today (2017-05-27), although I see the same issue when running from a Debian package.

     
  • Michael S.

    Michael S. - 2017-05-28

    I have made some changes to auction.c and history.c (see attachment):

    cvs diff: Diffing .
    Index: auction.c
    ===================================================================
    RCS file: /cvsroot/esniper/esniper/auction.c,v
    retrieving revision 1.139
    diff -r1.139 auction.c
    169a170,179
    >   if (title == NULL) {
    >       memReset(mp);
    >       while((line = getTag(mp))) {
    >       if (!strcasecmp(line, "h1 class=\"page-title__main\"")) {
    >                     line = getNonTag(mp);
    >                     if (line) title = myStrdup(line); 
    >                     break;
    >                     }
    >       } 
    >   }
    Index: history.c
    ===================================================================
    RCS file: /cvsroot/esniper/esniper/history.c,v
    retrieving revision 1.32
    diff -r1.32 history.c
    110c110,111
    <                 !strncmp(pp->pageName, "eBay Item Bid History", 21) )) {  
    ---
    >                               !strncmp(pp->pageName, "eBay Item Bid History", 21) ||    
    >                               !strncmp(pp->pageName, "Bid history", 11) )) {    /* Version newer than 2.33 */   
    114c115
    <       if (!strncmp(pp->pageName, "eBay Item Bid History", 21))
    ---
    >       if (!strncmp(pp->pageName, "eBay Item Bid History", 21) || !strncmp(pp->pageName, "Bid history", 11) )
    312a314
    > 
    

    Please have a try !

     

    Last edit: Michael S. 2017-05-28
  • Michael S.

    Michael S. - 2017-05-28

    Commited to CVS.

     
  • dima

    dima - 2017-05-29

    Thanks a lot for the patches! Unfortunately the latest on CVS still doesn't solve the issue for me. Logs:

    http://pub.secretsauce.net/esniper.TitleNotFound.bug.2.tar.gz

     
  • Michael S.

    Michael S. - 2017-05-29

    This bug is different from the other. In this case a fixed price offer is affected.

     
  • dima

    dima - 2017-05-29

    Oh yes. You're right. Would it be difficult to change the error message to make this obvious?

    I tested this again with an actual auction, and it works now. Thank you! Finally, what is your sense about how pervasive the issue was? Was it something specific to my account, or do you think this was broken for everybody? If it was broken for everyone, I'm going to try to get the Debian package updated asap, since the new Debian release is coming out soon. Thanks again.

     
  • Michael S.

    Michael S. - 2017-05-29

    In your html-Source the following message can be found: "Sorry, it's not an auction item".
    So we had to implement a better error detection.

     
  • Michael S.

    Michael S. - 2017-05-29

    I have done some investigations: The main problem is, that the redirection to the final page is not done by a server reply or meta-tag. The target URL is called by a short java script, which is not executable by the curl libraries. So we had to scan for something like "<script> ... "redirect":{"type":"NAV","URL":"http://offer.ebay.com/ws/eBayISAPI.dll?ViewBidsLogin&item=<item&rt=nc&_trksid=<tskid>"} ... </script>".
    I hope, that "normal" auction processing will not be affected by this kind of handling.

     

    Last edit: Michael S. 2017-05-29

Log in to post a comment.