#676 Bid History Parsing Bug

[Alan Swanson]

Successful bid but bug reported when checking outcome. Using UK ebay sites. And thank you for esniper!

Auction 111470839745: Bidding...
Auction 111470839745: Waiting 11 seconds for auction to complete...
Auction 111470839745: Post-bid info:
Auction 111470839745: Mordaunt Short MS20i Pearl Edition Speakers. Excellent Condition. Boxed
esniper encountered a bug.  Please go to:
        http://sourceforge.net/tracker/?func=add&group_id=45285&atid=442436
paste this into "Detailed Description":
Automated esniper bug report.
        esniper version 2.31.0
        libcurl/7.36.0 OpenSSL/1.0.1i zlib/1.2.8 librtmp/2.3
        Error encountered in function parseBidHistory in history.c line 307
        auction = 111470839745, price = 60, remain = 132
        latency = 0, result = 0, error = 0
        buf = 0x7f805bac31a0, size = 44937, read = 0x7f805bac31a0
        time = 1412143375, offset = 0
        pagename = "PageViewBids_Closed_HighBidder", pageid = "(null)", srcid = "ViewBids"
        specified options or config values:
          2 x username(u) = ***
          2 x seconds(s) = 10
          2 x quantity(q) = 1
          1 x (P) = ***
          1 x (f) = "esniper-ms20ipearl"
          2 x reduce() = 1
          2 x bid() = 1
          2 x debug(d) = 1
          2 x batch(b) = 0
          2 x logdir(l) = "/var/tmp/"
          2 x historyHost() = "offer.ebay.co.uk"
          2 x prebidHost() = "offer.ebay.co.uk"
          2 x bidHost() = "offer.ebay.co.uk"
          2 x loginHost() = "signin.ebay.co.uk"
          2 x myeBayHost() = "my.ebay.co.uk"
        remaining time not found
then upload and attach esniper.6798.1.bug.html and click submit.
Auction 111470839745: Mordaunt Short MS20i Pearl Edition Speakers. Excellent Condition. Boxed
esniper encountered a bug.  Please go to:
        http://sourceforge.net/tracker/?func=add&group_id=45285&atid=442436
paste this into "Detailed Description":
        Automated esniper bug report.
        esniper version 2.31.0
        libcurl/7.36.0 OpenSSL/1.0.1i zlib/1.2.8 librtmp/2.3
        Error encountered in function parseBidHistory in history.c line 307
        auction = 111470839745, price = 60, remain = 132
        latency = 0, result = 0, error = 0
        buf = 0x7f805bac31a0, size = 44933, read = 0x7f805bac31a0
        time = 1412143378, offset = 0
        pagename = "PageViewBids_Closed_HighBidder", pageid = "(null)", srcid = "ViewBids"
        specified options or config values:
          2 x username(u) = ***
          2 x seconds(s) = 10
          2 x quantity(q) = 1
          1 x (P) = ***
          1 x (f) = "esniper-ms20ipearl"
          2 x reduce() = 1
          2 x bid() = 1
          2 x debug(d) = 1
          2 x batch(b) = 0
          2 x logdir(l) = "/var/tmp/"
          2 x historyHost() = "offer.ebay.co.uk"
          2 x prebidHost() = "offer.ebay.co.uk"
          2 x bidHost() = "offer.ebay.co.uk"
          2 x loginHost() = "signin.ebay.co.uk"
          2 x myeBayHost() = "my.ebay.co.uk"
        remaining time not found
then upload and attach esniper.6798.2.bug.html and click submit.
Auction 111470839745: Mordaunt Short MS20i Pearl Edition Speakers. Excellent Condition. Boxed
esniper encountered a bug.  Please go to:
        http://sourceforge.net/tracker/?func=add&group_id=45285&atid=442436
paste this into "Detailed Description":
        Automated esniper bug report.
        esniper version 2.31.0
        libcurl/7.36.0 OpenSSL/1.0.1i zlib/1.2.8 librtmp/2.3
        Error encountered in function parseBidHistory in history.c line 307
        auction = 111470839745, price = 60, remain = 132
        latency = 0, result = 0, error = 0
        buf = 0x7f805bac31a0, size = 44937, read = 0x7f805bac31a0
        time = 1412143381, offset = 0
        pagename = "PageViewBids_Closed_HighBidder", pageid = "(null)", srcid = "ViewBids"
        specified options or config values:
          2 x username(u) = ***
          2 x seconds(s) = 10
          2 x quantity(q) = 1
          1 x (P) = ***
          1 x (f) = "esniper-ms20ipearl"
          2 x reduce() = 1
          2 x bid() = 1
          2 x debug(d) = 1
          2 x batch(b) = 0
          2 x logdir(l) = "/var/tmp/"
          2 x historyHost() = "offer.ebay.co.uk"
          2 x prebidHost() = "offer.ebay.co.uk"
          2 x bidHost() = "offer.ebay.co.uk"
          2 x loginHost() = "signin.ebay.co.uk"
          2 x myeBayHost() = "my.ebay.co.uk"
        remaining time not found
then upload and attach esniper.6798.3.bug.html and click submit.
Auction 111470839745: Time remaining not found

unknown outcome, assume that you have won 1 items

[Alan Swanson]

Second HTML bug output.

[Alan Swanson]

Third HTML bug output (couldn't seem at attach more than one at once).

[Bodo]

I'm sorry, but I don't have enough time to keep esniper compatible with ebay sites other than the default (US) ones. (Ebay changes the sites individually.) If the same problem occurs with the default site I will analyze the problem.
I accept patches, but make sure you don't break esniper for the default sites.

[Alan Swanson]

Looks like a string case difference. In the Time Left section of parseBidHistoryInternal() in history.c it matches against "Time Ended:" but in the HTML bug output it was "Time ended:" with lower case e.

So maybe replace strstr with strcasestr of memStr() in http.c?

[Bodo]

Thanks for the analysis, I will try your suggestion.

[Bodo]

I added a case insensitive version of memStr() as memCaseStr() and use this to check for "Time Ended:" or "Time ended:". Please try the latest version from CVS.

[Bodo]

fixed in CVS