Menu

#39 Shouldn't maxdst have been cntdst when checking flceng_stored_g?

0.3
closed
nobody
None
2015-07-08
2015-07-07
KM Tu
No

At line 410 in engproc.F90
https://sourceforge.net/p/ermod/code/ci/ver03/tree/engproc.F90#l410
shouldn't maxdst have been cntdst, instead?

I have not caught all the ideas behind the codes, yet. I just intuitively suspect that there may be a mistake at line 4 in the following snippet, where maxdst should be cntdst:

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
          if(myrank == 0) then
             do irank = 1, nactiveproc
                do cntdst = 1, maxdst
                   if(flceng_stored_g(maxdst, irank)) then
                      if(maxdst == 1) then
                         write(io_flcuv, 911) &
                                        (stnum + irank - 1) * skpcnf, &
                                        flceng_g(1:numslv, cntdst, irank)
                      else
                         write(io_flcuv, 912) cntdst, &
                                        (stnum + irank - 1) * skpcnf, &
                                        flceng_g(1:numslv, cntdst, irank)
                      endif
911                   format(i9, 999f15.5)
912                   format(2i9, 999f15.5)
                   endif
                enddo
             enddo
          endif

Since at line 8 and 12, we write out flceng_g(:, cntdst, irank), thus I think at line 4 we should check the data at flceng_stored_g(cntdst, irank), shouldn't we?

Discussion

  • Shun Sakuraba

    Shun Sakuraba - 2015-07-08

    You are right. it should be cntdst. Fixed in e21cecdeb277.

     
  • Shun Sakuraba

    Shun Sakuraba - 2015-07-08
    • status: open --> closed
     

Log in to post a comment.

Auth0 Logo