Re: [Erlyaws-list] some other error

[<kl...@ta...>]

Lev Walkin wrote:
> 
> I think this particular error report is caused by some
> bug; it shouldn't be happening.
> 
> =ERROR REPORT==== 27-Nov-2007::05:53:11 ===
> Yaws process died: {{badrecord,http_request},
>                     [{yaws_server,fix_abs_uri,2},
>                      {yaws_server,aloop,3},
>                      {yaws_server,acceptor0,2},
>                      {proc_lib,init_p,5}]}
> 


This would happen when we receive traffic that
isn't even HTTP traffic. It should just be
silently discarded:

Thanks



Index: yaws/src/yaws_server.erl
===================================================================
--- yaws/src/yaws_server.erl    (revision 1179)
+++ yaws/src/yaws_server.erl    (working copy)
@@ -814,7 +814,7 @@
      put(init_db, get()),
      SSL = GS#gs.ssl,
      case  yaws:http_get_headers(CliSock, SSL) of
-       {Req0, H0} ->
+       {Req0, H0} when Req0#http_request.method /= bad_request ->
             {Req, H} = fix_abs_uri(Req0, H0),
             SC = pick_sconf(GS#gs.gconf, H, GS#gs.group, SSL),
             ?Debug("SC: ~s", [?format_record(SC, sconf)]),
@@ -847,7 +847,10 @@
             Call = call_method(Req#http_request.method, CliSock, Req, H),
             handle_method_result(Call, CliSock, IP, GS, Req, H, Num);
         closed ->
-           {ok, Num}
+           {ok, Num};
+       _ ->
+           % not even HTTP traffic
+           exit(normal)
      end.

-- 
Claes Wikstrom                        -- Caps lock is nowhere and
http://www.tail-f.com                 -- everything is under control
cellphone: +46 70 2097763