Re: [Erc-help] [PATCH] erc: xemacs set-buffer-multibyte compat, expand-file-name where due, erc-log fix

[Adrian A. <ad...@xe...>]

Alex Schroeder <al...@em...> writes:

> Adrian Aichner <Adr...@t-...> writes:
>
>> I'd like to commit this patch soonish after review from wencem,
>> disumu, or any other kind soul.
>
> I looked it through and it looked fine to me.

Thanks for the review!

You probably saw on erc-help that I goofed on the ChangeLog.

>
>> This gotta be automated.
>> I hate manual "processes"!
>
> At the time RMS told me that it was very simple -- just remove the
> file name indent from the lines you would commit to ChangeLog...  Has
> worked for me ever since, although I don't like it either, haha.

The instructions in erc/HACKING work fine in XEmacs too, no need for
the "very simple" PITA :-)

I am getting close to tracking down the erc-log growth.

It's basically caused by erc-log incorrectly inserting server log
files into channel buffers due to erc-current-logfile<f> not dtrt
thing in combination with erc-generate-log-file-name-long not using
the buffer argument and the default target being nil.

Still hanging in there.

Adrian

>
> Alex.

-- 
Adrian Aichner
 mailto:ad...@xe...
 http://www.xemacs.org/