[Erc-help] Re: [PATCH] erc: xemacs set-buffer-multibyte compat, expand-file-name where due, erc-log fix

[Adrian A. <ad...@xe...>]

Lawrence Mitchell <we...@gm...> writes:

> Adrian Aichner wrote:
>
> [...]
>
>> ChangeLog is for review purposes and will be massaged into shape for
>> commit.
>
>> This gotta be automated.
>
> Use the normal Emacs changelog editing stuff, i.e. C-x 4 a,
> etc... Then, when you come to commit stuff, in the *cvs-commit*
> buffer, do C-c C-a, and, automagically, the changelog entry will
> be pulled in as the log entry.  Had you read HACKING of course,
> you would know this already :).

I read it and I was referring to this bit:


If you do use these helpers and then cut and paste into
the *cvs-commit* buffer, please remove the leading header line and
the leading spaces and module names, since they get reconstructed
automatically.

e.g.
M-x add-change-log-entry RET might give something like this:

| 2004-03-04  Lawrence Mitchell  <we...@gm...>
|
|	* erc.el (erc-foo-p): New function.

We only want the following in the cvs log:

| (erc-foo-p): New function.

Hmmh, I failed to register the bit about C-c C-a, gonna try that, thanks!

>
> OTOH, I think this is yet another plea for, "can we have a
> proper changelog please", what do people think?

No, I can comply with any process, as long as it's automated for
XEmacs as well as GNU Emacs.

>
> [...]
>
>> 	* erc-autojoin.el: Typo fix.
>> 	* erc-dcc.el (erc-dcc-do-GET-command): Use expand-file-name.
>> 	* erc-dcc.el (erc-dcc-get-file): Ditto.
>> 	* erc-log.el (erc-generate-log-file-name-with-date): XEmacs
>> 	set-buffer-multibyte compatibility.
>> 	* erc-log.el (erc-generate-log-file-name-short): Use expand-file-name.
>> 	* erc-log.el (erc-save-buffer-in-logs): Wrap `with-current-buffer'
>> 	in `save-excursion' as suggested by Sebastian Freundt.
>> 	* erc-members.el: XEmacs set-buffer-multibyte compatibility.
>> 	* erc-sound.el: Use expand-file-name.
>> 	* erc.el (erc-debug-log-file): Ditto.
>> 	* erc.el (erc-find-file): Ditto.
>
> Some of this changelog entry looks wrong.  For instance, you

Yes, I messed up the ChangeLog, darn!

> don't put any set-buffer-multibyte stuff in erc-log, it's in
> erc-dcc.  And erc-members only gets an (eval-when-compile

Index error :-(

> (require 'erc)).  Other than that, I see nothing wrong with the

Yep, to avoid macro miscompilation.

> actual patches themselves.

Will correct tomorrow and commit if that's OK.

Thanks for the quick review!

Adrian

>
> [...]

-- 
Adrian Aichner
 mailto:ad...@xe...
 http://www.xemacs.org/