[Erc-help] Re: erc-backend.el: incorrect handling of command arguments

[Lawrence M. <we...@gm...>]

Jeremy Maitin-Shepard wrote:

> The attached patch is a quick attempt to reduce the breakage.  It
> allows me to connect to both Freenode and Undernet, although I think
> some things are still broken.

Goddammit :).  I feel we should kick irc server implementors
multiple times, whilst wearing big shoes :P.

> I decided it is useful to keep the `contents' field as a pointer for
> quick access to the last element of the `command-args' list, but all
> arguments, including the last one, are part of the `command-args' list.

Seems reasonable, though note comments below.

[...] Patch elided.

> I haven't committed this patch because it probably breaks some
> functionality on Freenode, since the existing response handlers don't
> expect `contents' to be duplicated in `command-args'.

I think, given what you say about the difference between freenode and
undernet, it's probably best just to drop the contents field
entirely, and just shove everything in command-args.  It
probably makes things slightly messier, but there we go.  In any case...

> Lawrence, please fix whatever needs to be fixed.

This will, unfortunately, have to wait :(.  What with finals and
all, I have no real time at all between now and the 10th of
June, I then move out of my flat on the 17th, so will have to
pack things up and so on.  I may find a day or so sometime after
friday this coming week, but please don't expect too much.

I'd /guess/ that most of the stuff that would need fixing is
just doing a search and replace with (erc-response.contents ...)
replaced with (car (last (erc-response.command-args ...))),
however, there are probably likely to be some subtleties.

-- 
Lawrence Mitchell <we...@gm...>