Re: [Erc-help] erc-dcc creates wrong files under ms windows

[Mario L. <ml...@de...>]

Stephan Stahl <st...@is...> writes:

> I wrote:
>
>> Well thanks so far. I hope i find some time during the weekend to take a
>> closer look at the issue. However i would really appreciate it if someone who
>> knows erc better could help and make dcc work.
>
> I have found a little time to look at erc-dcc and got it to work.
Great!

> In the function erc-dcc-get-file are two lines taken out:
>
> ;      (set-process-coding-system proc 'binary 'binary)
> ;      (set-buffer-file-coding-system 'binary t)
>
> (lines 822 and 823 in the snapshot from erc-2003-08-23.tar.gz
>
> When putting them back in /DCC GET works under ms windows 2k. So the
> question is why are they not in the code and should they be put
> back?

AFAIR, those two lines were the first thing we tried to make
binary transfers work.  It originally failed, and we had
a discussion on emacs-devel about how to impelemnt a filter-function
which does binary-transfer.  Another method was suggested, which worked (the
current multibyte  = nil thing), and I think I just
uncommented the old method.

> Are there some cases where they do not the right thing?
I don't know.  I suspect though, that having both will
not hurt.

Well, I'll just uncomment them and test if dcc still works under
UNIX, if it does, I'll commit that.

Thanks for your findings

-- 
CYa,
  Mario | Debian Developer <URL:http://debian.org/>
        | Get my public key via finger ml...@db...
        | 1024D/7FC1A0854909BCCDBE6C102DDFFC022A6B113E44