erc-help — Archive of problems, bugs, features, news

[Erc-help] Re: replace `string-to-int' calls ?

[Michael O. <mw...@gn...>]

John Paul Wallington <jp...@po...> writes:

> How about replacing the `string-to-int' calls with
> `string-to-number' ?  (`string-to-int' was made obsolete in the
> Emacs sources on 2005-05-01)

Thanks for the report; I've implemented this in CVS HEAD.

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Interests: anime, Debian, XHTML, wiki, Emacs Lisp
  /` |\ | | | IRC: mwolson on freenode.net: #hcoop, #muse, #pulug
 |_] | \| |_| Jabber: mwolson_at_hcoop.net

[Erc-help] replace `string-to-int' calls ?

[John P. W. <jp...@po...>]

How about replacing the `string-to-int' calls with `string-to-number' ?
(`string-to-int' was made obsolete in the Emacs sources on 2005-05-01)

2005-06-12  John Paul Wallington  <jp...@po...>

	* erc.el (erc-nickname-in-use): Use `string-to-number' instead of
	`string-to-int'.
	* erc-dcc.el (erc-dcc-handle-ctcp-send)
	(erc-dcc-handle-ctcp-chat, erc-dcc-get-file)
	(erc-dcc-chat-accept): Likewise
	* erc-identd.el (erc-identd-start): Likewise.


Index: erc.el
===================================================================
RCS file: /cvsroot/erc/erc/erc.el,v
retrieving revision 1.760
diff -u -r1.760 erc.el
--- erc.el	8 Jun 2005 06:42:50 -0000	1.760
+++ erc.el	15 Jun 2005 21:31:45 -0000
@@ -4278,7 +4278,7 @@
 	  (setq newnick (concat (truncate-string-to-width
 				 nick
 				 (if (and erc-connected nicklen)
-				     (- (string-to-int nicklen) 1)
+				     (- (string-to-number nicklen) 1)
 				   ;; rfc2812 max nick length = 9
 				   ;; we must assume this is the server's setting
 				   ;; if we haven't established a connection yet

Index: erc-dcc.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-dcc.el,v
retrieving revision 1.88
diff -u -r1.88 erc-dcc.el
--- erc-dcc.el	21 Mar 2005 07:56:42 -0000	1.88
+++ erc-dcc.el	15 Jun 2005 21:31:45 -0000
@@ -578,7 +578,7 @@
 	 'dcc-send-offered
 	 ?f filename ?n nick ?u login ?h host
 	 ?s (if (string= size "") "unknown" size))
-	(and (< (string-to-int port) 1025)
+	(and (< (string-to-number port) 1025)
 	     (erc-display-message
 	      nil 'notice proc
 	      'dcc-privileged-port
@@ -587,7 +587,7 @@
 	 'GET (format "%s!%s@%s" nick login host)
 	 nil proc
 	 :ip ip :port port :file filename
-	 :size (string-to-int size))
+	 :size (string-to-number size))
 	(if (and (eq erc-dcc-send-request 'auto)
                  (erc-dcc-auto-mask-p (format "\"%s!%s@%s\"" nick login host)))
 	    (erc-dcc-get-file (car erc-dcc-list) filename proc))))
@@ -630,7 +630,7 @@
 	 nil 'notice proc
 	 'dcc-chat-offered
 	 ?n nick ?u login ?h host ?p port)
-	(and (< (string-to-int port) 1025)
+	(and (< (string-to-number port) 1025)
 	     (erc-display-message
 	      nil 'notice proc
 	    'dcc-privileged-port ?p port))
@@ -825,7 +825,7 @@
 	    (funcall erc-dcc-connect-function
 		     "dcc-get" buffer
 		     (plist-get entry :ip)
-		     (string-to-int (plist-get entry :port))
+		     (string-to-number (plist-get entry :port))
 		     entry))
       (set-process-buffer proc buffer)
       ;; The following two lines make saving as-is work under Windows
@@ -1035,7 +1035,7 @@
           (funcall erc-dcc-connect-function
                    "dcc-chat" nil
                    (plist-get entry :ip)
-                   (string-to-int (plist-get entry :port))
+                   (string-to-number (plist-get entry :port))
                    entry))
     ;; XXX: connected, should we kill the ip/port properties?
     (setq entry (plist-put entry :peer proc))

Index: erc-identd.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-identd.el,v
retrieving revision 1.3
diff -u -r1.3 erc-identd.el
--- erc-identd.el	18 Jan 2005 02:50:55 -0000	1.3
+++ erc-identd.el	15 Jun 2005 21:31:45 -0000
@@ -55,7 +55,7 @@
   (if (null port)
       (setq port 8113)
     (if (stringp port)
-	(setq port (string-to-int port))))
+	(setq port (string-to-number port))))
   (if erc-identd-process
       (delete-process erc-identd-process))
   (setq erc-identd-process

[Erc-help] Re: Useless format calls

[Michael O. <mw...@gn...>]

Andreas Schwab <sc...@su...> writes:

> Calling format with a string that does not contain any format
> directives is pretty pointless.

Thanks; I've installed the patch.

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Jabber: mwolson_at_hcoop.net -- IRC: mwolson on freenode.net: #muse, #pulug
  /` |\ | | |
 |_] | \| |_|   Interests: anime, Debian GNU/Linux, XHTML, wiki, Emacs Lisp

[Erc-help] Useless format calls

[Andreas S. <sc...@su...>]

Calling format with a string that does not contain any format directives
is pretty pointless.

Andreas.

Index: erc.el
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/erc/erc/erc.el,v
retrieving revision 1.757
diff -u -a -p -u -p -a -r1.757 erc.el
--- erc.el	4 Jun 2005 00:39:22 -0000	1.757
+++ erc.el	6 Jun 2005 12:54:23 -0000
@@ -3789,8 +3789,7 @@ The ban list is fetched from the server=20
=20
     (cond
      ((not (erc-channel-p chnl))
-      (erc-display-line (erc-make-notice
-			 (format "You're not on a channel\n"))
+      (erc-display-line (erc-make-notice "You're not on a channel\n")
 			'active))
=20
      ((not (get 'channel-banlist 'received-from-server))
@@ -3861,7 +3860,7 @@ Unban all currently banned users in the=20
=20
      ((not (erc-channel-p chnl))
       (erc-display-line
-       (erc-make-notice (format "You're not on a channel\n"))
+       (erc-make-notice "You're not on a channel\n")
        'active))
=20
      ((not (get 'channel-banlist 'received-from-server))

--=20
Andreas Schwab, SuSE Labs, sc...@su...
SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany
Key fingerprint =3D 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

[Erc-help] Re: `erc-prettify-channel-list' docfix

[Michael O. <mw...@gn...>]

John Paul Wallington <jp...@po...> writes:

> Spotted this in one of bojohan's screenshots:
>
> --- erc-list.el	21 Mar 2005 07:56:42 +0000	1.41
> +++ erc-list.el	03 Jun 2005 23:56:44 +0100=09
> @@ -307,7 +307,7 @@
>  (defun erc-prettify-channel-list ()
>    "Make the channel list buffer look pretty.
>  When this function runs, the current buffer must be the channel list
> -buffer, or it doesn't nothing."
> +buffer, or it does nothing."
>    (if (eq major-mode 'erc-chanlist-mode)
>        (save-excursion
>  	(let ((inhibit-read-only t))

Thanks for the heads up!  I've installed this change in CVS head.

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Jabber: mwolson_at_hcoop.net -- IRC: mwolson on freenode.net: #muse, #pulug
  /` |\ | | |
 |_] | \| |_|   Interests: anime, Debian GNU/Linux, XHTML, wiki, Emacs Lisp

[Erc-help] Re: erc-track XEmacs fixes in ERC 5.0.3

[Michael O. <mw...@gn...>]

Michael Olson <mw...@gn...> writes:

> Another change I made was to add `erc-modified-channels-update' to
> erc-disconnected-hook with the goal of wiping the track indicators
> From the mode line when ERC quits, since sometimes the server buffer
> indicators stay on the mode line after closing.  You might have to
> have `erc-kill-server-buffer-on-quit' set to non-nil in order to
> replicate this.  It doesn't seem to do the job though, so I'm going
> to revert this change.

This issue should now be fixed in CVS head.  The
erc-modified-channels-update function will check to see if a buffer is
still connected to an ERC process; if not connected, it is removed
From=20the modified channels alist.

Hopefully this behavior is desirable in all situations where a
disconnect happens; if not, it should be fairly easy to fix.

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Jabber: mwolson_at_hcoop.net -- IRC: mwolson on freenode.net: #muse, #pulug
  /` |\ | | |
 |_] | \| |_|   Interests: anime, Debian GNU/Linux, XHTML, wiki, Emacs Lisp

[Erc-help] `erc-prettify-channel-list' docfix

[John P. W. <jp...@po...>]

Spotted this in one of bojohan's screenshots:

--- erc-list.el	21 Mar 2005 07:56:42 +0000	1.41
+++ erc-list.el	03 Jun 2005 23:56:44 +0100	
@@ -307,7 +307,7 @@
  (defun erc-prettify-channel-list ()
    "Make the channel list buffer look pretty.
  When this function runs, the current buffer must be the channel list
-buffer, or it doesn't nothing."
+buffer, or it does nothing."
    (if (eq major-mode 'erc-chanlist-mode)
        (save-excursion
  	(let ((inhibit-read-only t))

[Erc-help] erc-track XEmacs fixes in ERC 5.0.3

[Michael O. <mw...@gn...>]

In the process of testing ERC 5.0.3 before release, I found that a few
error messages showed up if you run /QUIT when channel buffers with
new content exist.  I tried to fix this by slightly modifying the
`erc-modified-channels-display' function in erc-track.el.

Another change I made was to add `erc-modified-channels-update' to
erc-disconnected-hook with the goal of wiping the track indicators
From=20the mode line when ERC quits, since sometimes the server buffer
indicators stay on the mode line after closing.  You might have to
have `erc-kill-server-buffer-on-quit' set to non-nil in order to
replicate this.  It doesn't seem to do the job though, so I'm going to
revert this change.

Both of these patches are included in the 5.0.3 release, and I've
migrated all the 5.0 release branch fixes into CVS head.

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Jabber: mwolson_at_hcoop.net -- IRC: mwolson on freenode.net: #muse, #pulug
  /` |\ | | |
 |_] | \| |_|   Interests: anime, Debian GNU/Linux, XHTML, wiki, Emacs Lisp

[Erc-help] ERC 5.0.3 has been released

[Michael O. <mw...@gn...>]

ERC (Emacs IRC Client) 5.0.3 is released.

The tarball is available at
http://sourceforge.net/project/showfiles.php?group_id=30118.

Thanks to all of the contributors who made this release possible.  The
NEWS entry for this release has been attached to this message.

-- 
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Jabber: mwolson_at_hcoop.net -- IRC: mwolson on freenode.net: #muse, #pulug
  /` |\ | | |
 |_] | \| |_|   Interests: anime, Debian GNU/Linux, XHTML, wiki, Emacs Lisp

[Erc-help] Re: erc-nicklist and erc-bbdb updates

[Michael O. <mw...@gn...>]

Edg...@in... (Edgar Gon=C3=A7alves) writes:

> I changed erc-bbdb, also. I didn't like how it was changing the name
> of the record to the (sometimes very) long MSN nick. So I created a
> new field. Also, when doing a /whois, it tries to find the record,
> but if it can't, it asks you for a name to it. If you find the
> proper record, you may use it. if it's not, it asks you for another
> one (and if there's no record under that name, it simply uses the
> name to create a new one). Yes, I left out the case I don't find any
> record and don't want to create any. simply do a \C-g , if you want
> to do a whois, you prolly want to know that person. or you may
> delete the record without saving bbdb!

To add context to this change: this makes the integration or ERC with
BitlBee (http://www.bitlbee.org/) seem more like a normal instant
messaging program.  The improved MSN protocol integration can be
obtained by applying the patches from (http://www.bitlbee.be/andy/) to
bitlbee and recompiling.  There are also some AIM patches at
(http://get.bitlbee.org/patches/hanji/) that might provide similar
functionality.

Once ERC 5.0.3 is released, I plan to hack on erc-nicklist.el and
erc-bbdb.el along with Edgar.  These are some things I would like to
see:

 * Buddy icons (probably provided in a folder, given that it might be
   hard to fetch them from other people over AIM without Yet Another
   Bitlbee patch).

 * Ability to get buddy information.  Edgar seems to have implemented
   this part already for the most part.

The question is: shall I

 1. Merge these changes into CVS HEAD once the 5.0.3 release is done.

or

 2. Make a new CVS branch that has these changes.

I'm assuming that most of you probably don't use Arch, so this would
be a way to keep you in the loop.  I would regularly sync changes
between CVS and Arch, much like I am doing now.

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Jabber: mwolson_at_hcoop.net -- IRC: mwolson on freenode.net: #muse, #pulug
  /` |\ | | |
 |_] | \| |_|   Interests: anime, Debian GNU/Linux, XHTML, wiki, Emacs Lisp

[Erc-help] erc-nicklist and erc-bbdb updates

[<Edg...@in...>]

ARRRG... must... stop... myself... ok, i can't. :)

So, ignoring all of my non-emacs-deadlines, i went to look at erc-bbdb, and
found out things weren't that hard to improve. And voil=E1!, a new patch in=
 my erc
arch mirror! for those who don't know it, it's:

ee...@es...--2005
http://www.esw.inesc-id.pt/~eemg/arch/ee...@es...
(version:  ee...@es...--2005/erc--eemg--0)

I changed erc-bbdb, also. I didn't like how it was changing the name of the
record to the (sometimes very) long MSN nick. So I created a new field. Als=
o,
when doing a /whois, it tries to find the record, but if it can't, it asks =
you
for a name to it. If you find the proper record, you may use it. if it's no=
t, it
asks you for another one (and if there's no record under that name, it simp=
ly
uses the name to create a new one). Yes, I left out the case I don't find a=
ny
record and don't want to create any. simply do a \C-g , if you want to do a
whois, you prolly want to know that person. or you may delete the record wi=
thout
saving bbdb!

After this, I modded the tooltips in my erc-nicklist - they are smaller, and
include the msn nick, if there is one. the away is smarter - only shows up =
when
effectively away! (for those who feel out-of-context, my erc-nicklist now s=
hows
images according the the BitlBee medium and the voice status (ie, away or n=
ot).

Now this has opened a lot of doors for me, related to bbdb storage and
access. But until I have some time I only have a question about nicks: some=
 of
my MSN buddies have nicks with strange hieroglyphs on it, and some of the
characters appear under a different encoding (like \200, \227, etc, etc). S=
o I
wonder what encoding should I use and how is one to change it The-Right-Way=
(TM)?
I have the same problem in Gnus, some mails appear with those character cod=
es,
but I never got the coding issue right!

Cheers!
--=20
Edgar Gon=E7alves
Software Engineering Group @ INESC-ID
Portugal

[Erc-help] ERC 5.0.3 status update

[Michael O. <mw...@gn...>]

I was without internet access for most of the past month, which
delayed my estimated release date for ERC 5.0.3.  Sorry about that.

The current status for the release follows.  I have merged most of the
bugfix patches from CVS HEAD into the 5.0 release branch, with 3 or so
remaining.  Once these are in, I'll update the NEWS file, edit the
debian/changelog file appropriately, and make the release happen.  I
anticipate completing the release this week, now that I am at a place
with reasonable net access.

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Jabber: mwolson_at_hcoop.net -- IRC: mwolson on freenode.net: #muse, #pulug
  /` |\ | | |
 |_] | \| |_|   Interests: anime, Debian GNU/Linux, XHTML, wiki, Emacs Lisp

[Erc-help] Re: rcirc IRC implementation for Emacs

[Michael O. <mw...@gn...>]

Richard Stallman <rm...@gn...> writes:

>     I've been using ERC for some time now, and I'm pretty satisfied
>     with it.  But I don't know how it compares with other clients
>     since I didn't try any of them yet.
>
> If we want to add an IRC client, and if people like ERC, we could
> install that one instead, if the authors will sign papers for it.

Currently most of the authors and contributors of ERC have assigned
changes to the FSF, with a few (~7) exceptions.  I will contact these
people this week in order to speed the process along.  It would be
nice to have ERC included with Emacs.

Another possible barrier would be the lack of a manual.  There is an
online draft at http://www.emacswiki.org/cgi-bin/wiki/EmacsIRCClient
that could possibly be turned into a full Texinfo manual.  Shall I
begin doing this?

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Jabber: mwolson_at_hcoop.net -- IRC: mwolson on freenode.net: #muse, #pulug
  /` |\ | | |
 |_] | \| |_|   Interests: anime, Debian GNU/Linux, XHTML, wiki, Emacs Lisp

[Erc-help] Upcoming 5.0.3 release and 5.1 plans

[Michael O. <mw...@gn...>]

I'd like to package another minor 5.0 release (5.0.3) by sometime next
week.  I'm currently in the process of testing and merging patches to
the 5.0 branch.  5.0.3 will contain only bugfixes; the new modules
`erc-spelling' and `erc-voper' will be present in the next major
release (5.1).  5.0.3 will probably be the last release of the 5.0
series.

It seems like it would be best to call the next major release 5.1 and
base it off of CVS head.  In terms of time, would next month be a
reasonable time to put out the 5.1 release?

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Jabber: mwolson_at_hcoop.net -- IRC: mwolson on freenode.net: #muse, #pulug
  /` |\ | | |
 |_] | \| |_|   Interests: anime, Debian GNU/Linux, XHTML, wiki, Emacs Lisp

[Erc-help] interaction between fools and timestamps

[Pascal J.B. <pj...@in...>]

I had this  problem: erc was showing timestamps when a hiden fool
message came in.  It is due to the order the erc insert modify hooks are
run.  To solve it, I added this to erc-mode-hook:

(setf erc-insert-modify-hook
  (cons 'erc-add-timestamp (delete 'erc-add-timestamp erc-insert-modify-hook)))

but of course, then I had to move the timestamp to the left for the
right alignment would not be able to be done.

Perhaps the right solution would be in erc-add-timestamp to check that
the message is hidden and then not insert the time stamp or insert it
hidden too.

Also, unless  erc-insert-modify-hook is to be considered internal,
perhaps the hooks put in erc-insert-modify-hook should have a priority
to have them ordered correctly?


-- 
__Pascal Bourguignon__                     http://www.informatimago.com/
Kitty like plastic.
Confuses for litter box.
Don't leave tarp around.

[Erc-help] [C] erc: define-erc-response-handler (JOIN) to save-excursion

[Adrian A. <ad...@xe...>]

COMMIT

-- 
Adrian Aichner
 mailto:ad...@xe...
 http://www.xemacs.org/

[Erc-help] [PATCH] erc: define-erc-response-handler (JOIN) to save-excursion

[Adrian A. <ad...@xe...>]

Hi erclings!

The missing save-excursion is the cause of (erc-current-logfile)
inserting into the wrong channel buffers when using
erc-log-insert-log-on-open in combination with autojoin to multiple
channels.

I'll commit later today if noone catches a flaw with this patch.

My own testing went well.

Best regards,

Adrian

ChangeLog addition:

2005-04-24  Adrian Aichner  <ad...@xe...>

	* erc-backend.el (JOIN): save-excursion so that
	`erc-current-logfile' inserts into the correct channel buffers
	when using erc-log-insert-log-on-open in combination with autojoin
	to multiple channels.


erc source patch:
Diff command:   cvs -f -z3 -q diff -u -w -N
Files affected: erc-backend.el erc-backend.el

Index: erc-backend.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-backend.el,v
retrieving revision 1.27
diff -u -w -r1.27 erc-backend.el
--- erc-backend.el	4 Apr 2005 16:38:11 -0000	1.27
+++ erc-backend.el	24 Apr 2005 16:36:31 -0000
@@ -452,6 +452,7 @@
       ;; strip the stupid combined JOIN facility (IRC 2.9)
       (if (string-match "^\\(.*\\)?\^g.*$" chnl)
           (setq chnl (match-string 1 chnl)))
+      (save-excursion
       (let* ((str (cond
                    ;; If I have joined a channel
                    ((erc-current-nick-p nick)
@@ -478,7 +479,7 @@
         (erc-update-channel-member chnl nick nick t nil nil host login)
         ;; on join, we want to stay in the new channel buffer
         ;;(set-buffer ob)
-	(erc-display-message parsed nil buffer str)))))
+	  (erc-display-message parsed nil buffer str))))))
 
 (define-erc-response-handler (KICK)
   "Handle kick messages received from the server." nil

-- 
Adrian Aichner
 mailto:ad...@xe...
 http://www.xemacs.org/

Re: [Erc-help] Re: a couple of issues (services-module; doc string; buffer creation; encoding)

[Tobias C. R. <tc...@fr...>]

Adrian Aichner <ad...@xe...> writes:

> "Tobias C. Rittweiler" <tc...@fr...> writes:
>
> [...]
> > * If I'm queried (or if generally a new buffer ought to be created), I'd
> >   like the newly created buffer to replace the current buffer of a
> >   specific frame. I usually have erc in its own frame and Gnus, too, and
> >   when I'm writing a mail and someone queries me, my mail buffer pops
> >   off (but instead erc should do so with the most recently used buffer in
> >   the erc frame.) Is this possible? Or how do you deal with this problem?
>
> Do docstrings of erc-auto-query and erc-join-buffer help to get this
> set up the way you want?

Of course, I studied them (and `erc-setup-buffers', too); it's how I
came to the conclusion that this isn't supported by ERC as of now. 


Or did you mean if they help to get this written up by my own? Well, I
browsed through the sections of the Elisp Manual concerning Buffers,
Windows and Frames. The basic functions are there, of course.

However, to be more detailed, I'd like to have ERC manage buffer
creation the following way: Each server its own frame containing the
buffers belonging to the server (ie. to the channels or users of that
server.) When a user of server Foo queries me, I'd like to have the last
used buffer in the frame of server Foo be replaced by the newly created
buffer. (I think there should also be convenient keystrokes for
switching between buffers belonging to one frame (resp. server), as I'm
not aware of a possibility for that already being within Emacs)

Obviously, what's needed for implementing this, is some kind of
categorization of buffers. Can one add properties to buffers? Is there
any other means?


One question is still unanswered: How do /you/ handle with the above
problem? I can't think, it can be all that uncommon. Maybe I just tackle
the whole thing wrongly...


--tcr.

Re: [Erc-help] Re: a couple of issues (services-module; doc string; buffer creation; encoding)

[Tobias C. R. <tc...@fr...>]

Lawrence Mitchell <we...@gm...> writes:

> The nickserv module performs a function orthogonal to the
> `erc-password' and `erc-prompt-for-password' variables.
> `erc-password' is used to authenticate to /servers/ that require
> it upon connection (this is sometimes the case with private
> servers).  The nickserv module installs hooks to automatically
> authenticate you to the NICKSERV service once you have logged in
> to the server---to do this it uses the passwords in
> `erc-nickserv-passwords'.

Oh, I just see that the reason for my confusion was the server I came
across which happened to (or, at least, seems to) be able to use a
supplied PASS for nickserv authentification. [I assume this is the way
it works, because when using `erc-select' to connect to that server, I
type in my password at a prompt showing "Password: "---I'm successfully
identified to nickserv later, however. No I didn't set any
erc-nickserv-* variables.] Well, I thought there must be some connection
between `erc-password' and the `erc-nickserv' module, but I couldn't
find one in the code, that's the way I came to be puzzled.

Howsoever, I wouldn't mind some additional comments about the different
purpose and maybe a note on the issue I encountered, though.


> I'd probably write:
>
> |     A list of modules which ERC is to load and activate
> |     automatically. Loading and activation are performed by
> |     `erc-update-modules' so modifying this variable outside of
> |     `customize' will take no effect unless you call
> |     \(erc-update-modules).

Fine with me. Will you take care creating patches for this and the
above one?


[Me wrote:]
> > * I intend to change the format of `erc-encoding-coding-alist' to
> >   introduce an additional server level, so that the encoding is
> >   determined not only by matching a channel, but also by matching an
> >   irc-server (analogously to `erc-autojoin-channels-alist'.) I think
> >   this can be done backwards-compatibly by testing if the CDR of an
> >   entry in the encoding alist is a symbol or not. (I think, this is easy
> >   enough that I'll do that myself when I have some spare time.
>
> Sounds good.

What's about the issue on copyright assignment?


--tcr. 

[Erc-help] Re: a couple of issues (services-module; doc string; buffer creation; encoding)

[Lawrence M. <we...@gm...>]

Tobias C. Rittweiler wrote:

> Hi,

> * I wonder how nicely the 'nickserv module plays with the usual
>   authentification mechanism (I'm speaking of `erc-password' and
>   `erc-prompt-for-password'.) Do I still have to set the latter variable
>   to NIL when I specified a password to be used via the 'nickserv
>   module?  After a short glance over the code, I'd say yes---although I
>   didn't really grasp the hook mechanisms spooking in `erc-nickserv.el'.

The nickserv module performs a function orthogonal to the
`erc-password' and `erc-prompt-for-password' variables.
`erc-password' is used to authenticate to /servers/ that require
it upon connection (this is sometimes the case with private
servers).  The nickserv module installs hooks to automatically
authenticate you to the NICKSERV service once you have logged in
to the server---to do this it uses the passwords in
`erc-nickserv-passwords'.

[...]

>     A list of modules which erc load and activate automatically. This
>     loading and activation is performed by `erc-update-modules', hence
>     remember to call \(erc-update-modules), if you set the value of this
>     without using `customize'.

I'd probably write:

|     A list of modules which ERC is to load and activate
|     automatically. Loading and activation are performed by
|     `erc-update-modules' so modifying this variable outside of
|     `customize' will take no effect unless you call
|     \(erc-update-modules).

> * If I'm queried (or if generally a new buffer ought to be created), I'd
>   like the newly created buffer to replace the current buffer of a
>   specific frame. I usually have erc in its own frame and Gnus, too, and
>   when I'm writing a mail and someone queries me, my mail buffer pops
>   off (but instead erc should do so with the most recently used buffer in
>   the erc frame.) Is this possible? Or how do you deal with this problem?

`erc-auto-query'?  The buffer-creation mechanism is rather opaque
to me.

> * I intend to change the format of `erc-encoding-coding-alist' to
>   introduce an additional server level, so that the encoding is
>   determined not only by matching a channel, but also by matching an
>   irc-server (analogously to `erc-autojoin-channels-alist'.) I think
>   this can be done backwards-compatibly by testing if the CDR of an
>   entry in the encoding alist is a symbol or not. (I think, this is easy
>   enough that I'll do that myself when I have some spare time.

Sounds good.

-- 
Lawrence Mitchell <we...@gm...>

[Erc-help] Re: a couple of issues (services-module; doc string; buffer creation; encoding)

[Adrian A. <ad...@xe...>]

"Tobias C. Rittweiler" <tc...@fr...> writes:

> Hi,
>

Hi Tobias!

<34 lines deleted by Adrian Aichner>
> * If I'm queried (or if generally a new buffer ought to be created), I'd
>   like the newly created buffer to replace the current buffer of a
>   specific frame. I usually have erc in its own frame and Gnus, too, and
>   when I'm writing a mail and someone queries me, my mail buffer pops
>   off (but instead erc should do so with the most recently used buffer in
>   the erc frame.) Is this possible? Or how do you deal with this problem?

Do docstrings of erc-auto-query and erc-join-buffer help to get this
set up the way you want?

Best regards,

Adrian

<23 lines deleted by Adrian Aichner>

-- 
Adrian Aichner
 mailto:ad...@xe...
 http://www.xemacs.org/

[Erc-help] Re: a couple of issues (services-module; doc string; buffer creation; encoding)

[Adrian A. <ad...@xe...>]

"Tobias C. Rittweiler" <tc...@fr...> writes:

> Hi,
>

Hi Tobias!

> * If I'm queried (or if generally a new buffer ought to be created), I'd
>   like the newly created buffer to replace the current buffer of a
>   specific frame. I usually have erc in its own frame and Gnus, too, and
>   when I'm writing a mail and someone queries me, my mail buffer pops
>   off (but instead erc should do so with the most recently used buffer in
>   the erc frame.) Is this possible? Or how do you deal with this problem?

Do docstrings of erc-auto-query and erc-join-buffer help to get this
set up the way you want?

Best regards,

Adrian

-- 
Adrian Aichner
 mailto:ad...@xe...
 http://www.xemacs.org/

[Erc-help] a couple of issues (services-module; doc string; buffer creation; encoding)

[Tobias C. R. <tc...@fr...>]

Hi,

* I wonder how nicely the 'nickserv module plays with the usual
  authentification mechanism (I'm speaking of `erc-password' and
  `erc-prompt-for-password'.) Do I still have to set the latter variable
  to NIL when I specified a password to be used via the 'nickserv
  module?  After a short glance over the code, I'd say yes---although I
  didn't really grasp the hook mechanisms spooking in `erc-nickserv.el'.
 

* As I read through the erc-<module>.el files, I got confused by theirs
  commentaries because, for instance, `erc-stamp.el' says there: ``In
  order to actually activate this, you must call `erc-timestamp-mode'.''

  Of course, this is absolutely correct when looking at the commentary
  from a module-oriented perspective. That's why I don't suggest to
  change it. However, the defcustom `erc-modules', which I consulted for
  clarification, wasn't as much a relief as I wished it was, because I
  misunderstood the first sentence of the doc string which goes:

    A list of modules which erc should enable

  I mixed up what ``enable'' means in this context, ie. I thought the
  modules specified in `erc-modules' were just loaded but not activated
  and I had to invoke the ERC-<foo>-MODE functions manually. Even though
  not wrong, I suggest to change the doc string to something like
  
    A list of modules which erc load and activate automatically. This
    loading and activation is performed by `erc-update-modules', hence
    remember to call \(erc-update-modules), if you set the value of this
    without using `customize'.
    
    Note: When using `customize', modules removed from the list will be
          disabled.


* If I'm queried (or if generally a new buffer ought to be created), I'd
  like the newly created buffer to replace the current buffer of a
  specific frame. I usually have erc in its own frame and Gnus, too, and
  when I'm writing a mail and someone queries me, my mail buffer pops
  off (but instead erc should do so with the most recently used buffer in
  the erc frame.) Is this possible? Or how do you deal with this problem?


* I intend to change the format of `erc-encoding-coding-alist' to
  introduce an additional server level, so that the encoding is
  determined not only by matching a channel, but also by matching an
  irc-server (analogously to `erc-autojoin-channels-alist'.) I think
  this can be done backwards-compatibly by testing if the CDR of an
  entry in the encoding alist is a symbol or not. (I think, this is easy
  enough that I'll do that myself when I have some spare time.


--tcr.

Re: [Erc-help] Re: ERC could take advantage of .authinfo/.netrc

[<tc...@fr...>]

Adrian Aichner <ad...@us...> writes:

> tc...@fr... (Tobias C. Rittweiler) writes:
>
> > Adrian Aichner <ad...@xe...> writes:
> >
> > > Ah, and netrc.el is in the mail-lib XEmacs package, not in gnus.  I
> > > just checked.
> >
> > As well as in in GNU Emacs (22.0.50 at least); there it's in
> > net/netrc.el. Does that relativise your complain? :-)
>
> Yes, it does -- not that I have any say here :-)
>
> Are you thinking of optional functionality based on
> (featurep 'netrc)
> test?

Well, probably not of that particular test because from my
understanding, this would just test for `netrc' being already loaded or
not. Using REQUIRE with the &optional NOERROR being set, seems to be a
solution where you can better determine if this package is really
unloadable. Of course, I'm open for corrections on this and suggestion
or caveats in general on how to hack this up best.


> Using an ftp configuration file for erc seems a bit abusive, though.

Let's consider it to be the most essential kind of auth. configuration.


--tcr.

  

[Erc-help] [C] erc: Upstream sync resulting from recent XEmacs erc sync

[Adrian A. <ad...@xe...>]

COMMIT

I trust this is not-controversial so I have commit it.

Let me know if you have issues with any of these changes.

Best regards,

Adrian

ChangeLog addition:

2005-04-17  Adrian Aichner  <ad...@xe...>

	* erc-log.el: Remove stray whitespace.
	* erc.el: Ditto.

2005-04-09  Aidan Kehoe  <ke...@pa...>

	* erc.el: autoload erc-select-read-args, which, because it parses
	erc-select's args, can be called before erc.el is loaded. 


erc source patch:
Diff command:   cvs -f -z3 -q diff -u -N
Files affected: erc.el erc-log.el

Index: erc-log.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-log.el,v
retrieving revision 1.23
diff -u -r1.23 erc-log.el
--- erc-log.el	1 Mar 2005 05:54:52 -0000	1.23
+++ erc-log.el	17 Apr 2005 10:37:55 -0000
@@ -279,7 +279,7 @@
 		      (erc-current-nick)
 		      erc-session-server erc-session-port))
    erc-log-channels-directory))
-	     
+
 (defun erc-generate-log-file-name-with-date (buffer &rest ignore)
   "This function computes a short log file name.
 The name of the log file is composed of BUFFER and the current date.
Index: erc.el
===================================================================
RCS file: /cvsroot/erc/erc/erc.el,v
retrieving revision 1.751
diff -u -r1.751 erc.el
--- erc.el	5 Apr 2005 01:08:18 -0000	1.751
+++ erc.el	17 Apr 2005 10:37:58 -0000
@@ -2082,6 +2082,7 @@
   :group 'erc-hooks
   :type 'hook)
 
+;;;###autoload
 (defun erc-select-read-args ()
   "Prompt the user for values of nick, server, port, and password."
   (let (user-input server port nick passwd)
@@ -5409,7 +5410,7 @@
 	
 	;; Only when last hook has been run...
 	(run-hook-with-args 'erc-send-completed-hook str))))))
-  
+
 (defun erc-user-input ()
   "Return the input of the user in the current buffer."
   ;; We use erc-bol to ignore the prompt.

-- 
Adrian Aichner
 mailto:ad...@xe...
 http://www.xemacs.org/