erc-help — Archive of problems, bugs, features, news

Re: [Erc-help] ERC is now installed to Emacs

[Andreas S. <sc...@su...>]

Michael Olson <mw...@gn...> writes:

> I've completed the installation of ERC to Emacs.

I'm getting the following warnings during compilation:

erc-ibuffer.el:58:25:Warning: `:documentation' called as a function
erc-ibuffer.el:67:24:Warning: reference to free variable `buf'
erc-ibuffer.el:69:24:Warning: reference to free variable `qualifier'
erc-ibuffer.el:72:24:Warning: reference to free variable `erc-modified'
erc-ibuffer.el:72:24:Warning: `:name' called as a function
erc-ibuffer.el:75:43:Warning: reference to free variable
    `erc-modified-channels-alist'
erc-ibuffer.el:91:24:Warning: reference to free variable `erc-server-name=
'
erc-ibuffer.el:91:24:Warning: `:name' called as a function
erc-ibuffer.el:97:24:Warning: reference to free variable `erc-target'
erc-ibuffer.el:97:24:Warning: `:name' called as a function
erc-ibuffer.el:110:24:Warning: reference to free variable `erc-topic'
erc-ibuffer.el:110:24:Warning: `:name' called as a function
erc-ibuffer.el:117:2:Warning: reference to free variable `erc-members'
erc-ibuffer.el:117:2:Warning: `:name' called as a function
erc-ibuffer.el:125:24:Warning: `:name' called as a function
erc-ibuffer.el:134:2:Warning: reference to free variable `erc-op'
erc-ibuffer.el:134:2:Warning: `:name' called as a function
erc-ibuffer.el:140:24:Warning: reference to free variable `erc-voice'
erc-ibuffer.el:140:24:Warning: `:name' called as a function
erc-ibuffer.el:146:24:Warning: `:name' called as a function
erc-ibuffer.el:160:24:Warning: `:name' called as a function

In end of data:
erc-ibuffer.el:184:1:Warning: the following functions are not known to be
    defined: ibuffer-define-limiter, :documentation, ibuffer-define-colum=
n,
    :name

Andreas.

--=20
Andreas Schwab, SuSE Labs, sc...@su...
SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany
PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED=
5
"And now for something completely different."

[Erc-help] Re: ERC is now installed to Emacs

[Henrik E. <hen...@te...>]

> I've completed the installation of ERC to Emacs.  It differs from ERC
> CVS HEAD in the following ways.
>
>  - The ChangeLog files had to have a copyright statement added, which
>    is a strange requirement IMHO, but a convention nonetheless.  I
>    won't add these lines to ERC CVS HEAD.

The ChangeLogs need a coding cookie in the local variables section.
iso-2022-7bit seem to be what Emacs uses.

[Erc-help] ERC is now installed to Emacs

[Michael O. <mw...@gn...>]

I've completed the installation of ERC to Emacs.  It differs from ERC
CVS HEAD in the following ways.

 - I had to drop the erc-bbdb.el, erc-chess.el, and erc-speak.el
   modules because they had dependencies on external software.

 - The manual had its GPL and GFDL sections removed, since that seems
   to be the convention.

 - The version strings for modules have been removed.  The $Revision
   stuff would give results inconsistent with ERC CVS HEAD, since
   Emacs is also managed by CVS.  Also, the erc-version-string has
   been modified to "Version 5.1 (Emacs 22)".

 - The NEWS file has been installed to etc/ERC-NEWS.

 - The ChangeLog files had to have a copyright statement added, which
   is a strange requirement IMHO, but a convention nonetheless.  I
   won't add these lines to ERC CVS HEAD.

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Interests: manga, Debian, XHTML, wiki, Emacs Lisp
  /` |\ | | | IRC: mwolson on freenode.net: #hcoop, #muse, #PurdueLUG
 |_] | \| |_| Jabber: mwolson_at_hcoop.net

[Erc-help] ERC 5.1 released

[Michael O. <mw...@gn...>]

ERC NEWS                                                       -*- outline -*-

* Changes since ERC 5.0.4

** Improve XEmacs compatibility.

** Namespace changes

*** Now ERC doesn't use global variable space.
Renamed all variables that didn't start with "erc-".

  o `away' is now `erc-away'

  o `current-nick' is now `erc-server-current-nick'

  o `last-peers' is now `erc-server-last-peers'

  o `last-ping-time' is now `erc-server-last-ping-time'

  o `last-sent-time' is now `erc-server-last-sent-time'

  o `lines-sent' is now `erc-server-lines-sent'

  o `quitting' is now `erc-server-quitting'

*** Remove the `with-erc-channel-buffer' function.

** Bugfixes

*** Don't inadvertently destroy face properties.

*** Load erc scripts in a safer way.

*** Don't insert a timestamp if text at point is invisible.

*** Don't hide messages from those in `erc-fools' by default.
Color their nicks instead.

*** Use a more foolproof method of encoding and decoding strings
before sending to a channel.

** Backend changes

*** Renamed some server-specific variables

  o `erc-announced-server-name' is now `erc-server-announced-name'

  o `erc-auto-reconnect' is now `erc-server-auto-reconnect'

  o `erc-connect-function' is now `erc-server-connect-function'

  o `erc-default-coding-system' is now `erc-server-coding-system'

  o `erc-duplicate-timeout' is now `erc-server-duplicate-timeout'

  o `erc-duplicates' is now `erc-server-duplicates'

  o `erc-lag' is now `erc-server-lag'

  o `erc-prevent-duplicates' is now `erc-server-prevent-duplicates'

  o `erc-previous-read' is now `erc-server-filter-data'

  o `erc-process' is now `erc-server-process'

  o `erc-ping-handler' is now `erc-server-send-ping-handler'

  o `erc-ping-interval' is now `erc-server-send-ping-interval'

*** Renamed some functions

  o `erc-connect' is now `erc-server-connect'

  o `erc-process-filter' is now `erc-server-filter-function'

  o `erc-send-command' is now `erc-server-send'

  o `erc-send-single-line' is now `erc-send-input'

  o `erc-setup-periodical-server-ping' is now
    `erc-server-setup-periodical-server-ping'

  o `erc-split-command is now `erc-split-line'

*** New options

  o erc-server-flood-margin, erc-server-flood-penalty: New options
    that allow tweaking of flood control.

  o erc-split-line-length: The maximum line length of a single
    message.

*** New variables

  o erc-server-flood-last-message, erc-server-flood-queue,
    erc-server-flood-timer: Flood control.

  o erc-server-processing-p: Indicate when we're currently processing
    a message.

*** Remove some options

  o `erc-flood-limit'
  o `erc-flood-limit2'

** New customization group `erc-server' for dealing with IRC servers.

** ERC can now be installed by doing `make install' from the command line.

** ERC now has a manual in erc.texi.
Type `make doc' to generate HTML and Info versions of it.

** ERC no longer depends on cl.el.
Only the macros in cl-macs.el are used.

** Fix an edge case when quitting as new messages come in.

** Make flood protection toggle-able as on/off, removing the 'strict option.

** If possible, re-use channel buffers when reconnecting to a server.

** Text in ERC buffers is now read-only by default.
To get the previous behavior, 

** Changes and additions to modules

*** Auto-join (erc-autojoin.el)

**** Recognize the Azzurra server.

*** BBDB (erc-bbdb.el)

**** When the user types /WHOIS, ask for a record to merge to.

**** Store the displayed name of a BitlBee contact.
The new `erc-bbdb-bitlbee-name-field' option specifies the field to use
to store this information.

**** Don't prompt for a name on /JOIN or /NICK.

*** Button (erc-button.el)

**** Fix customization of `erc-button-alist'

**** New option `erc-button-nickname-face' determines the face to use
when coloring ERC nicknames.

*** Channel tracking (erc-track.el)

**** Remove channels from the modified channels list if not currently
connected.  This should remove residue from the mode line after
quitting ERC.

**** Recognize buttonized text

*** Highlighting (erc-match.el)

**** Highlight current nickname by default.

**** Added the option of beeping when certain matches occur.
Add `erc-beep-on-match' to `erc-text-matched-hook' to enable
beeping.  Set the new variable `erc-beep-match-types' which match
types that make beeps.

*** Nicklist (erc-nicklist.el)

**** Fix a couple of errors.

**** Make sure a stray mouse click doesn't trigger an error.

**** Insert icons from the /images directory next to nicks.
This indicates their away status.  The location is customizable via
the new `erc-nicklist-icons-directory' option.

If you do not want these icons, set `erc-nicklist-use-icons' to nil.

*** Nickserv identification (erc-nickserv.el)

**** Recognize Azzurra and OFTC networks.

*** Old completion (erc-complete.el)

**** Disable by default.

*** Programmable completion (erc-pcomplete.el)

**** Enable by default.

*** Timestamps (erc-stamp.el)

**** On Emacs22, align right timestamps perfectly, even if variable-width
characters are used.  If we aren't using Emacs22, move text farther
away from the right margin when variable-width characters are used.
It is considered better to misalign the stamp by a bit than to go past
the right margin.

**** Enable by default

** New modules

*** Spell-checking (erc-spelling.el)

**** Use flyspell in ERC.

*** Viper compatibility (erc-viper.el)

**** Helps ERC work correctly in viper-mode.

[Erc-help] Re: State of release

[Michael O. <mw...@gn...>]

boj...@dd... (Johan Bockg=C3=A5rd) writes:

> It's invisible; `buffer-invisibility-spec' is t in the server buffer.
>
> erc-stamp is turned on (by `erc-update-modules') after `erc-mode' is
> run in the server buffer. erc-stamp puts
> `erc-munge-invisibility-spec' on `erc-mode-hook', but this is too
> late for existing erc buffers.

I've attempted to fix this.

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Interests: manga, Debian, XHTML, wiki, Emacs Lisp
  /` |\ | | | IRC: mwolson on freenode.net: #hcoop, #muse, #PurdueLUG
 |_] | \| |_| Jabber: mwolson_at_hcoop.net

[Erc-help] Re: State of release

[<boj...@dd...>]

Diane Murray <di...@us...> writes:

> I've not been able to find what's causing it, but recent changes
> (just after 2006-01-20?) have caused timestamps to display
> incorrectly in the server buffer. The timestamp isn't displayed at
> all using either `erc-insert-timestamp-left'or
> `erc-insert-timestamp-right'. I'm pretty sure it's not anything in
> erc-stamp.el.

It's invisible; `buffer-invisibility-spec' is t in the server buffer.

erc-stamp is turned on (by `erc-update-modules') after `erc-mode' is
run in the server buffer. erc-stamp puts `erc-munge-invisibility-spec'
on `erc-mode-hook', but this is too late for existing erc buffers.

-- 
Johan Bockgård

Re: [Erc-help] State of release

[Diane M. <di...@us...>]

> recent changes (just after 2006-01-20?) have caused timestamps to
> display incorrectly in the server buffer.

Oddly enough, just after sending my bug report, I was disconnected
from IRC - I closed the dead server buffer, reconnected, and in the
new server buffer timestamps are now working correctly...

--
disumu

Re: [Erc-help] State of release

[Diane M. <di...@us...>]

> ERC 5.1 is pretty much ready to be released, as all of the
> FOR-RELEASE items for 5.1 have been taken care of.  Please feel free
> to report any unexpected behavior or bugs.

I've not been able to find what's causing it, but recent changes
(just after 2006-01-20?) have caused timestamps to display incorrectly
in the server buffer.  The timestamp isn't displayed at all using
either `erc-insert-timestamp-left'or `erc-insert-timestamp-right'.
I'm pretty sure it's not anything in erc-stamp.el.

--
disumu

[Erc-help] just committed a small bugfix

[Edward O'C. <ho...@gm...>]

Hi all,

`erc-pal' and `erc-fool' nick highlighting broke on me the other day.
I've just tracked down the problem and have committed a fix.

(The problem: `erc-button-add-buttons' needs to appear before
`erc-match-message' in `erc-insert-modify-hook'; otherwise,
`erc-button's nick highlighting clobbers `erc-match's nick
highlighting.)


Ted

-- 
Edward O'Connor
ho...@gm...

Ense petit placidam sub libertate quietem.

[Erc-help] State of release

[Michael O. <mw...@gn...>]

ERC 5.1 is pretty much ready to be released, as all of the FOR-RELEASE
items for 5.1 have been taken care of.  Please feel free to report any
unexpected behavior or bugs.

I expect to make the release happen this Friday.  After that, I'll do
my best to get ERC installed into Emacs22.  The new Arch mirror for
Emacs on Savannah should hopefully make the task easy.

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Interests: manga, Debian, XHTML, wiki, Emacs Lisp
  /` |\ | | | IRC: mwolson on freenode.net: #hcoop, #muse, #PurdueLUG
 |_] | \| |_| Jabber: mwolson_at_hcoop.net

[Erc-help] Re: defstruct erc-response

[Michael O. <mw...@gn...>]

Lawrence Mitchell <we...@gm...> writes:

> I'm not sure defining erc-response as a struct is actually a
> problem.  Since defstruct is a macro, you can just require 'cl are
> compile-time, which is fine as far as Emacs guidelines go I believe.
> Essentially all the erc-response stuff is doing is wrapping some
> syntactic sugar around the parsed server text so that there aren't
> as many magic numbers lieing around in the source code.

OK, I'll just change it to (eval-when-compile (require 'cl)) then.  I
was a bit unnerved at the extra warning that it produced when
compiling (below), but on a second look, they don't appear fatal.

In end of data:
erc-backend.el:1763:1:Warning: the following functions might not be defined=
 at
    runtime: cl-struct-setf-expander, ...
             ^^^^^^^^^^^^^^^^^^^^^^^

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Interests: manga, Debian, XHTML, wiki, Emacs Lisp
  /` |\ | | | IRC: mwolson on freenode.net: #hcoop, #muse, #PurdueLUG
 |_] | \| |_| Jabber: mwolson_at_hcoop.net

[Erc-help] Re: defstruct erc-response

[Lawrence M. <we...@gm...>]

Michael Olson wrote:

[...]

> One major problem involves the use of erc-response as a struct.  What
> would be the best way of dealing with this?  Something non-invasive
> and easy (but that doesn't require 'cl) is preferable.

I'm not sure defining erc-response as a struct is actually a
problem.  Since defstruct is a macro, you can just require 'cl
are compile-time, which is fine as far as Emacs guidelines go I
believe.  Essentially all the erc-response stuff is doing is
wrapping some syntactic sugar around the parsed server text so
that there aren't as many magic numbers lieing around in the
source code.

Prior to erc-response being a struct, it was just an array and
all the various handlers were littered with stuff of the form
(aref response 4) [meaning the command text, IIRC].  So actually,
you could get away with removing the erc-response struct, and
just defining all the various array accessors manually---it's
just more effort.

[...]

Lawrence
-- 
Lawrence Mitchell <we...@gm...>

[Erc-help] defstruct erc-response (was Re: Let's get ERC 5.1 released)

[Michael O. <mw...@gn...>]

Henrik Enberg <hen...@te...> writes:

> FWIW, the last time I looked at erc code, the only file that had an
> actual run-time dependency on cl.el was erc.el, and that was only
> due to some uses of `reduce'.  So the required code fixing should be
> fairly easy.

One major problem involves the use of erc-response as a struct.  What
would be the best way of dealing with this?  Something non-invasive
and easy (but that doesn't require 'cl) is preferable.

For the sake of comparison, here are the ways that our IRC neighbours
pass this data, in brief.

rcirc does something like the following.

(funcall handler process sender args text), called from the filter
function.

Circe does the following, also called from the filter function.

(run-hook-with-args 'circe-receive-message-functions
                    nick user host command args)

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Interests: manga, Debian, XHTML, wiki, Emacs Lisp
  /` |\ | | | IRC: mwolson on freenode.net: #hcoop, #muse, #PurdueLUG
 |_] | \| |_| Jabber: mwolson_at_hcoop.net

Re: [Erc-help] Let's get ERC 5.1 released

[Henrik E. <hen...@te...>]

> I've updated the EmacsWiki.org page for EmacsIRCClient to reflect the
> current status of getting ERC installed into Emacs.
> 
> To re-iterate:
> 
>   ERC has been approved for inclusion in the next version of Emacs.
>   As soon as the items in FOR-RELEASE for ERC 5.1 are taken care of, I
>   will release ERC 5.1 and use that as the basis for the version of
>   ERC in Emacs.

FWIW, the last time I looked at erc code, the only file that had an
actual run-time dependency on cl.el was erc.el, and that was only due to
some uses of `reduce'.  So the required code fixing should be fairly
easy.

[Erc-help] Let's get ERC 5.1 released

[Michael O. <mw...@gn...>]

I've updated the EmacsWiki.org page for EmacsIRCClient to reflect the
current status of getting ERC installed into Emacs.

To re-iterate:

  ERC has been approved for inclusion in the next version of Emacs.
  As soon as the items in FOR-RELEASE for ERC 5.1 are taken care of, I
  will release ERC 5.1 and use that as the basis for the version of
  ERC in Emacs.

Please consider working on some of these items.  I will try to devote
some time to the remaining items next week, provided that the start of
Spring semester doesn't bog me down.

This would also be a great time to begin trying out the latest changes
in CVS head and reporting any issues that come up.

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Interests: manga, Debian, XHTML, wiki, Emacs Lisp
  /` |\ | | | IRC: mwolson on freenode.net: #hcoop, #muse, #PurdueLUG
 |_] | \| |_| Jabber: mwolson_at_hcoop.net

[Erc-help] New location for ERC Arch archive

[Michael O. <mw...@gn...>]

In the spirit of new beginnings and a new year, I've made a new Arch
archive for 2006.

The ERC branch is mw...@gn...--2006/erc--cvs--0.  The location of
the archive is http://www.mwolson.org/archives/2006.

Please note that this is *not* meant to officially replace the CVS
repo.

I'm using a different method of syncing the CVS tree with Arch that
should even allow me to use a cron job.  And as long as you update
ChangeLog when you commit changes to CVS, Arch will receive
nice-looking commit messages when it gets synced :^) .

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Interests: manga, Debian, XHTML, wiki, Emacs Lisp
  /` |\ | | | IRC: mwolson on freenode.net: #hcoop, #muse, #PurdueLUG
 |_] | \| |_| Jabber: mwolson_at_hcoop.net

[Erc-help] ERC release roadmap and Emacs CVS write access

[Michael O. <mw...@gn...>]

Tasks that need to be accomplished in order for a release to happen.

* 5.1 release

** Documentation

*** ERC's manual needs collaborative effort.
Some conditions follow.

Manual text can be based off of pages from EmacsWiki.org, but must be
rewritten.  As long as they're not too close to being word-for-word,
you should be okay.

Contributors to the documentation must have assigned future copyright
for ERC or Emacs.  No separate manual assignment is needed in this
case.  If you haven't assigned future changes and would like to work
on the manual, contact mw...@gn....

*** Search for "@c PRE5_1" to see what needs to be done before the
5.1 release.

Please add your name in brackets after "PRE5_1" in the comment if you
wish to work an item in the short term.

** Makefile

*** install target needed.
This could look at the following new variables.  ELISPDIR determines
where to install ERC.  INFODIR is where manual will be installed.

PREFIX   = /usr/local
ELISPDIR = $(PREFIX)/share/emacs/site-lisp/erc
INFODIR  = $(PREFIX)/info

*** install-info target needed.
Something like the following would work.

%.info: %.texi
	makeinfo $<

install-info: muse.info
	[ -d $(INFODIR) ] || install -d $(INFODIR)
	install -m 0644 muse.info $(INFODIR)/muse
	$(INSTALLINFO) $(INFODIR)/muse

** NEWS: Update for changes since 5.0.4.

* 5.2 release (future)

** Documentation

*** Items with "@c PRE5_2" won't block the 5.1 release, but may block
the release of 5.2.

** Source

*** Make erc-backend not need to (require) any other part of ERC.
This will hopefully increase the chance that it will be useful for
other IRC clients, like Circe.

*** Add binding for S-TAB (backtab) that moves backwards by link.


Local variables:
mode: outline
end:

[Erc-help] Re: [S] [PATCH] erc: XEmacs make-obsolete only takes two arguments

[Adrian A. <ad...@xe...>]

Diane Murray <di...@us...> writes:

> Hi Adrian,
>
>> Apparently this change I commited got lost during refactoring of
>> erc.
>
> Thanks for bringing this up.  I've changed erc-compat.el accordingly.

Thanks, Diane!

It was a blast to work this out so quickly with you in #emacs.

-- 
Adrian Aichner
 mailto:ad...@xe...
 http://www.xemacs.org/

Re: [Erc-help] Re: [S] [PATCH] erc: XEmacs make-obsolete only takes two arguments

[Diane M. <di...@us...>]

Hi Adrian,

> Apparently this change I commited got lost during refactoring of
> erc.

Thanks for bringing this up.  I've changed erc-compat.el accordingly.

--
disumu

[Erc-help] Re: [S] [PATCH] erc: XEmacs make-obsolete only takes two arguments

[Adrian A. <ad...@xe...>]

Adrian Aichner <ad...@xe...> writes:

> I messed up my first try real bad:
> Instead of adding the message-id of Kyle's followup to a references
> mail header, I used it as the message-id of my mail!
>
> This is probably why my mail has not shown up in the
> gmane.emacs.erc.general newsgroup.
>
> I hope I'll get it right this time ...
>
> SUPERSEDES <1xo...@sm...>
>
> Following Kyle's advice, this patch will make XEmacs use the three
> argument version should that become available in a future version of
> XEmacs.
>
> erc developers, please review and send me your approval.
>
> I will then try to commit this little patch myself.
>
> Best regards,
>
> Adrian
>
> ChangeLog addition:
>
> 2004-03-18  Adrian Aichner  <ad...@xe...>
>
> 	* erc-nets.el: Use two arguments version of `make-obsolete', if
> 	third argument is not supported (for XEmacs).

Greetings!

Apparently this change I commited got lost during refactoring of erc.

The compatibility code in erc-compat.el now conditionalizes on
(if (featurep 'xemacs)
again, which is wrong.

I'm going to fix this in the erc XEmacs package again.

I there interest in a patch for this upstream version of erc?

Adrian

>
> erc source patch:
> Diff command:   cvs -f -z3 -q diff -u -N
> Files affected: erc-nets.el
>
> Index: erc-nets.el
> ===================================================================
> RCS file: /cvsroot/erc/erc/erc-nets.el,v
> retrieving revision 1.11
> diff -u -r1.11 erc-nets.el
> --- erc-nets.el	13 Mar 2004 14:04:08 -0000	1.11
> +++ erc-nets.el	18 Mar 2004 21:53:37 -0000
> @@ -712,9 +712,9 @@
>    (with-current-buffer (erc-server-buffer)
>      (intern (downcase (symbol-name erc-network)))))
>  
> -(if (featurep 'xemacs)
> -    (make-obsolete 'erc-current-network 'erc-network)
> -  (make-obsolete 'erc-current-network 'erc-network "Obsolete since erc-nets 1.5"))
> +(condition-case nil
> +    (make-obsolete 'erc-current-network 'erc-network "Obsolete since erc-nets 1.5")
> +  (wrong-number-of-arguments (make-obsolete 'erc-current-network 'erc-network)))
>  
>  (defun erc-network-name ()
>    "Returns the name of the current network as a string."
> @@ -724,9 +724,9 @@
>  ;; returns the name of the current network as a string.  Some of us use these
>  ;; functions in our personal ERC configuration code.  (franl, 2004-03-13)
>  ;;
> -;;(if (featurep 'xemacs)
> -;;    (make-obsolete 'erc-network-name 'erc-network)
> -;;  (make-obsolete 'erc-network-name 'erc-network "Obsolete since erc-nets 1.5"))
> +;;(condition-case nil
> +;;    (make-obsolete 'erc-network-name 'erc-network "Obsolete since erc-nets 1.5")
> +;;  (wrong-number-of-arguments (make-obsolete 'erc-network-name 'erc-network)))
>  
>  (defun erc-set-network-name (proc parsed)
>    "Set `erc-network' to the value returned by `erc-determine-network'."

-- 
Adrian Aichner
 mailto:ad...@xe...
 http://www.xemacs.org/

[Erc-help] Re: Kanji encoding issues

[It's me F. ;) <m_...@ya...>]

Michael Olson <mw...@gn...> writes:

> Someone brought to my attention the fact that the latest ERC from
> CVS head doesn't encode kanji characters properly.

And chinese characters (chinese-iso-8bit) didn't either.

> I overhauled the way that ERC handles encoding so that
> `encode-coding-string' is no longer called, since this seems to be
> the only way to get around the problem.
>

And everything is ok now :P

>
> I've tested the changes by transmitting messages between an instance
>of ERC and Gaim, and the encoding seems to work properly.  No change
>in configuration should be necessary.

Thanks.

[Erc-help] Kanji encoding issues

[Michael O. <mw...@gn...>]

Someone brought to my attention the fact that the latest ERC from CVS
head doesn't encode kanji characters properly.  I overhauled the way
that ERC handles encoding so that `encode-coding-string' is no longer
called, since this seems to be the only way to get around the problem.

I've tested the changes by transmitting messages between an instance
of ERC and Gaim, and the encoding seems to work properly.  No change
in configuration should be necessary.

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Interests: anime, Debian, XHTML, wiki, Emacs Lisp
  /` |\ | | | IRC: mwolson on freenode.net: #hcoop, #muse, #PurdueLUG
 |_] | \| |_| Jabber: mwolson_at_hcoop.net

[Erc-help] Re: Fix the CTCP ACTION non-ascii garbage charactor bug

[Michael O. <mw...@gn...>]

Edward O'Connor <ho...@gm...> writes:

> Since your fix has been checked in, I've been unable to /part or
> /quit without specifying a reason. I tracked it down and checked in
> a fix. I don't know if such a work-around should be applied in more
> places though.

Good catch.  This looks like the right thing to do.

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Interests: anime, Debian, XHTML, wiki, Emacs Lisp
  /` |\ | | | IRC: mwolson on freenode.net: #hcoop, #muse, #PurdueLUG
 |_] | \| |_| Jabber: mwolson_at_hcoop.net

[Erc-help] Re: Fix the CTCP ACTION non-ascii garbage charactor bug

[Edward O'C. <ho...@gm...>]

Michael Olson wrote:

> I've attempted to fix this and other places in the code that need to
> have parts of messages encoded.  The fix should be in CVS HEAD.

Since your fix has been checked in, I've been unable to /part or /quit
without specifying a reason. I tracked it down and checked in a fix. I
don't know if such a work-around should be applied in more places
though.


Ted

-- 
Edward O'Connor
ho...@gm...

Ense petit placidam sub libertate quietem.

[Erc-help] Re: Fix the CTCP ACTION non-ascii garbage charactor bug

[Michael O. <mw...@gn...>]

"It's me FKtPp ;)" <m_...@ya...> writes:

> The orginal `erc-send-ctcp-command' invoke the `erc-send-command'
> with just two parameters. This cause the `erc-send-command' always
> encode CTCP message with default encoding.  The following patch add
> a third parmaeter (erc-default-target) to the `erc-send-command',
> which in most case will fit the needs of encode the CTCP message in
> the correct encoding.

I've attempted to fix this and other places in the code that need to
have parts of messages encoded.  The fix should be in CVS HEAD.

=2D-=20
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Interests: anime, Debian, XHTML, wiki, Emacs Lisp
  /` |\ | | | IRC: mwolson on freenode.net: #hcoop, #muse, #PurdueLUG
 |_] | \| |_| Jabber: mwolson_at_hcoop.net