Menu
▾
▴
erc-help — Archive of problems, bugs, features, news
You can subscribe to this list here.
| 2001 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(10) |
Nov
(46) |
Dec
(2) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2002 |
Jan
(5) |
Feb
|
Mar
(6) |
Apr
(2) |
May
(25) |
Jun
(2) |
Jul
(1) |
Aug
(5) |
Sep
(4) |
Oct
(7) |
Nov
|
Dec
(18) |
| 2003 |
Jan
(8) |
Feb
(1) |
Mar
(2) |
Apr
(4) |
May
(14) |
Jun
(32) |
Jul
(15) |
Aug
(23) |
Sep
(23) |
Oct
(22) |
Nov
(27) |
Dec
(24) |
| 2004 |
Jan
(18) |
Feb
(38) |
Mar
(32) |
Apr
(18) |
May
(70) |
Jun
(1) |
Jul
(21) |
Aug
(19) |
Sep
(32) |
Oct
(11) |
Nov
(11) |
Dec
(19) |
| 2005 |
Jan
(48) |
Feb
(13) |
Mar
(19) |
Apr
(25) |
May
(4) |
Jun
(23) |
Jul
(8) |
Aug
(13) |
Sep
(12) |
Oct
(17) |
Nov
(4) |
Dec
(5) |
| 2006 |
Jan
(31) |
Feb
(30) |
Mar
(28) |
Apr
(11) |
May
(21) |
Jun
(7) |
Jul
(12) |
Aug
(5) |
Sep
(7) |
Oct
(24) |
Nov
(2) |
Dec
|
|
From: Adrian A. <ad...@xe...> - 2004-03-19 01:53:10
|
SUPERSEDES <8yi...@sm...> Hello Hrvoje, hello James! I have reworked my patch to address your valuable feedback. ERC Developers, please see http://labb.contactor.se/~matsl/smoketest/logs/2004-03-15_23-01_macro_err_1.txt for the miscompiled erc macros this patch is addressing. Hrvoje, the set-buffer-multibyte handling should be OK, since that function also already sets the relevant file coding system variables. The requiring of the 'erc feature at the top-level is much better in this case, since no optimized enabling of autoloaded functionalty is involved at all. Please review and send your feedback. I intend to commit to the xemacs repository in a few days and upstream at SourceForge.net as well. Please advise, Adrian packages ChangeLog patch: Diff command: cvs -q diff -U 0 Files affected: xemacs-packages/erc/ChangeLog Index: xemacs-packages/erc/ChangeLog =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/erc/ChangeLog,v retrieving revision 1.10 diff -u -U0 -r1.10 ChangeLog --- xemacs-packages/erc/ChangeLog 19 Mar 2004 01:30:49 -0000 1.10 +++ xemacs-packages/erc/ChangeLog 19 Mar 2004 01:51:06 -0000 @@ -2,0 +3,8 @@ + * erc-dcc.el (erc-dcc-get-file): XEmacs does not have + `set-buffer-multibyte'. Setting of file coding variables takes + care of XEmacs. + * erc-members.el: Fix miscompiled macro by + requiring defining feature at the top-level. + +2004-03-19 Adrian Aichner <ad...@xe...> + packages source patch: Diff command: cvs -f -z3 -q diff -u -N Files affected: xemacs-packages/erc/erc-members.el xemacs-packages/erc/erc-dcc.el Index: xemacs-packages/erc/erc-dcc.el =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/erc/erc-dcc.el,v retrieving revision 1.4 diff -u -r1.4 erc-dcc.el --- xemacs-packages/erc/erc-dcc.el 19 Mar 2004 01:30:49 -0000 1.4 +++ xemacs-packages/erc/erc-dcc.el 19 Mar 2004 01:39:05 -0000 @@ -808,8 +808,12 @@ proc) (with-current-buffer buffer (fundamental-mode) - ;; This is necessary to have the buffer saved as-is. - (set-buffer-multibyte nil) + ;; This is necessary to have the buffer saved as-is in GNU + ;; Emacs. + ;; XEmacs change: We don't have `set-buffer-multibyte', setting + ;; coding system to 'binary below takes care of us. + (when (fboundp 'set-buffer-multibyte) + (set-buffer-multibyte nil)) (setq mode-line-process '(":%s") buffer-file-type t Index: xemacs-packages/erc/erc-members.el =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/erc/erc-members.el,v retrieving revision 1.2 diff -u -r1.2 erc-members.el --- xemacs-packages/erc/erc-members.el 19 Mar 2004 01:30:49 -0000 1.2 +++ xemacs-packages/erc/erc-members.el 19 Mar 2004 01:39:05 -0000 @@ -35,6 +35,13 @@ ;;; Code: +;; Avoid miscompiling macro `erc-log' and `with-erc-channel-buffer' in +;; absence of loaded definition from 'erc. +;; See 2004-03-15_23-01_macro_err_1.txt in +;; http://labb.contactor.se/~matsl/smoketest/logs/ +;; or newer results for miscompiled macros. +(eval-when-compile (require 'erc)) + (require 'cl); for defstruct (defvar erc-members (makehash 'eq) -- Adrian Aichner mailto:ad...@xe... http://www.xemacs.org/ |
|
From: Alex S. <al...@em...> - 2004-03-19 00:06:06
|
Jorgen Schaefer <fo...@fo...> writes: > I would apply this patch, but it's extensive, so we might need > copyright papers... I'm not very familar with this legalese, > kensanata, what do you say? > > If it's ok with you, i'll apply the patch. You know how it is... Apply patch first, ask questions later... Then wait for at least for years for answers... :) As long as we're not officially part of a GNU project, we're not in danger. But yes, eventually Adrian will have to sign papers. Unless he only fixed a typo; here in Switzerland you can't claim copyright for fixing a typo... Alex. -- .O. http://www.emacswiki.org/alex/ ..O Schroeder's fourth law: OOO None of your friends and coworkers share your taste in music. |
|
From: Adrian A. <ad...@xe...> - 2004-03-18 23:38:01
|
I messed up my first try real bad:
Instead of adding the message-id of Kyle's followup to a references
mail header, I used it as the message-id of my mail!
This is probably why my mail has not shown up in the
gmane.emacs.erc.general newsgroup.
I hope I'll get it right this time ...
SUPERSEDES <1xo...@sm...>
Following Kyle's advice, this patch will make XEmacs use the three
argument version should that become available in a future version of
XEmacs.
erc developers, please review and send me your approval.
I will then try to commit this little patch myself.
Best regards,
Adrian
ChangeLog addition:
2004-03-18 Adrian Aichner <ad...@xe...>
* erc-nets.el: Use two arguments version of `make-obsolete', if
third argument is not supported (for XEmacs).
erc source patch:
Diff command: cvs -f -z3 -q diff -u -N
Files affected: erc-nets.el
Index: erc-nets.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-nets.el,v
retrieving revision 1.11
diff -u -r1.11 erc-nets.el
--- erc-nets.el 13 Mar 2004 14:04:08 -0000 1.11
+++ erc-nets.el 18 Mar 2004 21:53:37 -0000
@@ -712,9 +712,9 @@
(with-current-buffer (erc-server-buffer)
(intern (downcase (symbol-name erc-network)))))
-(if (featurep 'xemacs)
- (make-obsolete 'erc-current-network 'erc-network)
- (make-obsolete 'erc-current-network 'erc-network "Obsolete since erc-nets 1.5"))
+(condition-case nil
+ (make-obsolete 'erc-current-network 'erc-network "Obsolete since erc-nets 1.5")
+ (wrong-number-of-arguments (make-obsolete 'erc-current-network 'erc-network)))
(defun erc-network-name ()
"Returns the name of the current network as a string."
@@ -724,9 +724,9 @@
;; returns the name of the current network as a string. Some of us use these
;; functions in our personal ERC configuration code. (franl, 2004-03-13)
;;
-;;(if (featurep 'xemacs)
-;; (make-obsolete 'erc-network-name 'erc-network)
-;; (make-obsolete 'erc-network-name 'erc-network "Obsolete since erc-nets 1.5"))
+;;(condition-case nil
+;; (make-obsolete 'erc-network-name 'erc-network "Obsolete since erc-nets 1.5")
+;; (wrong-number-of-arguments (make-obsolete 'erc-network-name 'erc-network)))
(defun erc-set-network-name (proc parsed)
"Set `erc-network' to the value returned by `erc-determine-network'."
--
Adrian Aichner
mailto:ad...@xe...
http://www.xemacs.org/
|
|
From: Andreas F. <as...@bo...> - 2004-03-18 22:00:19
|
On 2004-03-14, Adrian Aichner <Adr...@t-...> wrote: > > Hi! > > I stumbled across one or two mis-typed variable references in > docstrings, so I decided to spell-check erc. > > Here is the result. As kensanata approves of the patch (he does in my IRC logs, at least (-:), I applied it (save for the one conflict that an already-present spelink fix generated). Thank you, -- Andreas Fuchs, <as...@bo...>, as...@ja..., antifuchs |
|
From: Jorgen S. <fo...@fo...> - 2004-03-17 00:56:29
|
Adrian Aichner <Adr...@t-...> writes:
> Hi!
>
> I stumbled across one or two mis-typed variable references in
> docstrings, so I decided to spell-check erc.
>
> Here is the result.
That's great!
Thank you a lot! (and sorry for the delay)
I would apply this patch, but it's extensive, so we might need
copyright papers... I'm not very familar with this legalese,
kensanata, what do you say?
If it's ok with you, i'll apply the patch.
Greetings,
-- Jorgen
--
((email . "fo...@fo...") (www . "http://www.forcix.cx/")
(gpg . "1024D/028AF63C") (irc . "nick forcer on IRCnet"))
|
|
From: Adrian A. <ad...@xe...> - 2004-03-17 00:36:09
|
Hi erc developers, please let me know if there are any issues with this patch. I can easily create a superseding patch addressing any of them. Best regards, Adrian -- Adrian Aichner mailto:ad...@xe... http://www.xemacs.org/ |
|
From: Adrian A. <Adr...@t-...> - 2004-03-14 20:00:16
|
Hi!
I stumbled across one or two mis-typed variable references in
docstrings, so I decided to spell-check erc.
Here is the result.
Most problematic is the change of
erc-coding-sytem-for-target
to
erc-coding-system-for-target
Do you want a defalias to go along with that for bugward
compatibility?
A general question: Is erc standardizing on American or British
spelling or does anyone care ;->
I left alone "behaviour" and "...ise" vs. "...ize".
Would be great if this patch could be applied.
I have not sneaked anything else into this patch.
A make-obsolete xemacs compatibility patch is still on my todo list.
I don't know how much of the detailed ChangeLog you want to include in
the commit message, but here it is anyway:
The
* erc.el (erc-coding-sytem-for-target): Removed.
* erc.el (erc-coding-system-for-target): New.
bit is most important.
Best regards,
Adrian
2004-03-14 Adrian Aichner <ad...@xe...>
* erc-autoaway.el (erc-autoaway-use-emacs-idle): Typo fix.
* erc-autoaway.el (erc-auto-set-away): Ditto.
* erc-autoaway.el (erc-auto-discard-away): Ditto.
* erc-autojoin.el (autojoin): Ditto.
* erc-button.el: Ditto.
* erc-button.el (erc-button-alist): Ditto.
* erc-dcc.el (erc-dcc-auto-masks): Ditto.
* erc-dcc.el (erc-dcc-chat-send-input-line): Ditto.
* erc-ezbounce.el (erc-ezb-get-login): Ditto.
* erc-imenu.el (erc-unfill-notice): Ditto.
* erc-list.el: Ditto.
* erc-log.el (erc-save-buffer-in-logs): Ditto.
* erc-match.el (match): Ditto.
* erc-match.el (erc-log-matches-types-alist): Ditto.
* erc-match.el (erc-match-directed-at-fool-p): Ditto.
* erc-match.el (erc-match-message): Ditto.
* erc-members.el (erc-update-member): Ditto.
* erc-members.el (erc-ignored-reply-p): Ditto.
* erc-menu.el (erc-menu-definition): Ditto.
* erc-netsplit.el (erc-netsplit-QUIT): Ditto.
* erc-notify.el (erc-notify-list): Ditto.
* erc-speedbar.el (erc-speedbar-update-channel): Ditto.
* erc-speedbar.el (erc-speedbar-item-info): Ditto.
* erc-stamp.el (erc-stamp): Ditto.
* erc-stamp.el (erc-timestamp-intangible): Ditto.
* erc-stamp.el (erc-add-timestamp): Ditto.
* erc-stamp.el (erc-timestamp-only-if-changed-flag): Ditto.
* erc-stamp.el (erc-show-timestamps): Ditto.
* erc-track.el: Ditto.
* erc-track.el (erc-track-priority-faces-only): Ditto.
* erc-track.el (erc-modified-channels-alist): Ditto.
* erc-track.el (erc-unique-substrings): Ditto.
* erc-track.el (erc-find-parsed-property): Ditto.
* erc-track.el (erc-track-switch-direction): Ditto.
* erc-truncate.el (erc-truncate-buffer-to-size): Ditto.
* erc-xdcc.el (erc-xdcc): Ditto.
* erc.el (erc-auto-reconnect): Ditto.
* erc.el (erc-startup-file-list): Ditto.
* erc.el (erc-once-with-server-event): Ditto.
* erc.el (erc-once-with-server-event-global): Ditto.
* erc.el (erc-mode): Ditto.
* erc.el (erc-generate-new-buffer-name): Ditto.
* erc.el (erc): Ditto.
* erc.el (erc-open-ssl-stream): Ditto.
* erc.el (erc-default-coding-system): Ditto.
* erc.el (erc-coding-sytem-for-target): Removed.
* erc.el (erc-coding-system-for-target): New.
* erc.el (erc-encode-string-for-target): Ditto.
* erc.el (erc-decode-string-from-target): Ditto.
* erc.el (erc-scroll-to-bottom): Ditto.
* erc.el (erc-decode-controls): Ditto.
* erc.el (erc-channel-members-changed-hook): Ditto.
* erc.el (erc-put-text-property): Ditto.
* erc.el (erc-add-default-channel): Ditto.
erc source patch:
Diff command: cvs -f -z3 -q diff -u -N
Files affected: erc.el erc-xdcc.el erc-truncate.el erc-track.el erc-stamp.el erc-speedbar.el erc-notify.el erc-netsplit.el erc-menu.el erc-members.el erc-match.el erc-log.el erc-list.el erc-imenu.el erc-ezbounce.el erc-dcc.el erc-button.el erc-autojoin.el erc-autoaway.el
Index: erc-autoaway.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-autoaway.el,v
retrieving revision 1.13
diff -u -r1.13 erc-autoaway.el
--- erc-autoaway.el 28 Jan 2004 06:51:33 -0000 1.13
+++ erc-autoaway.el 14 Mar 2004 19:33:41 -0000
@@ -47,7 +47,7 @@
Note that using Emacs idletime is currently broken for most versions,
since process activity (as happens all the time on IRC) makes Emacs
-non-idle. Emacs idle-time and user idel-time are just not the same."
+non-idle. Emacs idle-time and user idle-time are just not the same."
:group 'erc-autoaway
:type 'boolean)
@@ -92,7 +92,7 @@
(defcustom erc-auto-set-away t
"*If non-nil, set away after `erc-autoaway-idle-seconds' seconds of idling.
ERC autoaway mode can set you away when you idle, and set you no
-longer away when you type something. This variable controls wether
+longer away when you type something. This variable controls whether
you will be set away when you idle. See `erc-auto-discard-away' for
the other half."
:group 'erc-autoaway
@@ -101,7 +101,7 @@
(defcustom erc-auto-discard-away t
"*If non-nil, sending anything when away automatically discards away state.
ERC autoaway mode can set you away when you idle, and set you no
-longer away when you type something. This variable controls wether
+longer away when you type something. This variable controls whether
you will be set no longer away when you type something. See
`erc-auto-set-away' for the other half."
:group 'erc-autoaway
Index: erc-autojoin.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-autojoin.el,v
retrieving revision 1.6
diff -u -r1.6 erc-autojoin.el
--- erc-autojoin.el 1 Sep 2003 01:20:39 -0000 1.6
+++ erc-autojoin.el 14 Mar 2004 19:33:41 -0000
@@ -44,7 +44,7 @@
;;;###autoload (autoload 'erc-autojoin-mode "erc-autojoin" nil t)
(define-erc-module autojoin nil
- "Makes ERC autjoin on connects and reconnects."
+ "Makes ERC autojoin on connects and reconnects."
((add-hook 'erc-after-connect 'erc-autojoin-channels)
(add-hook 'erc-server-JOIN-hook 'erc-autojoin-add)
(add-hook 'erc-server-PART-hook 'erc-autojoin-remove))
Index: erc-button.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-button.el,v
retrieving revision 1.50
diff -u -r1.50 erc-button.el
--- erc-button.el 28 Feb 2004 15:04:52 -0000 1.50
+++ erc-button.el 14 Mar 2004 19:33:42 -0000
@@ -163,7 +163,7 @@
strings, or an alist with the strings in the car. Note that
entries in lists or alists are considered to be nicks or other
complete words. Therefore they are enclosed in \\< and \\>
- while searching. REGEXP can also be the quoted symol
+ while searching. REGEXP can also be the quoted symbol
'nicknames, which matches the nickname of any user on the
current server.
Index: erc-dcc.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-dcc.el,v
retrieving revision 1.82
diff -u -r1.82 erc-dcc.el
--- erc-dcc.el 10 Mar 2004 17:30:10 -0000 1.82
+++ erc-dcc.el 14 Mar 2004 19:33:42 -0000
@@ -295,8 +295,8 @@
(defcustom erc-dcc-auto-masks nil
"List of regexps matching user identifiers whose DCC send offers should be
-accespted automatically. A user identifier has the form \"nick!login@host\".
-For instance, to accpet all incoming DCC send offers automatically, add the
+accepted automatically. A user identifier has the form \"nick!login@host\".
+For instance, to accept all incoming DCC send offers automatically, add the
string \".*!.*@.*\" to this list."
:group 'erc-dcc
:type '(repeat regexp))
@@ -974,7 +974,7 @@
(defun erc-dcc-chat-send-input-line (recipient line &optional force)
"Send LINE to the remote end.
-Argument RCIPIENT should always be the symbol dcc, and force
+Argument RECIPIENT should always be the symbol dcc, and force
is ignored."
;; FIXME: We need to get rid of all force arguments one day!
(if (eq recipient 'dcc)
Index: erc-ezbounce.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-ezbounce.el,v
retrieving revision 1.5
diff -u -r1.5 erc-ezbounce.el
--- erc-ezbounce.el 23 Feb 2004 21:01:36 -0000 1.5
+++ erc-ezbounce.el 14 Mar 2004 19:33:42 -0000
@@ -76,7 +76,7 @@
(defun erc-ezb-get-login (server port)
"Return an appropriate EZBounce login for SERVER and PORT.
Look up entries in `erc-ezb-login-alist'. If the username or password
-in the alist is `nil', prompt for the apropriate values."
+in the alist is `nil', prompt for the appropriate values."
(let ((login (cdr (assoc (cons server port) erc-ezb-login-alist))))
(when login
(let ((username (car login))
Index: erc-imenu.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-imenu.el,v
retrieving revision 1.5
diff -u -r1.5 erc-imenu.el
--- erc-imenu.el 7 Dec 2002 22:42:41 -0000 1.5
+++ erc-imenu.el 14 Mar 2004 19:33:42 -0000
@@ -50,7 +50,7 @@
(defun erc-unfill-notice ()
"Return text from point to a computed end as a string unfilled.
-Dont rely on this function, read it first!"
+Don't rely on this function, read it first!"
(let ((str (buffer-substring
(save-excursion
(re-search-forward (regexp-quote erc-notice-prefix)))
Index: erc-list.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-list.el,v
retrieving revision 1.23
diff -u -r1.23 erc-list.el
--- erc-list.el 10 Mar 2004 16:40:59 -0000 1.23
+++ erc-list.el 14 Mar 2004 19:33:42 -0000
@@ -1,4 +1,4 @@
-;;; erc-list.el --- Proivde a faster channel listing mechanism
+;;; erc-list.el --- Provide a faster channel listing mechanism
;; Copyright (C) 2002 Mario Lang
Index: erc-log.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-log.el,v
retrieving revision 1.11
diff -u -r1.11 erc-log.el
--- erc-log.el 12 Mar 2004 22:28:40 -0000 1.11
+++ erc-log.el 14 Mar 2004 19:33:43 -0000
@@ -299,7 +299,7 @@
(defun erc-save-buffer-in-logs (&optional buffer)
"Append BUFFER contents to the log file, if logging is enabled.
If BUFFER is not provided, current buffer is used.
-Logging is enabled if `erc-logging-enabbled' returns non-nil.
+Logging is enabled if `erc-logging-enabled' returns non-nil.
This is normally done on exit, to save the unsaved portion of the
buffer, since only the text that runs off the buffer limit is logged
Index: erc-match.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-match.el,v
retrieving revision 1.29
diff -u -r1.29 erc-match.el
--- erc-match.el 6 Mar 2004 15:15:09 -0000 1.29
+++ erc-match.el 14 Mar 2004 19:33:43 -0000
@@ -47,12 +47,12 @@
;;;###autoload (autoload 'erc-match-mode "erc-match")
(define-erc-module match nil
- "This mode checks wether messages match certain patterns. If so,
+ "This mode checks whether messages match certain patterns. If so,
they are hidden or highlighted. This is controlled via the variables
`erc-pals', `erc-fools', `erc-keywords', `erc-dangerous-hosts', and
-`erc-current-nick-highlight-type'. For all these hilighting types,
-you can decide wether the entire message or only the sending nick is
-hilighted."
+`erc-current-nick-highlight-type'. For all these highlighting types,
+you can decide whether the entire message or only the sending nick is
+highlighted."
((add-hook 'erc-insert-modify-hook 'erc-match-message))
((remove-hook 'erc-insert-modify-hook 'erc-match-message)))
@@ -174,7 +174,7 @@
- dangerous-host
- fool
-The other element of each cons pair in this lits is the buffer name to
+The other element of each cons pair in this list is the buffer name to
use for the logged message."
:group 'erc-match
:type '(repeat (cons (choice :tag "Key"
@@ -392,7 +392,7 @@
(erc-list-match erc-dangerous-hosts nickuserhost)))
(defun erc-match-directed-at-fool-p (msg)
- "Check wether MSG is directed at a fool.
+ "Check whether MSG is directed at a fool.
In order to do this, every entry in `erc-fools' will be used.
In any of the following situations, MSG is directed at an entry FOOL:
@@ -488,7 +488,7 @@
(erc-put-text-property
(point-min) (point-max)
'face match-face (current-buffer)))
- ;; Highlight all occurances of the word to be
+ ;; Highlight all occurrences of the word to be
;; highlighted.
((and (string= match-type "keyword")
(eq match-htype 'keyword))
@@ -505,7 +505,7 @@
(match-beginning 0) (match-end 0)
'face face))))
match-regex))
- ;; Highlight all occurances of our nick.
+ ;; Highlight all occurrences of our nick.
((and (string= match-type "current-nick")
(eq match-htype 'keyword))
(goto-char (+ 2 (or nick-end
Index: erc-members.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-members.el,v
retrieving revision 1.5
diff -u -r1.5 erc-members.el
--- erc-members.el 17 Apr 2003 14:21:09 -0000 1.5
+++ erc-members.el 14 Mar 2004 19:33:43 -0000
@@ -277,7 +277,7 @@
(unless erc-process
(error "No erc-process in %S" (current-buffer)))
(when (string= nick new-nick)
- (setq new-nick nil));; backwards compatiblity
+ (setq new-nick nil));; backwards compatibility
(let ((person (erc-person nick))
(erc-members-changed-hook nil));; call it only once
(erc-log (format "update-member: old %S" person))
@@ -412,7 +412,7 @@
(or (erc-person-host person) "")))
(defun erc-ignored-reply-p (message target process)
- "Send MESSSAGE to TARGET in PROCESS and maybe return return non-nil.
+ "Send MESSAGE to TARGET in PROCESS and maybe return return non-nil.
We return non-nil, when MESSAGE is addressed to an ignored user, ie. a user
matching any regexp in `erc-ignore-reply-list'."
(let ((target-nick (erc-message-target message)))
Index: erc-menu.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-menu.el,v
retrieving revision 1.12
diff -u -r1.12 erc-menu.el
--- erc-menu.el 1 Mar 2004 16:39:13 -0000 1.12
+++ erc-menu.el 14 Mar 2004 19:33:43 -0000
@@ -43,7 +43,7 @@
(erc-channel-user-op-p (erc-current-nick)))]
(list "Channel modes"
["Change mode..." erc-insert-mode-command
- (erc-channel-user-op-p (erc-current-nicK))]
+ (erc-channel-user-op-p (erc-current-nick))]
["No external send" (erc-toggle-channel-mode "n")
:active (erc-channel-user-op-p (erc-current-nick))
:style toggle :selected (member "n" channel-modes)]
Index: erc-netsplit.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-netsplit.el,v
retrieving revision 1.8
diff -u -r1.8 erc-netsplit.el
--- erc-netsplit.el 16 Jan 2003 15:48:30 -0000 1.8
+++ erc-netsplit.el 14 Mar 2004 19:33:43 -0000
@@ -151,7 +151,7 @@
(setcdr (nthcdr 2 ass) (cons nick (nthcdr 3 ass)))
(when (caddr ass)
;; There was already a netjoin for this netsplit, it
- ;; seems like the old one didnt get finished...
+ ;; seems like the old one didn't get finished...
(erc-display-message
parsed 'notice (process-buffer proc)
'netsplit ?s split)
Index: erc-notify.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-notify.el,v
retrieving revision 1.23
diff -u -r1.23 erc-notify.el
--- erc-notify.el 10 Mar 2004 00:10:59 -0000 1.23
+++ erc-notify.el 14 Mar 2004 19:33:43 -0000
@@ -39,7 +39,7 @@
:group 'erc)
(defcustom erc-notify-list nil
- "*List of nicknames you want to be notificated about online/offline status change."
+ "*List of nicknames you want to be notified about online/offline status change."
:group 'erc-notify
:type '(repeat string))
Index: erc-speedbar.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-speedbar.el,v
retrieving revision 1.12
diff -u -r1.12 erc-speedbar.el
--- erc-speedbar.el 28 Jan 2004 06:51:33 -0000 1.12
+++ erc-speedbar.el 14 Mar 2004 19:33:43 -0000
@@ -223,8 +223,8 @@
(defun erc-speedbar-update-channel (buffer)
"Update the speedbar information about a ERC buffer. The update
-is only done when the channel is acutally expanded already."
- ;; This is only a rude hack and doesnt care about multiserver usage
+is only done when the channel is actually expanded already."
+ ;; This is only a rude hack and doesn't care about multiserver usage
;; yet, consider this a brain storming, better ideas?
(with-current-buffer speedbar-buffer
(save-excursion
@@ -288,7 +288,7 @@
(buffer-substring-no-properties (point) (point-at-eol))))
(defun erc-speedbar-item-info ()
- "Display informatin about the current buffer on the current line."
+ "Display information about the current buffer on the current line."
(let ((data (speedbar-line-token))
(txt (erc-speedbar-line-text)))
(cond ((and data (listp data))
Index: erc-stamp.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-stamp.el,v
retrieving revision 1.32
diff -u -r1.32 erc-stamp.el
--- erc-stamp.el 23 Feb 2004 21:01:36 -0000 1.32
+++ erc-stamp.el 14 Mar 2004 19:33:44 -0000
@@ -46,7 +46,7 @@
of timestamp information in `erc-mode' buffer.
For timestamping to be activated, you just need to load `erc-stamp'
-in your .emacs file or ineractively using `load-library'."
+in your .emacs file or interactively using `load-library'."
:group 'erc)
(defcustom erc-timestamp-format "[%H:%M]"
@@ -115,7 +115,7 @@
:type 'string)
(defcustom erc-timestamp-intangible t
- "*Wether the timestamps should be intangible, i.e. prevent the point
+ "*Whether the timestamps should be intangible, i.e. prevent the point
from entering them and instead jump over them."
:group 'erc-stamp
:type 'string)
@@ -137,7 +137,7 @@
(defun erc-add-timestamp ()
"Add timestamp and text-properties to message.
-This function is ment to be called from `erc-insert-modify-hook'
+This function is meant to be called from `erc-insert-modify-hook'
or `erc-send-modify-hook'."
(let ((ct (current-time)))
(if (fboundp erc-insert-timestamp-function)
@@ -166,7 +166,7 @@
(defcustom erc-timestamp-only-if-changed-flag t
"*Insert only if timestamp actually changed since last insertion.
-This only works with `erc-timestamp-rgiht'."
+This only works with `erc-timestamp-right'."
:group 'erc-stamp
:type 'boolean)
@@ -264,7 +264,7 @@
(erc-munge-invisibility-spec))
(defun erc-show-timestamps ()
- "Show timestamp ifnormation on display.
+ "Show timestamp information on display.
This function only works if `erc-timestamp-format' was previously
set, and timestamping is already active."
(interactive)
Index: erc-track.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-track.el,v
retrieving revision 1.59
diff -u -r1.59 erc-track.el
--- erc-track.el 3 Mar 2004 15:48:20 -0000 1.59
+++ erc-track.el 14 Mar 2004 19:33:44 -0000
@@ -23,7 +23,7 @@
;;; Commentary:
-;; Highlights keywords and pals (friends), and hides or hilights fools
+;; Highlights keywords and pals (friends), and hides or highlights fools
;; (using a dark color). Add to your ~/.emacs:
;; (require 'erc-track)
@@ -145,7 +145,7 @@
this variable. You can set a list of channel name strings, so those
will be ignored while all other channels will be tracked as normal.
Other options are 'all, to apply this to all channels or nil, to disable
-thsi feature.
+this feature.
Note: If you have a lot of faces listed in erc-track-faces-priority-list,
setting this variable might not be very useful."
:group 'erc-track
@@ -166,7 +166,7 @@
when displaying the buffer's name. See `erc-track-faces-priority-list',
and `erc-track-showcount'.
-Entries in this list should only happen for buffers where activity occured
+Entries in this list should only happen for buffers where activity occurred
while the buffer was not visible.")
;;; Shortening of names
@@ -256,7 +256,7 @@
;; do not shorten if a predicate exists and it returns nil
str
;; Start with smallest substring candidate, ie. length 1.
- ;; Then check all the others and see wether any of them starts
+ ;; Then check all the others and see whether any of them starts
;; with the same substring. While there is such another
;; element in the list, increase the length of the candidate.
(while (not done)
@@ -312,7 +312,7 @@
(erc-unique-channel-names
'("#linux-de" "#linux-fr")
'("#linux-de" "#linux-fr")))
- '("#linux-d" "#linux-f")); now we want to be agressive
+ '("#linux-d" "#linux-f")); now we want to be aggressive
;; specific problems
(equal (let ((erc-track-shorten-aggressively nil))
(erc-unique-channel-names
@@ -641,7 +641,7 @@
(erc-faces-in str)))
(defun erc-find-parsed-property ()
- "Find the next occurence of the `erc-parsed' text property."
+ "Find the next occurrence of the `erc-parsed' text property."
(let ((pos (point-min)))
(while (and pos (not (get-text-property pos 'erc-parsed)))
(setq pos (next-single-property-change pos 'erc-parsed)))
@@ -670,7 +670,7 @@
"Direction `erc-track-switch-buffer' should switch.
'oldest will find the oldest active buffer.
'newest finds the latest, 'leastactive finds buffer with least unseen messages,
-'mostactive - with most unseeen messages."
+'mostactive - with most unseen messages."
:group 'erc-track
:type '(choice (const oldest) (const newest) (const leastactive) (const mostactive)))
Index: erc-truncate.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-truncate.el,v
retrieving revision 1.3
diff -u -r1.3 erc-truncate.el
--- erc-truncate.el 1 May 2003 21:10:48 -0000 1.3
+++ erc-truncate.el 14 Mar 2004 19:33:44 -0000
@@ -52,7 +52,7 @@
(defun erc-truncate-buffer-to-size (size &optional buffer)
"Truncates the buffer to the size SIZE.
If BUFFER is not provided, the current buffer is assumed. The deleted
-region is logged if `erc-logging-enabbled' returns non-nil."
+region is logged if `erc-logging-enabled' returns non-nil."
;; If buffer is non-nil, but get-buffer does not return anything,
;; then this is a bug. If buffer is a buffer name, get the buffer
;; object. If buffer is nil, use the current buffer.
Index: erc-xdcc.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-xdcc.el,v
retrieving revision 1.6
diff -u -r1.6 erc-xdcc.el
--- erc-xdcc.el 10 Sep 2003 18:39:22 -0000 1.6
+++ erc-xdcc.el 14 Mar 2004 19:33:44 -0000
@@ -87,7 +87,7 @@
(funcall handler proc nick login host (cdr args))
(erc-xdcc-reply
proc nick
- (format "Unknwon XDCC sub-command, try \"/ctcp %s XDCC help\""
+ (format "Unknown XDCC sub-command, try \"/ctcp %s XDCC help\""
(erc-current-nick))))))
(defun erc-xdcc-help (proc nick login host args)
Index: erc.el
===================================================================
RCS file: /cvsroot/erc/erc/erc.el,v
retrieving revision 1.638
diff -u -r1.638 erc.el
--- erc.el 12 Mar 2004 22:42:03 -0000 1.638
+++ erc.el 14 Mar 2004 19:33:52 -0000
@@ -709,7 +709,7 @@
:type 'boolean)
(defcustom erc-auto-reconnect t
- "Non-nil means that ERC will attempt to restablish broken connections.
+ "Non-nil means that ERC will attempt to reestablish broken connections.
Reconnection will happen automatically for any unexpected disconnection."
:group 'erc
@@ -774,7 +774,7 @@
(defcustom erc-startup-file-list
'("~/.ercrc.el" "~/.ercrc" ".ercrc.el" ".ercrc")
"List of files to try for a startup script.
-The first existant and readable one will get executed.
+The first existent and readable one will get executed.
If the filename ends with `.el' it is presumed to be an emacs-lisp
script and it gets (load)ed. Otherwise is is treated as a bunch of
@@ -1324,7 +1324,7 @@
event)
(t
(error
- "EVENT should be a symbol or a numer")))
+ "EVENT should be a symbol or a number")))
"-hook"))
(defun erc-event-to-hook (event)
@@ -1338,7 +1338,7 @@
You should make sure that `current-buffer' is a server buffer.
-This function temporarily adds a functon to EVENT's hook to
+This function temporarily adds a function to EVENT's hook to
execute FORMS. After FORMS are run, the function is removed from
EVENT's hook. The last expression of FORMS should be either nil
or t. nil indicates that the other functions on EVENT's hook
@@ -1366,7 +1366,7 @@
(defun erc-once-with-server-event-global (event &rest forms)
"Execute FORMS the next time EVENT occurs in any server buffer.
-This function temporarily prepends a functon to EVENT's hook to
+This function temporarily prepends a function to EVENT's hook to
execute FORMS. After FORMS are run, the function is removed from
EVENT's hook. The last expression of FORMS should be either nil
or t. nil indicates that the other functions on EVENT's hook
@@ -1478,7 +1478,7 @@
;; This seems to work only in CVS emacs. "GNU Emacs 21.2.2" has
;; problems with this:
;; (string-match "[^ ]" "foo bar") returns nil.
- ;; And XEmacs doesnt have set-case-syntax-pair :(...
+ ;; And XEmacs doesn't have set-case-syntax-pair :(...
;; (when (and (>= emacs-major-version 21)
;; (>= emacs-minor-version 3))
;; (set-case-table
@@ -1621,7 +1621,7 @@
(or (let ((name (concat server ":" port)))
(when (> (length name) 1)
name))
- ; This fallback should infact never happen
+ ; This fallback should in fact never happen
"*erc-server-buffer*"))))
;; Reuse existing buffers, but not if the buffer is a connected server
;; buffer and not if its associated with a different server than the
@@ -1943,7 +1943,7 @@
non-nil, connect to the server. Otherwise assume already
connected and just create a separate buffer for the new target
CHANNEL. Use PASSWD as user password on the server. If TGT-LIST
-is non-nil, use it to initialise `erc-default-recipiets'.
+is non-nil, use it to initialise `erc-default-recipients'.
Returns the buffer for the given server or channel."
(let ((announced-server-name (when (and (boundp 'erc-session-server)
@@ -1972,7 +1972,7 @@
(setq erc-process process)
(setq erc-insert-marker (make-marker))
(set-marker erc-insert-marker (point))
- ;; stack of default recepients
+ ;; stack of default recipients
(setq erc-default-recipients tgt-list)
;; stack for user's nicknames
(setq current-nick nil)
@@ -2149,7 +2149,7 @@
(let ((proc (open-ssl-stream name buffer host port)))
;; Ugly hack, but it works for now. Problem is it is
;; very hard to detect when ssl is established, because s_client
- ;; doesnt give any CONNECTIONESTABLISHED kind of message, and
+ ;; doesn't give any CONNECTIONESTABLISHED kind of message, and
;; most IRC servers send nothing and wait for you to identify.
(sit-for 5)
proc)))
@@ -2442,7 +2442,7 @@
If a function, it is called with no should return a coding system
or a cons as described above. Note that you can use the
dynamically bound variable `target' to get the current target.
-See `erc-coding-sytem-for-target'.
+See `erc-coding-system-for-target'.
If you need to send non-ASCII text to people not using a client that
does decoding on its own, you must tell ERC what encoding to use.
@@ -2467,7 +2467,7 @@
:type '(repeat (cons (string :tag "Target")
coding-system)))
-(defun erc-coding-sytem-for-target (target)
+(defun erc-coding-system-for-target (target)
"Return the coding system or cons cell appropriate for TARGET.
This is determined via `erc-encoding-coding-alist' or
`erc-default-coding-system'."
@@ -2480,7 +2480,7 @@
"Encode STR as appropriate for TARGET.
This is indicated by `erc-encoding-coding-alist', defaulting to the value of
`erc-default-coding-system'."
- (let ((coding (erc-coding-sytem-for-target target)))
+ (let ((coding (erc-coding-system-for-target target)))
(when (consp coding)
(setq coding (car coding)))
(erc-encode-coding-string str coding)))
@@ -2489,7 +2489,7 @@
"Decode STR as appropriate for TARGET.
This is indicated by `erc-encoding-coding-alist', defaulting to the value of
`erc-default-coding-system'."
- (let ((coding (erc-coding-sytem-for-target target)))
+ (let ((coding (erc-coding-system-for-target target)))
(when (consp coding)
(setq coding (cdr coding)))
(erc-decode-coding-string str coding)))
@@ -2682,7 +2682,7 @@
DISPLAY-START is ignored."
(if (and window (window-live-p window))
- ;; Temporarilly bind resize-mini-windows to nil so that users who have it
+ ;; Temporarily bind resize-mini-windows to nil so that users who have it
;; set to a non-nil value will not suffer from premature minibuffer
;; shrinkage due to the below recenter call. I have no idea why this
;; works, but it solves the problem, and has no negative side effects.
@@ -3892,7 +3892,7 @@
inv (get-text-property pos 'erc-inv line))
(setq next-pos (next-property-change pos line))
;; put "end of color" only if not at the beginning of line,
- ;; and the color was on. Also put it if the bg color dissapeared
+ ;; and the color was on. Also put it if the bg color disappeared
(if (or (and col (not fg) (not bg) (/= pos 0))
(and (not bg) bg0))
(setq res (concat res "\C-c")))
@@ -5928,7 +5928,7 @@
(run-hooks 'erc-channel-members-changed-hook)))
(defcustom erc-channel-members-changed-hook nil
- "*This hook is called everytime the variable `channel-members' changes.
+ "*This hook is called every time the variable `channel-members' changes.
The buffer where the change happened is current while this hook is called."
:group 'erc-hooks
:type 'hook)
@@ -6422,7 +6422,7 @@
OBJECT is a string which will be modified and returned.
OBJECT is modified without being copied first.
-You can redefine or `defavice' this function in order to add
+You can redefine or `defadvice' this function in order to add
EmacsSpeak support."
(put-text-property start end property value object))
@@ -6677,7 +6677,7 @@
;;; This is no longer true. The channel is added to another window
;;; and we don't want to mess the target there.
;"If the current default
-;recepient is of QUERY type, then push the new default channel *after*
+;recipient is of QUERY type, then push the new default channel *after*
;the head"
(let ((d1 (car erc-default-recipients))
--
Adrian Aichner
mailto:ad...@xe...
http://www.xemacs.org/
|
|
From: Simon S. <si...@tr...> - 2004-03-14 18:21:00
|
Hi there! I already added a note about a bug regarding timestamps to the EmacsWiki. When timestamps are on the left, filling produced too long lines. I tried to correct erc-fill-variable and erc-fill-static. While doing this I created a few helper functions. I deleted erc-count-lines which was only used in erc-fill-static and has become superfluous. So long, ... |
|
From: thomas w. <3....@gm...> - 2004-03-14 17:07:08
|
On Sun, 14 Mar 2004 16:39:51 +0000, Lawrence Mitchell wrote: > thomas weidner wrote: > >> i noticed ERC only handles op and voice as usermodes and nick prefixes. >> AFAIK this is correct as they are the only ones mentioned in the RFC, but >> many chatnetworks define aditional prefixes. some networks i use even >> define 5! The server correctly reports 'PREFIX=(qaohv)*!@%+" >> (founder,admin,op,half-op,voice). It whould be really nice it ERC had >> support for these additional modes either hardcoded or by parsing the >> PREFIX option. Is this wanted,does someone work on it/is willing to work >> on it? > > This /should/ be relatively simple to add. However, it's > difficult to know what to do with non-standard prefixes, since > they're only informally specified. The thing to do is to modify > the erc-channel-user struct to support more usermodes, and then > modify the parsing in erc-update-modes to match more different > modes. Do you have any examples where recognising these extra > usermodes is useful? Some nick related functions are broken when they show up. For example ERC thinks %Thomas is my nick (Thomas is % is for half-op) so nick completition for Thomas does not work and QUIT messages do not show up in the right channel but in the server window, other things might be broken, too. |
|
From: Lawrence M. <we...@gm...> - 2004-03-14 16:39:58
|
thomas weidner wrote: > i noticed ERC only handles op and voice as usermodes and nick prefixes. > AFAIK this is correct as they are the only ones mentioned in the RFC, but > many chatnetworks define aditional prefixes. some networks i use even > define 5! The server correctly reports 'PREFIX=(qaohv)*!@%+" > (founder,admin,op,half-op,voice). It whould be really nice it ERC had > support for these additional modes either hardcoded or by parsing the > PREFIX option. Is this wanted,does someone work on it/is willing to work > on it? This /should/ be relatively simple to add. However, it's difficult to know what to do with non-standard prefixes, since they're only informally specified. The thing to do is to modify the erc-channel-user struct to support more usermodes, and then modify the parsing in erc-update-modes to match more different modes. Do you have any examples where recognising these extra usermodes is useful? -- Lawrence Mitchell <we...@gm...> |
|
From: thomas w. <3....@gm...> - 2004-03-14 15:50:08
|
Hi, i noticed ERC only handles op and voice as usermodes and nick prefixes. AFAIK this is correct as they are the only ones mentioned in the RFC, but many chatnetworks define aditional prefixes. some networks i use even define 5! The server correctly reports 'PREFIX=(qaohv)*!@%+" (founder,admin,op,half-op,voice). It whould be really nice it ERC had support for these additional modes either hardcoded or by parsing the PREFIX option. Is this wanted,does someone work on it/is willing to work on it? thx in advance Thomas |
|
From: Adrian A. <ad...@xe...> - 2004-03-13 12:10:12
|
>>>>> "Kyle" == Kyle Jones <kyl...@wo...> writes:
Kyle> Adrian Aichner writes:
>> +(if (featurep 'xemacs)
>> + (make-obsolete 'erc-current-network 'erc-network)
>> + (make-obsolete 'erc-current-network 'erc-network "Obsolete since erc-nets 1.5"))
Kyle> This is better written as
Kyle> (condition-case nil
Kyle> (make-obsolete 'erc-current-network 'erc-network "Obsolete since erc-nets 1.5")
Kyle> (wrong-number-of-arguments (make-obsolete 'erc-current-network 'erc-network)))
Kyle> This way if XEmacs syncs to the three arg version, the code will
Kyle> automatically start using the extra arg.
Hi Kyle, you're right of course.
I'll follow up with a patch.
It's been good to read you again!
Take care[1],
Adrian
Kyle> -------------------------------------------------------
Kyle> This SF.Net email is sponsored by: IBM Linux Tutorials
Kyle> Free Linux tutorial presented by Daniel Robbins, President and CEO of
Kyle> GenToo technologies. Learn everything from fundamentals to system
Kyle> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
Footnotes:
[1] Do real people actually still use this phrase? ;->
--
Adrian Aichner
mailto:ad...@xe...
http://www.xemacs.org/
|
|
From: Kyle J. <kyl...@wo...> - 2004-03-11 19:00:33
|
Adrian Aichner writes:
> +(if (featurep 'xemacs)
> + (make-obsolete 'erc-current-network 'erc-network)
> + (make-obsolete 'erc-current-network 'erc-network "Obsolete since erc-nets 1.5"))
This is better written as
(condition-case nil
(make-obsolete 'erc-current-network 'erc-network "Obsolete since erc-nets 1.5")
(wrong-number-of-arguments (make-obsolete 'erc-current-network 'erc-network)))
This way if XEmacs syncs to the three arg version, the code will
automatically start using the extra arg.
|
|
From: Lawrence M. <we...@gm...> - 2004-03-11 18:43:51
|
Alex Schroeder wrote: > Lawrence Mitchell <we...@gm...> writes: >> Perhaps it would be a good idea if we actually started producing >> a proper changelog, rather than constructing it from cvs log >> entries. It would then be possible just to check out the >> changelog and see what's happened. What do people think about >> this? > The ChangeLog file will be huge, and slow to commit... There's no reason we can't split the ChangeLog file. Currently, the generated ChangeLog file is c. 200K, which doesn't seem horrendously large to me. However, I'll defer to others on this point. I don't, however, think that the ChangeLog being large is a particularly good reason to not maintain one. > Are you sure we cannot setup some sort of notification? > Somebody should read the Savannah docs... :D Reading the sourceforge docs, it would appear that we can use their syncmail script to send mails to, say, an erc-commits list. If people think this is a good idea, I can try and set it up. Lawrence (still wanting a changelog :) -- Lawrence Mitchell <we...@gm...> |
|
From: Adrian A. <ad...@xe...> - 2004-03-11 01:46:09
|
>>>>> " " == Damien Elmes <da...@re...> writes:
> Adrian Aichner <ad...@xe...> writes:
>> Hello erc developers!
>>
>> Would be great if you could incorporate this XEmacs compatibility
>> patch to keep the XEmacs package diffs as minimal as they currently
>> are (synced up to erc 4.0 1.637).
> Thanks, Adrian. Commited.
Great, thanks Damien!
Two runs of M-x cvs-update confirm that my changes are in your CVS.
XEmacs CVS also has the synced up erc sources already.
Adrian
> Cheers,
> --
> Damien Elmes
--
Adrian Aichner
mailto:ad...@xe...
http://www.xemacs.org/
|
|
From: Damien E. <da...@re...> - 2004-03-11 01:22:30
|
Adrian Aichner <ad...@xe...> writes: > Hello erc developers! > > Would be great if you could incorporate this XEmacs compatibility > patch to keep the XEmacs package diffs as minimal as they currently > are (synced up to erc 4.0 1.637). Thanks, Adrian. Commited. Cheers, -- Damien Elmes |
|
From: Alex S. <al...@em...> - 2004-03-11 01:13:58
|
Lawrence Mitchell <we...@gm...> writes: > Perhaps it would be a good idea if we actually started producing > a proper changelog, rather than constructing it from cvs log > entries. It would then be possible just to check out the > changelog and see what's happened. What do people think about > this? The ChangeLog file will be huge, and slow to commit... Are you sure we cannot setup some sort of notification? Somebody should read the Savannah docs... :D Alex. -- .O. http://www.emacswiki.org/alex/ ..O Schroeder's fourth law: OOO None of your friends and coworkers share your taste in music. |
|
From: Adrian A. <ad...@xe...> - 2004-03-11 01:00:52
|
Hello erc developers!
Would be great if you could incorporate this XEmacs compatibility
patch to keep the XEmacs package diffs as minimal as they currently
are (synced up to erc 4.0 1.637).
Best regards,
Adrian
erc ChangeLog addition:
2004-03-11 Adrian Aichner <ad...@xe...>
* erc-nets.el: XEmacs make-obsolete only takes two arguments.
erc source patch:
Diff command: cvs -f -z3 -q diff -u -N
Files affected: erc-nets.el
Index: erc-nets.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-nets.el,v
retrieving revision 1.8
diff -u -r1.8 erc-nets.el
--- erc-nets.el 10 Mar 2004 18:15:41 -0000 1.8
+++ erc-nets.el 11 Mar 2004 00:27:55 -0000
@@ -712,14 +712,18 @@
(with-current-buffer (erc-server-buffer)
(intern (downcase (symbol-name erc-network)))))
-(make-obsolete 'erc-current-network 'erc-network "Obsolete since erc-nets 1.5")
+(if (featurep 'xemacs)
+ (make-obsolete 'erc-current-network 'erc-network)
+ (make-obsolete 'erc-current-network 'erc-network "Obsolete since erc-nets 1.5"))
(defun erc-network-name ()
"Deprecated. Use `erc-network' instead. Return the value of `erc-network'
as a string."
(with-current-buffer (erc-server-buffer) (symbol-name erc-network)))
-(make-obsolete 'erc-network-name 'erc-network "Obsolete since erc-nets 1.5")
+(if (featurep 'xemacs)
+ (make-obsolete 'erc-network-name 'erc-network)
+ (make-obsolete 'erc-network-name 'erc-network "Obsolete since erc-nets 1.5"))
(defun erc-set-network-name (proc parsed)
"Set `erc-network' to the value returned by `erc-determine-network'."
--
Adrian Aichner
mailto:ad...@xe...
http://www.xemacs.org/
|
|
From: <di...@us...> - 2004-03-09 05:02:09
|
Hi all, > erc-current-network has never really done the right thing for > most domains. The regex approach just doesn't cut it. While For all those needing to know which IRC network ERC is connected to, I hope to have made things easier. I've just commited changes to erc-nickserv.el, erc-nets.el, and erc.el that deal with determining which network the user is on, and I've applied Lawrence's patch to the new function `erc-determine-network' in erc-nets.el. (eq (erc-network) 'Network) is all you should need now for testing. To add a new network, use: (add-to-list 'erc-networks-alist '(Network "irc.server-name.net")) Users of ErcNickserv should note that we are using `erc-network-alist' instead of `erc-networks', which has been removed - note also that `erc-network-alist' has the format (NETWORK SERVER-NAME) and not (SERVER-NAME NETWORK) as you're used to. More details are in the CVS commit logs and in the files' documentation. I've tested this all pretty extensively and it's working fine for me, but if you have any problems or notice any bugs, let me know. -- disumu |
|
From: Damien E. <da...@re...> - 2004-03-09 00:26:55
|
Lawrence Mitchell <we...@gm...> writes: > erc-current-network has never really done the right thing for > most domains. The regex approach just doesn't cut it. While > I'm assured that, in fact, this is being worked on elsewhere, > what do people think of the following. We basically just walk > subdomains trying to find matches in erc-networks, and, if that > fails, return 'unknown. From my testing it appears to be a lot > more robust than any current efforts we have. Why not just loop through all nets in erc-networks, and for each net, check if the the net matches erc-announced-server-name tail - ie, match erc-announced-server-name against (concat net "$") This approach would avoid avoid needless nested repetitions (think assoc) Cheers, -- Damien Elmes |
|
From: Lawrence M. <we...@gm...> - 2004-03-08 23:36:37
|
erc-current-network has never really done the right thing for
most domains. The regex approach just doesn't cut it. While
I'm assured that, in fact, this is being worked on elsewhere,
what do people think of the following. We basically just walk
subdomains trying to find matches in erc-networks, and, if that
fails, return 'unknown. From my testing it appears to be a lot
more robust than any current efforts we have.
Index: erc-nickserv.el
===================================================================
RCS file: /cvsroot/erc/erc/erc-nickserv.el,v
retrieving revision 1.14
diff -u -r1.14 erc-nickserv.el
--- erc-nickserv.el 6 Mar 2004 09:11:14 -0000 1.14
+++ erc-nickserv.el 8 Mar 2004 23:09:36 -0000
@@ -221,16 +221,21 @@
(defun erc-current-network ()
"Parse the current server to determine the network, if possible"
- ;; get the last two parts of the server's domain
- ;; check which network it is by matching the last part of the domain
(when erc-announced-server-name
(if (string= erc-announced-server-name "anon.iip")
'iip
- (string-match "\\.\\([^.]+\\.[^.]+\\)$" erc-announced-server-name)
- (let* ((domain erc-announced-server-name)
- (server (downcase (match-string 1 domain)))
- (network (nth 1 (assoc server erc-networks))))
- (or network 'unknown)))))
+ (or (catch 'name
+ ;; Strip off repeated levels of subdomains trying to find
+ ;; a match in `erc-networks'.
+ (let ((server-name erc-announced-server-name))
+ (while (string-match "\\.\\([^.]+\\..*\\)$" server-name)
+ (let* ((domain server-name)
+ (server (downcase (match-string 1 domain)))
+ (network (nth 1 (assoc server erc-networks))))
+ (if network
+ (throw 'name network)
+ (setq server-name (match-string 1 domain)))))))
+ 'unknown))))
(provide 'erc-nickserv)
--
Lawrence Mitchell <we...@gm...>
|
|
From: Lawrence M. <we...@gm...> - 2004-03-08 23:09:18
|
Xavier Maillard wrote: > Hello, > just a quick question, is there a simple way for us to know what > changes are done into the CVS ? I mean sort of commit tracker as Emacs > has. Short of checking the cvs log for the modified files, I don't think there's much way of checking (you can use sourceforge's web interface to the cvs tree but it's a bit of a pain). Perhaps it would be a good idea if we actually started producing a proper changelog, rather than constructing it from cvs log entries. It would then be possible just to check out the changelog and see what's happened. What do people think about this? [...] -- Lawrence Mitchell <we...@gm...> |
|
From: Xavier M. <ze...@gn...> - 2004-03-08 21:07:37
|
Hello, just a quick question, is there a simple way for us to know what changes are done into the CVS ? I mean sort of commit tracker as Emacs has. I definetely love to know about changes and wether it is interesting to upgrade my software. Regards, zeDek -- Hacker Wonderland Xavier Maillard| "Stand Back! I'm a programmer!" .0. ze...@gn...| ..0 (+33) 326 770 221 | Webmaster, emacsfr.org 000 PGP : 0x1E028EA5 | Membre de l' APRIL |
|
From: Alex S. <al...@em...> - 2004-03-07 14:09:04
|
I think the defcustoms could use an :options keyword to offer the
functions as suggestions. Here is an example:
(defcustom erc-echo-notice-always-hook
'(erc-echo-notice-in-default-buffer)
"*Specifies a list of functions to call to echo a private
notice. Each function is called with four arguments, the string
to display, the parsed server message, the target buffer (or
nil), and the sender. The functions are called in order, and all
functions are called."
:options '(erc-echo-notice-hook
erc-echo-notice-in-default-buffer
erc-echo-notice-in-target-buffer
erc-echo-notice-in-minibuffer
erc-echo-notice-in-server-buffer
erc-echo-notice-in-active-non-server-buffer
erc-echo-notice-in-active-buffer
erc-echo-notice-in-user-buffers
erc-echo-notice-in-user-and-target-buffers
erc-echo-notice-in-first-user-buffer)
:group 'erc-hooks
:type 'hook)
The info from the elisp manual which seems to indicate that this is
the correct solution for these kinds of problems:
`hook'
The value must be a list of functions (or a single function, but
that is obsolete usage). This customization type is used for hook
variables. You can use the `:options' keyword in a hook variable's
`defcustom' to specify a list of functions recommended for use in
the hook; see *Note Variable Definitions::.
and...
`:options LIST'
Specify LIST as the list of reasonable values for use in this
option. The user is not restricted to using only these values,
but they are offered as convenient alternatives.
This is meaningful only for certain types, currently including
`hook', `plist' and `alist'. See the definition of the individual
types for a description of how to use `:options'.
Alex.
--
.O. http://www.emacswiki.org/alex/
..O Schroeder's fourth law:
OOO None of your friends and coworkers share your taste in music.
|
|
From: Jeremy Maitin-S. <jb...@at...> - 2004-03-07 07:44:05
|
Hello, I have replaced the existing rather limited private NOTICE output configuration system (namely, `erc-echo-notices-in-minibuffer-flag' and `erc-echo-notices-in-current-buffer') with a much more flexible hook system. Specifically, I have added two hooks, `erc-echo-notice-hook' and `erc-echo-notice-always-hook'. Both hooks are run when a NOTICE should be echoed to the user; the former is run using `run-hook-with-args-until-success', while the second is run using `run-hook-with-args'. I have also added a number of functions which can be used with this hook: `erc-echo-notice-in-default-buffer', `erc-echo-notice-in-target-buffer', `erc-echo-notice-in-minibuffer', `erc-echo-notice-in-server-buffer', `erc-echo-notice-in-active-non-server-buffer', `erc-echo-notice-in-active-buffer', `erc-echo-notice-in-user-buffers', `erc-echo-notice-in-user-and-target-buffers', `erc-echo-notice-in-first-user-buffer' These changes are available at: http://dev.gentoo.org/~jbms/erc-new-notice-handling.patch I will commit them if no one protests or suggests changes. -- Jeremy Maitin-Shepard |
197 messages has been excluded from this view by a project administrator.
