Re: [E-devel] edje_object_part_swallow_get broken in current master

[Amitesh S. <sin...@gm...>]

On Wed, Feb 15, 2017 at 9:48 PM, Gustavo Sverzut Barbieri
<bar...@gm...> wrote:
>
> On Wed, Feb 15, 2017 at 1:47 PM, Amitesh Singh <sin...@gm...> wrote:
> > Hey guys,
> >
> > edje_object_part_swallow_get() used to return subgroup object in an
> > edje till 1.16. It seems that the behavior is changed in current
> > master.
> >
> > Was it intentional? or missed it during efl interfaces development?
>
> bit more of context:
>
> he asked in #edevelop how to retrieve the Edje object associated with
> a part of type GROUP, which he need to feed some signals/events
> directly.
>
> I recalled swallow_get did that, maybe on purpose, maybe just happened
> to work since we used the same pointers internally.
>
> Amitesh tested and spotted it was a regression... I'm pretty sure I've
> used this in the past (otherwise I'd not remember about it), thus that
> may be the case for others and I don't see why we should block that
> behavior (call it a "bugfix" instead of a "regression") -- as he shows
> the patch is pretty simple.
>
Yeah, edje_object_part_swallow_get() returns subgroup object in EFL
1.16 and it did solve my problem and saved my day! :)
>
>


EFL 1.16 code:
EOLIAN Evas_Object *
_edje_object_part_swallow_get(Eo *obj EINA_UNUSED, Edje *ed, const char *part)
{
   Edje_Real_Part *rp;

   if ((!ed) || (!part)) return NULL;

   /* Need to recalc before providing the object. */
   _edje_recalc_do(ed);

   rp = _edje_real_part_recursive_get(&ed, part);
   if (!rp) return NULL;
   if ((rp->type != EDJE_RP_TYPE_SWALLOW) ||
       (!rp->typedata.swallow)) return NULL;

   return rp->typedata.swallow->swallowed_object;
}

rp->type for both swallow and group is EDJE_RP_TYPE_SWALLOW.


>
>
> --
> Gustavo Sverzut Barbieri
> --------------------------------------
> Mobile: +55 (16) 99354-9890
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> enlightenment-devel mailing list
> enl...@li...
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel