Re: [E-devel] [EGIT] [apps/ephoto] master 01/01: Ephoto: Save thumbnails in $HOME/.thumbnails

[Al P. <ne...@gm...>]

Just my two pence...

I reckon don't do that. Use:

$HOME/.cache/ephoto/thumbnails

On Mon, Aug 22, 2016 at 10:54 PM, Stephen Houston <smh...@gm...>
wrote:

> The concern here with XDG is portability. Feel free to discuss. And go.
>
> On Aug 22, 2016 4:49 PM, "thomasg" <th...@gs...> wrote:
>
> > On Mon, Aug 22, 2016 at 10:41 PM, Stephen okra Houston <
> > smh...@gm...> wrote:
> >
> >> okra pushed a commit to branch master.
> >>
> >> http://git.enlightenment.org/apps/ephoto.git/commit/?id=8134
> >> 71f9bd6048026b372b4b55b303a311d4335e
> >>
> >> commit 813471f9bd6048026b372b4b55b303a311d4335e
> >> Author: Stephen okra Houston <smh...@gm...>
> >> Date:   Mon Aug 22 15:41:28 2016 -0500
> >>
> >>     Ephoto: Save thumbnails in $HOME/.thumbnails
> >> ---
> >>  src/bin/ephoto_thumbnailer.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/src/bin/ephoto_thumbnailer.c b/src/bin/ephoto_thumbnailer.c
> >> index 0fe190e..3ea8709 100644
> >> --- a/src/bin/ephoto_thumbnailer.c
> >> +++ b/src/bin/ephoto_thumbnailer.c
> >> @@ -88,7 +88,7 @@ main(int argc,
> >>     ecore_file_init();
> >>     ecore_ipc_init();
> >>
> >> -   snprintf(_thumbdir, PATH_MAX, "%s/.config/ephoto/thumbnails",
> >> getenv("HOME"));
> >> +   snprintf(_thumbdir, PATH_MAX, "%s/.thumbnails", getenv("HOME"));
> >>     ecore_file_mkpath(_thumbdir);
> >>
> >>     if (_e_ipc_init()) ecore_main_loop_begin();
> >>
> >> --
> >>
> >>
> >>
> > Hi okra,
> >
> > I think it would be best here to comply to the existing XDG standard
> > regarding to thumbnail caching.
> > https://specifications.freedesktop.org/thumbnail-
> > spec/thumbnail-spec-latest.html#DIRECTORY
> > Basically just check if XDG_CACHE_HOME exists, if so put it there, else
> > keep it like you have it now.
> >
> > Regards,
> >
> > thomasg
> >
> ------------------------------------------------------------
> ------------------
> _______________________________________________
> enlightenment-devel mailing list
> enl...@li...
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>