Re: [e-users] graphical sudo and askpass replacement using efl?

[Davide A. <da...@gu...>]

2014-03-02 6:47 GMT+01:00 Jeff Hoogland <Jef...@li...>:

> Sorry for taking so long to get back on this. I've started work on esudo
> again and it works with the latest code here now ->
> https://github.com/JeffHoogland/esudo
>
> I've also been able to have it replace gksudo on an existing system
> successfully. Works fairly well.
>

Good work man, just two suggestions while browsing the esudo repo:

1. you are using the deprecated way of importing stuff from efl, your code
is relying on a compatibility layer that will be removed sooner or later.

You are using the python-efl-1.7 way of importing:
import ecore
import evas
import elementary

I suggest you to change to the new, more verbose, but much more efficient:
from efl.ecore import Exe, ECORE_EXE_PIPE_READ
from efl.evas import EVAS_HINT_EXPAND
from efl import elementary
from efl.elementary.window import Window
from efl.elementary.popup import Popup
...etc for each widget you use

This way you only import what is really needed.

If you really want to keep compatibility with python-efl 1.7 you can do:
try:
   ...new style imports
except ImportError:
   ...old style imports


2. I really dislike the way you (not)package python apps...I know that way
is simple for your distro but you are cutting out all the people (like me)
that don't create debs for everythings.
I suggest you to give a look at how Espionage is done using the standard
setup.py
git.enlightenment.org/apps/espionage.git
That is the normal way to package python apps.
Also note that in your way you are hard-linked to python2.7

cheers
davemds


>
>
> On Thu, Feb 6, 2014 at 8:18 AM, Vasiliy Tolstov <v.t...@se...>
> wrote:
>
> > 2014-02-06  <jef...@gm...>:
> > > Odd.I'll make a note to look into this this weekend.
> >
> >
> > Thanks!
> >
> > --
> > Vasiliy Tolstov,
> > e-mail: v.t...@se...
> > jabber: va...@se...
> >
> >
> >
> ------------------------------------------------------------------------------
> > Managing the Performance of Cloud-Based Applications
> > Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
> > Read the Whitepaper.
> >
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
> > _______________________________________________
> > enlightenment-users mailing list
> > enl...@li...
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-users
> >
>
>
>
> --
> ~Jeff Hoogland <http://jeffhoogland.com/>
> Thoughts on Technology <http://jeffhoogland.blogspot.com/>, Tech Blog
> Bodhi Linux <http://bodhilinux.com/>, Enlightenment for your Desktop
>
> ------------------------------------------------------------------------------
> Flow-based real-time traffic analytics software. Cisco certified tool.
> Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
> Customize your own dashboards, set traffic alerts and generate reports.
> Network behavioral analysis & security monitoring. All-in-one tool.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
> _______________________________________________
> enlightenment-users mailing list
> enl...@li...
> https://lists.sourceforge.net/lists/listinfo/enlightenment-users
>