Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_list/focus: @bugfix crashes with empty lists and unfocused elements.

[Daniel J. S. <seo...@gm...>]

On Fri, Feb 28, 2014 at 11:37 PM, Stefan Schmidt
<st...@da...>wrote:

> Hello.
>
> On Fri, 2014-02-28 at 21:06, Carsten Haitzler wrote:
> > On Fri, 28 Feb 2014 09:48:36 +0100 Stefan Schmidt <
> st...@da...>
> > said:
> >
> > > Hello.
> > >
> > > On Thu, 2014-02-27 at 20:57, Gustavo Sverzut Barbieri wrote:
> > > > barbieri pushed a commit to branch master.
> > > >
> > > >
> http://git.enlightenment.org/core/elementary.git/commit/?id=cfd4179ce7a052c685c1c03f9b98467456578dce
> > > >
> > > > commit cfd4179ce7a052c685c1c03f9b98467456578dce
> > > > Author: Gustavo Sverzut Barbieri <gus...@in...>
> > > > Date:   Fri Feb 28 01:46:13 2014 -0300
> > > >
> > > >     elm_list/focus: @bugfix crashes with empty lists and unfocused
> elements.
> > >
> > > Its nice to see that the @bugfix (@fix might be easier) and @feature
> > > tags are getting more use.
> > >
> > > Personally I would prefer if we could put them in the body of the
> > > commit message. Like the phab ticket id or the Coverity ID. My reason
> > > would be simply aesthetical as I looks ugly to have such tags in the
> > > oftenm already cramped summary line.
> > >
> > > Putting them in the body makes them available for tools and sacripts
> > > but does not waste space on the summary line or make them look ugly.
> > >
> > > regards
> > > Stefan Schmidt
> >
> > could you put these tags and sample usage in the wiki somewhere obvious?
> :) i
> > was looking yesterday and couldnt find them there, and i couldnt find
> the email
> > discussing them in my mailbox... so i guessed from memory.
>
> Done
>
> https://phab.enlightenment.org/w/git_practices/#commit-message
>
> Give it a read. Might need to get adapted when people are confused. It
> should capture everything we have more or less implicit right now.
>
>
Cool. It became a good reference :)
Thanks.

Daniel Juyung Seo (SeoZ)


> regards
> Stefan Schmidt
>
>
> ------------------------------------------------------------------------------
> Flow-based real-time traffic analytics software. Cisco certified tool.
> Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
> Customize your own dashboards, set traffic alerts and generate reports.
> Network behavioral analysis & security monitoring. All-in-one tool.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
> _______________________________________________
> enlightenment-devel mailing list
> enl...@li...
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>