From: Eoff, U. A <ull...@in...> - 2013-02-27 17:42:39
|
>-----Original Message----- >From: Iván Briano [mailto:sac...@gm...] >Sent: Wednesday, February 27, 2013 3:44 AM >To: Enlightenment developer list >Subject: Re: [E-devel] [PATCH core/elementary] configure.ac: Fix rev to work >outside of git tree too > >On Wed, Feb 27, 2013 at 8:00 AM, Tom Hacohen ><tom...@sa...> wrote: >> And anyway, the better solution would be to cd into "$srcdir" before >> issuing the git command, instead of just using 0. Please check my >> suggestions and see if they work for you, as everything "just works" for me. >> > >Pointless, you always generate configure in $srcdir and building out of source >will use that generated configure. >What he's doing, if I got it right, is an export of all source files >to some other dir >where not .git exists and then runs autogen.sh > Yes Ivan, that is exactly the case that this patch fixes. That is: git clone git://git.enlightenment.org/core/elementary cd elementary git checkout-index -a -f --prefix="../elementary-build/" cd ../elementary-build ./autogen.sh ... When the project was managed by subversion, I believe we just set "v_rev" to 0 in the similar case... so this patch just makes it work the way it used to. >> -- >> Tom. >> >> On 27/02/13 10:59, Tom Hacohen wrote: >>> Weird, are you sure it didn't work? >>> >>> I just tried building out of source (completely out of source) and it >>> works great. >>> >>> -- >>> Tom. >>> >>> On 26/02/13 10:16, Tom Hacohen wrote: >>>> Cool work, thanks. >>>> >>>> I actually use a build subdirectory so this works just fine for me. :) I >>>> think we should maybe try to properly fix it by executing this from the >>>> source dir... >>>> >>>> -- >>>> Tom. >>>> >>>> On 25/02/13 21:10, U. Artie Eoff wrote: >>>>> From: "U. Artie Eoff" <ull...@in...> >>>>> >>>>> When configuring the source outside of the git tree >>>>> (i.e. git checkout-index ...), 'git rev-list --count HEAD' >>>>> will fail. Thus, just set v_rev to 0 like we did when this >>>>> was an svn managed project. >>>>> >>>>> Signed-off-by: U. Artie Eoff <ull...@in...> >>>>> --- >>>>> configure.ac | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/configure.ac b/configure.ac >>>>> index e5647f2..494d0bf 100644 >>>>> --- a/configure.ac >>>>> +++ b/configure.ac >>>>> @@ -3,7 +3,7 @@ >>>>> m4_define([v_maj], [1]) >>>>> m4_define([v_min], [7]) >>>>> m4_define([v_mic], [99]) >>>>> -m4_define([v_rev], m4_esyscmd([git rev-list --count HEAD | tr -d >>>>> '\n']))dnl >>>>> +m4_define([v_rev], m4_esyscmd([(git rev-list --count HEAD >>>>> 2>/dev/null || echo 0) | tr -d '\n']))dnl >>>>> ##-- When released, remove the dnl on the below line >>>>> dnl m4_undefine([v_rev]) >>>>> ##-- When doing snapshots - change soname. remove dnl on below >line >>>>> >>>> >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> >>>> Everyone hates slow websites. So do we. >>>> Make your web apps faster with AppDynamics >>>> Download AppDynamics Lite for free today: >>>> http://p.sf.net/sfu/appdyn_d2d_feb >>>> _______________________________________________ >>>> enlightenment-devel mailing list >>>> enl...@li... >>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>>> >>> >> >> >> ------------------------------------------------------------------------------ >> Everyone hates slow websites. So do we. >> Make your web apps faster with AppDynamics >> Download AppDynamics Lite for free today: >> http://p.sf.net/sfu/appdyn_d2d_feb >> _______________________________________________ >> enlightenment-devel mailing list >> enl...@li... >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >------------------------------------------------------------------------------ >Everyone hates slow websites. So do we. >Make your web apps faster with AppDynamics >Download AppDynamics Lite for free today: >http://p.sf.net/sfu/appdyn_d2d_feb >_______________________________________________ >enlightenment-devel mailing list >enl...@li... >https://lists.sourceforge.net/lists/listinfo/enlightenment-devel |