From: Carsten H. (T. R. <ra...@ra...> - 2012-09-29 02:24:16
|
On Fri, 28 Sep 2012 13:15:22 +0200 Sebastian Dransfeld <sd...@ta...> said: > On 09/28/2012 12:28 PM, rustyBSD wrote: > > Le 28/09/2012 09:04, Carsten Haitzler (The Rasterman) a écrit : > >>> Can you please revert your changes ? > >> why? its better than the code that was there (your patch). your patch did > >> this: > >> > >> 1. find out size of file > >> 2. alloc memory for ENTIRE file > >> 3. fill buffer with random data or 0xff > >> 4. write whole buffer in 1 write call > >> 5. fsync the file > >> > >> this will be JUSt as slow and blocking as the code there now, except the > >> code now doesn't need as much memory. if it was a 2gb file u'd need 2gb of > >> ram or it'd fail. now it needs a fixed 64k. > >> > >> so why revert it? it's an improvement. > > You fucking don't understand what i told. > > > > I told that > > > > I HAVE ALREADY MADE A PATCH WHICH DOES A BETTER JOB > > THAN YOURS, AND THAT I'M JUST WAITING FOR VTORRI > > > > Isn't that fucking clear ? > > But why aren't the patches sent to the mailing list? There are others > than vtorri which can commit simple patches like these. indeed. there is no point getting upset when you send patches in private and hen magically expect everyone to know what patches you have sent to someone in private. this is what happens when you do that. everyone who forks efl or maintains any kind of branch privately has the exact same issues. just ask the profusion guys :) this is life when you don't do things in the public. someone will overwite what you are working on. :) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ra...@ra... |