Re: [E-devel] E SVN: mekius IN trunk/PROTO/emote: . src/bin src/lib src/lib/protocols/irc

[Nick H. <me...@me...>]

On Sat, 7 Jul 2012 21:41:48 +0100
Michael Blumenkrantz <mic...@gm...> wrote:

> On Sat, 7 Jul 2012 15:31:23 -0500
> Nick Hughart <me...@me...> wrote:
> 
> > On Sat, 7 Jul 2012 20:27:16 +0100
> > Michael Blumenkrantz <mic...@gm...> wrote:
> > 
> > > On Sat,  7 Jul 2012 12:10:51 -0700
> > > "Enlightenment SVN" <no-...@en...> wrote:
> > > 
> > > > Log:
> > > > Multiple improvements and some cleanup:
> > > >   
> > > >     * Switch channel/server text to use Evas textgrid instead
> > > >       of elm_entry.  This is of course missing a lot of nice
> > > >       things like scrolling, selection, colors, etc.  This
> > > >       is in the TODO.
> > > >     * Redesign the interface a bit.  Still not looking great,
> > > > but this is probably the next thing to work on.  It's on the
> > > > TODO.
> > > >     * IRC code no longer converts the utf8 to markup.  It just
> > > >       passes it directly to the frontend.  The frontend also
> > > >       must convert any text with markup to utf8 before sending
> > > >       to the library.
> > > >     * Removed some random printfs.  Incorporating Eina log
> > > >       is in the TODO.
> > > >     * Updated TODO to reflect the current state of things.
> > > >   
> > > >   There is a lot to do so any help would be appreciated.
> > > > Particularly I'd love some feedback on how bad the code is and
> > > > ways it can be improved.  I didn't check this code for memory
> > > > leaks as it's not really in a daily usable state yet.
> > > >   
> > > >   
> > > > 
> > > > Author:       mekius
> > > > Date:         2012-07-07 12:10:51 -0700 (Sat, 07 Jul 2012)
> > > > New Revision: 73456
> > > > Trac:         http://trac.enlightenment.org/e/changeset/73456
> > > > 
> > > > Modified:
> > > >   trunk/PROTO/emote/TODO trunk/PROTO/emote/src/bin/em_config.c
> > > > trunk/PROTO/emote/src/bin/em_gui.c
> > > > trunk/PROTO/emote/src/bin/em_gui.h
> > > > trunk/PROTO/emote/src/bin/main.c
> > > > trunk/PROTO/emote/src/lib/emote_event.c
> > > > trunk/PROTO/emote/src/lib/emote_protocol.c
> > > > trunk/PROTO/emote/src/lib/protocols/irc/irc.c
> > > > trunk/PROTO/emote/src/lib/protocols/irc/irc_parse.c 
> > > > 
> > > 
> > > * any reason you're not using eina_module ?
> > 
> > IIRC this code predated eina_module or we had reasons for not
> > using it at the time.  It's been awhile so I cannot recall.  The
> > actual exported functions for each protocol are fairly small as
> > most of the interface is implemented using ecore events.
> 
> imo you didn't use it because a certain someone working on it at the
> time hates eina for dubious reasons ;)

Well at the time I can't say I was a big fan either, but it is what it
is and that's the past.  Regardless, at the time we had other reasons
and it's not really important now as the interface is done and
working.  Given everything is done via events there isn't much chance
the external API for the protocol plugins will change.

> 
> >
> > > * I see a lot of calls to ecore_con_server_connected_get(); in
> > > general, any time you have to call this function you're probably
> > > doing something wrong
> > 
> > I think this was just a safeguard to ensure the connection was still
> > open.  Is there a callback that should be used instead when the
> > connection is lost?
> 
> ECORE_CON_EVENT_SERVER_DEL occurs whenever a connection is lost for
> any reason

Btw, why does ecore_con_server_connected_get do anything more than
check a flag?  My thought here is that we'd still have to check a flag,
it would just be locally stored and modified. 

>