Re: [E-devel] E SVN: discomfitor IN trunk/elementary: . src/lib

[Daniel J. S. <seo...@gm...>]

This won't work when you prepend genlist item continuously.
To test that I used timer with interval 0.5 and 1 sec.
Sometimes selected item stayed at the same position but sometimes
selected item scrolled out of the viewport.
Can you check that?
Thanks in advance.

Daniel Juyung Seo (SeoZ)

On Tue, May 29, 2012 at 7:25 PM, Enlightenment SVN
<no-...@en...> wrote:
> Log:
> genlist prepends no longer cause selected items to be autoscrolled out of the viewport
>
> Author:       discomfitor
> Date:         2012-05-29 03:25:55 -0700 (Tue, 29 May 2012)
> New Revision: 71500
> Trac:         http://trac.enlightenment.org/e/changeset/71500
>
> Modified:
>  trunk/elementary/ChangeLog trunk/elementary/src/lib/elm_genlist.c
>
> Modified: trunk/elementary/ChangeLog
> ===================================================================
> --- trunk/elementary/ChangeLog  2012-05-29 09:09:13 UTC (rev 71499)
> +++ trunk/elementary/ChangeLog  2012-05-29 10:25:55 UTC (rev 71500)
> @@ -115,3 +115,7 @@
>        * Made elm_object_focus_set() fall back to evbas_object_focus_set()
>          if the object is not an elm widget.
>
> +2012-05-29 Mike Blumenkrantz
> +
> +        * Prepending items to a genlist no longer causes the selected item to
> +          scroll out of the viewport
>
> Modified: trunk/elementary/src/lib/elm_genlist.c
> ===================================================================
> --- trunk/elementary/src/lib/elm_genlist.c      2012-05-29 09:09:13 UTC (rev 71499)
> +++ trunk/elementary/src/lib/elm_genlist.c      2012-05-29 10:25:55 UTC (rev 71500)
> @@ -4116,6 +4116,18 @@
>           }
>      }
>    if (showme) it->item->block->showme = EINA_TRUE;
> +   /* when prepending, move the scroller along with the first selected item to
> +    * create the illusion that we're watching the selected item
> +    * this prevents the selected item being scrolled off the viewport
> +    */
> +   if (wd->selected && it->item->before)
> +     {
> +        int y, h;
> +        it = wd->selected->data;
> +        elm_smart_scroller_child_pos_get(wd->scr, NULL, &y);
> +        evas_object_geometry_get(wd->pan_smart, NULL, NULL, NULL, &h);
> +        elm_smart_scroller_child_region_show(wd->scr, it->x + it->item->block->x, y + it->item->h, it->item->block->w, h);
> +     }
>  }
>
>  static int
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> enlightenment-svn mailing list
> enl...@li...
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn