Re: [E-devel] Elementary's new (internal) widget hierarchy

[Gustavo S. B. <bar...@pr...>]

On Mon, Apr 2, 2012 at 11:12 AM, Tom Hacohen <tom...@sa...> wrote:
> On 02/04/12 17:03, Gustavo Chaves wrote:
>> Hey :) Thank you for taking a look, Tom.
>
> No problem, I'm just sorry it took me so long to get around to it. :)
> This is very relevant to what I'm currently working on, and I'm glad to
> see the information you share.
>>
>> You're right. I'll try to summarize, with links to commits and code, the
>> most crucial changes, soon. I just don't want to do it right now cause I'm
>> tearing Elm's guts real hard yet, so just wait a little.
>
> I understand you completely, I was just explaining why I couldn't
> provide more feedback. I don't expect you to do all of that work,
> especially not promptly, or just for me. :)
>
> I think though that some stats about lines of code differences (if can
> be counted easily), and a graphical illustration of the new widget
> hierarchy would be great.

the graphics should come... I've asked it since the beginning, but it
changed a bit and then glima hold it for a while until it settles.

the lines of change/diff do not help much to understand, as he did not
try to keep smaller diffs, then there is much noise.

What is worth to say is for example things that inherit from layout,
are reduced a lot. Before the code had to keep individual information
itself (button kept icon and label, ...), but the general pattern was
in layout! Then all of this is gone, using the base (elm_layout) code
instead of replicating it elsewhere.

As he said, not everything is coming at a single go. When we reach
some widgets with unexpected/unhandled behavior, we need to go back
and think, maybe change some things. Some we're holding for future
analysis, like making a single "size_eval" for layouts, nothing is
clear about it now.

The way I'd recommend you to look at it is not diffs, but the final
code for widget, layout and a subclass (ie: frame). Then you'll have a
clear view of the final state, if it makes sense, etc.
   Then you can go to review patches. At least that's the way I'm
doing and after some reviews we agree it's good enough, that's why it
was published :-)

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: bar...@gm...
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202