Re: [E-devel] E SVN: yoz IN trunk/eet: . src/lib

[Michael B. <mic...@gm...>]

On Mon, 5 Dec 2011 12:48:19 +0100
michael bouchaud <mic...@gm...> wrote:

> 2011/12/3 Michael Blumenkrantz <mic...@gm...>
> 
> > On Fri,  2 Dec 2011 09:53:37 -0800
> > "Enlightenment SVN" <no-...@en...> wrote:
> >
> > > Log:
> > > eet: revert works from discomfitor. too buggy elementary segv. I'm
> > pleased to
> > > SPANK him :D
> > >
> > > Author:       yoz
> > > Date:         2011-12-02 09:53:37 -0800 (Fri, 02 Dec 2011)
> > > New Revision: 65828
> > > Trac:         http://trac.enlightenment.org/e/changeset/65828
> > >
> > > Modified:
> > >   trunk/eet/ChangeLog trunk/eet/NEWS trunk/eet/src/lib/Eet_private.h
> > > trunk/eet/src/lib/Makefile.am trunk/eet/src/lib/eet_dictionary.c
> > > trunk/eet/src/lib/eet_lib.c
> > >
> > REVERSE SPANK SPANK SPANK.
> > COMPOUND INTEREST SPANK SPANK SPANK SPANK SPANK SPANK!
> >
> > Question: When was the last time a commit was reverted for causing
> > breakage?
> > Hint: despite breaking all apps during a code freeze, it was not @65619
> > Hint #2: even though it broke compile for several days, it was not @65642
> >
> > Answer: @64928 was reverted because it was caused breakage AND was wrong.
> >
> >
> > If you see something broken in trunk you have a number of options:
> > 1) fix it yourself -> THIS is when spankies should be administered
> > 2) tell the committer to fix it
> > 3) use an older commit until it gets fixed
> >
> >
> > Reverting commits is NOT the answer, and reverting only parts of them
> > is even worse.
> >
> >
> > ------------------------------------------------------------------------------
> > All the data continuously generated in your IT infrastructure
> > contains a definitive record of customers, application performance,
> > security threats, fraudulent activity, and more. Splunk takes this
> > data and makes sense of it. IT sense. And common sense.
> > http://p.sf.net/sfu/splunk-novd2d
> > _______________________________________________
> > enlightenment-devel mailing list
> > enl...@li...
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> 
> Sorry but I have seen something broken. elementary_test segfault. I have
> quickly investigate where does the problem. I have spotted your commit is
> the problem. So I have make a quick ping to you on irc, but no response. At
> this moment, I have to go. So don't have time to investigate how to fix it.
> I have talked about this problem to Cedric, who said me, to revert it.
> Thats why, I have revert it with a quickly friendly spanking. To tell you,
> there is something wrong here. And make 'elementary' usable for other who
> are not a devs. I have nothing against you.
I was trying to point out that we don't revert commits. It creates a bigger
hassle for someone trying to fix things, and as I've proven we've had much
worse things happen than something in svn being broken for a few hours.
> And if my revert was uncomplete, that's my mistake. So please accept my
> apologize.
> 
np